I can't repro this issue. bleung@, I can bring my device on Monday and try to repro together.

Can you repro this on latest canary?

Hi afakhry,

This is still happening on dev channel, on M71. 11151.13.0 (Official Build) dev-channel nocturne, Chrome Version 71.0.3578.23 (Official Build) dev (64-bit)


I don't believe it fails on M-72, however.

I didn't try on M-71. I will do so tomorrow as I'm WFH today.

Hi Amhed,

Here's another feedback report from my device using an external keyboard (Brydge BT keyboard).
https://listnr.corp.google.com/report/85754299983

This is on M-72, so I was incorrect. It still fails on M-72. 

It also appears the failure only happens if you're in tablet mode. So if you have a mouse attached, detach it and you should be able to repro the problem.

Precise build I reproed on:

       CHROME VERSION: 72.0.3593.0 canary
        CHROMEOS_AUSERVER: <URL: 5>
        CHROMEOS_RELEASE_BOARD: nocturne-signed-mpkeys
        CHROMEOS_RELEASE_DESCRIPTION: 11206.0.0 (Official Build) canary-channel nocturne 
        CHROMEOS_RELEASE_TRACK: canary-channel

Thanks for the details. I will test tomorrow when I'm back in the office.

I found an actual bug while working on this and filed issue 901022.

However, for this issue, it's currently WAI. In tablet mode, pressing the launcher key is intentionally ignored and it doesn't bring up the launcher. Caps Lock > Search remapping still works. (Try Caps Lock + Esc, it should bring up the Task Manager) .

I believe instead of ignoring the launcher key presses in tablet mode, we should minimize all windows to show the home launcher; similar to what we do when we press the launcher button in the shelf. +omrilio, and weidongg@ WDYT?

weidongg@ discussed with Omri, and this is currently not the right behavior. Can you please take a look?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7f768cd91aa03ad3db92efa733b86ca9c26df1

commit 9a7f768cd91aa03ad3db92efa733b86ca9c26df1
Author: Weidong Guo <weidongg@chromium.org>
Date: Fri Nov 02 17:21:57 2018

Apply the same behavior of app list shelf button to search key

Changes:
Extract logic triggered by app list shelf button into common function
which is also used by search key.

Bug:  896895 
Change-Id: Ie81ef2aee94cc56270842887c7554297b1a94575
Reviewed-on: https://chromium-review.googlesource.com/c/1313057
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604971}
[modify] https://crrev.com/9a7f768cd91aa03ad3db92efa733b86ca9c26df1/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/9a7f768cd91aa03ad3db92efa733b86ca9c26df1/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/9a7f768cd91aa03ad3db92efa733b86ca9c26df1/ash/app_list/app_list_controller_impl.h
[modify] https://crrev.com/9a7f768cd91aa03ad3db92efa733b86ca9c26df1/ash/shelf/app_list_shelf_item_delegate.cc

Not critical for M-71. Thanks for the quick fix.