New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 874155



Sign in to add a comment
link

Issue 896884: Add the Fuchsia http service tests to the waterfall

Reported by fdegans@chromium.org, Oct 18 Project Member

Issue description

Start by adding them to the FYI bots. Once they have proven stable on the FYI bots, add them to the main waterfall.
 

Comment 1 by w...@chromium.org, Oct 18

Labels: M-72

Comment 3 by bugdroid1@chromium.org, Oct 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64acd724761e65e247e1ba11069ffa81fd64be68

commit 64acd724761e65e247e1ba11069ffa81fd64be68
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Sat Oct 20 00:23:53 2018

Switch http_service_tests to use TestLauncher.

Previously, the http_service_tests suite was not using the TestLauncher
facilities, which caused it to fail on the waterfall.

Bug:  896884 
Change-Id: I9ce03cf45f0bd75944dce62bed5e16e2df6a4191
Tested: Locally
Reviewed-on: https://chromium-review.googlesource.com/c/1292591
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601368}
[modify] https://crrev.com/64acd724761e65e247e1ba11069ffa81fd64be68/webrunner/net_http/BUILD.gn
[delete] https://crrev.com/306ca8435ecd17c3ca7fc1692807a224650f7a3c/webrunner/net_http/http_service_test_main.cc
[modify] https://crrev.com/64acd724761e65e247e1ba11069ffa81fd64be68/webrunner/net_http/http_service_unittest.cc

Comment 4 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe231e0f716579f6c858e0fd97566ae15feff72

commit dbe231e0f716579f6c858e0fd97566ae15feff72
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Thu Dec 06 21:31:41 2018

[Fuchsia] Enable the http_service_tests suite on CQ.

Following various fixes, the test suite is now stable on FYI
bots. This test suite is quite small so the overhead should be
minimal.

Bug:  896884 
Change-Id: I44821e78b8807b6593d107c0d903f1130c1a3aed
Reviewed-on: https://chromium-review.googlesource.com/c/1366261
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614494}
[modify] https://crrev.com/dbe231e0f716579f6c858e0fd97566ae15feff72/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/dbe231e0f716579f6c858e0fd97566ae15feff72/testing/buildbot/test_suite_exceptions.pyl

Comment 5 by fdegans@chromium.org, Dec 13

Status: Verified (was: Started)
The http_service_tests have been on the waterfall for a week with no issue. Closing.

Sign in to add a comment