Download location: location dialog should not be annoying to the user. |
||||||
Issue descriptionChrome Version: 71.* OS: Android Currently download location dialog will show even the user doesn't have SD card. And if user cancel, we don't use the "Don't show again" checkbox, but always show the dialog again and again. This results in the user being confused and close the dialog, and the download that trigger the dialog will be canceled. This task is to implement a "less annoying" version of download location dialog. where: 1. Don't show if user don't have SD card. 2. Optional: use the checkbox "don't show again" when user cancels.
,
Oct 20
,
Oct 21
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ade596cc0b315f1f9c3292e1fd8d6182e32fde2 commit 9ade596cc0b315f1f9c3292e1fd8d6182e32fde2 Author: Xing Liu <xingliu@chromium.org> Date: Mon Oct 22 17:05:47 2018 Download location android: Check SD card before showing location dialog. This CL checks if the user has SD card. Don't show download location dialog if user don't have SD card. TBR=xingliu@chromium.org (cherry picked from commit 64cf7d9d47c095cf87f5aebf9be56a72c87049f3) Bug: 896873 Change-Id: I157b8958669c0692247f7cf3798f32867675b11c Reviewed-on: https://chromium-review.googlesource.com/c/1290509 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601365} Reviewed-on: https://chromium-review.googlesource.com/c/1294189 Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#220} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9ade596cc0b315f1f9c3292e1fd8d6182e32fde2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadLocationDialogBridge.java
,
Oct 22
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ade596cc0b315f1f9c3292e1fd8d6182e32fde2 Commit: 9ade596cc0b315f1f9c3292e1fd8d6182e32fde2 Author: xingliu@chromium.org Commiter: xingliu@chromium.org Date: 2018-10-22 17:05:47 +0000 UTC Download location android: Check SD card before showing location dialog. This CL checks if the user has SD card. Don't show download location dialog if user don't have SD card. TBR=xingliu@chromium.org (cherry picked from commit 64cf7d9d47c095cf87f5aebf9be56a72c87049f3) Bug: 896873 Change-Id: I157b8958669c0692247f7cf3798f32867675b11c Reviewed-on: https://chromium-review.googlesource.com/c/1290509 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601365} Reviewed-on: https://chromium-review.googlesource.com/c/1294189 Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#220} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33fb07fa14106dd74d95a62110e70daa2f75e990 commit 33fb07fa14106dd74d95a62110e70daa2f75e990 Author: Xing Liu <xingliu@chromium.org> Date: Wed Oct 24 20:10:14 2018 Android Download Location: Adds end to end tests. This CL adds Java end to end test for download location change feature. Bug: 896873 Change-Id: I0dd89dab0f1a4c36726f0795231a3116c00955c2 Reviewed-on: https://chromium-review.googlesource.com/c/1294670 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#602427} [modify] https://crrev.com/33fb07fa14106dd74d95a62110e70daa2f75e990/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadDirectoryProvider.java [modify] https://crrev.com/33fb07fa14106dd74d95a62110e70daa2f75e990/chrome/android/java_sources.gni [add] https://crrev.com/33fb07fa14106dd74d95a62110e70daa2f75e990/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadLocationChangeTest.java [modify] https://crrev.com/33fb07fa14106dd74d95a62110e70daa2f75e990/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTestRule.java [add] https://crrev.com/33fb07fa14106dd74d95a62110e70daa2f75e990/chrome/android/javatests/src/org/chromium/chrome/browser/download/TestDownloadDirectoryProvider.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 20