New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896870 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Chrome OS: Opening settings page as a guest segfaults

Project Member Reported by mcnee@chromium.org, Oct 18

Issue description

Chrome Version: 72.0.3585.0
OS: Chrome OS

What steps will reproduce the problem?
(1) On the Chrome OS initial setup screen, select Browse as Guest
(2) Attempt to open chrome://settings

Received signal 11 SEGV_MAPERR 000000000020
#0 0x592fda302def base::debug::StackTrace::StackTrace()
#1 0x592fda302961 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x79592b1072e0 <unknown>
#3 0x592fd91b92bf chromeos::multidevice_setup::AndroidSmsAppHelperDelegateImpl::AndroidSmsAppHelperDelegateImpl()
#4 0x592fdc73b3f3 settings::MdSettingsUI::MdSettingsUI()
#5 0x592fdc6b7312 (anonymous namespace)::NewWebUI<>()
#6 0x592fdc6b5fe7 ChromeWebUIControllerFactory::CreateWebUIControllerForURL()
#7 0x592fd8a3d0b2 content::WebUIControllerFactoryRegistry::CreateWebUIControllerForURL()
#8 0x592fd8a14866 content::WebContentsImpl::CreateWebUI()
#9 0x592fd8a14942 content::WebContentsImpl::CreateWebUIForRenderFrameHost()
#10 0x592fd8767a52 content::RenderFrameHostImpl::UpdatePendingWebUI()
#11 0x592fd8773662 content::RenderFrameHostManager::GetFrameHostForNavigation()
#12 0x592fd87734a2 content::RenderFrameHostManager::DidCreateNavigationRequest()
#13 0x592fd8727769 content::FrameTreeNode::CreatedNavigationRequest()
#14 0x592fd87495b3 content::NavigatorImpl::Navigate()
#15 0x592fd872f41f content::NavigationControllerImpl::NavigateWithoutEntry()
#16 0x592fd872ee80 content::NavigationControllerImpl::LoadURLWithParams()
#17 0x592fdc6eab08 (anonymous namespace)::LoadURLInContents()
#18 0x592fdc6ea24f Navigate()
#19 0x592fdc7a17dc chrome::SettingsWindowManager::ShowChromePageForProfile()
#20 0x592fdc6ee8c0 chrome::ShowSettingsSubPageForProfile()
#21 0x592fdc6ee814 chrome::ShowSettings()
#22 0x592fdc6e1cd6 chrome::BrowserCommandController::ExecuteCommandWithDisposition()
#23 0x592fdca2c0f7 AppMenu::ExecuteCommand()
#24 0x592fdb9c9fef views::internal::MenuRunnerImpl::OnMenuClosed()
#25 0x592fdba0ca2d views::MenuController::ExitMenu()
#26 0x592fdba0e2cc views::MenuController::OnMouseReleased()
#27 0x592fdb9f64c9 views::Widget::OnMouseEvent()
#28 0x592fdab696c6 ui::EventDispatcher::ProcessEvent()
#29 0x592fdab694a1 ui::EventDispatcherDelegate::DispatchEventToTarget()
#30 0x592fdab693e3 ui::EventDispatcherDelegate::DispatchEvent()
#31 0x592fdd90194e ui::EventProcessor::OnEventFromSource()
#32 0x592fdd901dfc ui::EventSource::SendEventToSinkFromRewriter()
#33 0x592fdc3311d5 ash::AshWindowTreeHostPlatform::DispatchEvent()
#34 0x592fdab6c55f ui::DispatchEventFromNativeUiEvent()
#35 0x592fd81b8a7b ui::DrmWindowHost::DispatchEvent()
#36 0x592fd81b8b1d ui::DrmWindowHost::DispatchEvent()
#37 0x592fda84c29f ui::PlatformEventSource::DispatchEvent()
#38 0x592fdafa8a34 ui::EventFactoryEvdev::DispatchMouseButtonEvent()
#39 0x592fda3197b1 base::debug::TaskAnnotator::RunTask()
#40 0x592fda288f2f base::MessageLoop::RunTask()
#41 0x592fda2892d2 base::MessageLoop::DoWork()
#42 0x592fda3163c9 base::MessagePumpLibevent::Run()
#43 0x592fda2a92d5 base::RunLoop::Run()
#44 0x592fd9eee78a ChromeBrowserMainParts::MainMessageLoopRun()
#45 0x592fd85fb654 content::BrowserMainLoop::RunMainMessageLoopParts()
#46 0x592fd85fdf02 content::BrowserMainRunnerImpl::Run()
#47 0x592fd85f7fe8 content::BrowserMain()
#48 0x592fd9edfe90 content::ContentMainRunnerImpl::Run()
#49 0x592fd9ee65dc service_manager::Main()
#50 0x592fd9ede111 content::ContentMain()
#51 0x592fd78f2f5f ChromeMain
#52 0x79592a4eb736 __libc_start_main
#53 0x592fd78f2d89 _start
  r8: 0000000000000080  r9: 0000000000000000 r10: 0000000017676fed r11: 000079592a6471a0
 r12: 0000240d3caec7b0 r13: 0000000000000000 r14: 0000240d3aba9f00 r15: 0000240d3aba9f00
  di: 0000240d3aba9f00  si: 0000240d3aba9f00  bp: 00007ffe49fcf040  bx: 0000240d3caec7b0
  dx: 0000000000000001  ax: 0000000000000000  cx: 0000000000000000  sp: 00007ffe49fcf030
  ip: 0000592fd91b92bf efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000020
[end of stack trace]
 
Cc: khorimoto@chromium.org jlklein@chromium.org hansberry@chromium.org
Components: UI>ProximityAuth
CC'ing owners.
Cc: jhawkins@chromium.org jordynass@chromium.org nohle@chromium.org hsuregan@chromium.org
Components: -UI>ProximityAuth UI>Multidevice
Labels: M-71
Owner: jlklein@chromium.org
Status: Assigned (was: Untriaged)
Looks like this was caused by https://chromium-review.googlesource.com/c/chromium/src/+/1173737. We should test this out on M-71 as well to see if we need to merge this fix back to the branch.
Cc: azeemarshad@chromium.org jonmann@chromium.org
Owner: azeemarshad@chromium.org
Jeremy is OOO. Azeem, can you please take a look at this stack trace?
Note that in the constructor, |web_app::WebAppProvider::Get(profile)| is null.
Status: Started (was: Assigned)
Spoke with Azeem offline, he has a good sense of how to resolve this issue, and is beginning work on it.

I'm certain this issue affects M71 as well, so we will want to request a merge into M71 once Azeem submits the fix on master.
Cc: kbleicher@chromium.org cros-conn-test-team@google.com abod...@chromium.org steve...@chromium.org dhadd...@chromium.org sdantul...@chromium.org
 Issue 896002  has been merged into this issue.
Labels: ReleaseBlock-Dev
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c4c258148ed1da7dd45128b172aad7aad39a83

commit 68c4c258148ed1da7dd45128b172aad7aad39a83
Author: Azeem Arshad <azeemarshad@chromium.org>
Date: Fri Oct 19 21:48:55 2018

[MutlideviceSettings] Gate multidevice settings for guest profiles

This CL fixes issue with settings page crashing in guest profiles.

Bug:  896870 
Change-Id: I39f4df84843e723b25300fefb8936c7839c3bd8d
Reviewed-on: https://chromium-review.googlesource.com/c/1289952
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601308}
[modify] https://crrev.com/68c4c258148ed1da7dd45128b172aad7aad39a83/chrome/browser/ui/webui/settings/md_settings_ui.cc

Please verify and request a merge for M71 so this doesn't block next week.  Thanks
Labels: Merge-Request-71
has the fix been verified?  I need test result assurance prior to approving.
I was able to reproduce this issue on my test device and confirm that the fix resolves it.
Labels: -Merge-Request-71 Merge-Approved-71
Approving merge to M71 Chrome OS.

Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 19

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5812e59e21760f08db4572616cfdfe6ae2dad10

commit e5812e59e21760f08db4572616cfdfe6ae2dad10
Author: Azeem Arshad <azeemarshad@chromium.org>
Date: Fri Oct 19 23:04:38 2018

[MutlideviceSettings] Gate multidevice settings for guest profiles

This CL fixes issue with settings page crashing in guest profiles.

Bug:  896870 
Change-Id: I39f4df84843e723b25300fefb8936c7839c3bd8d
Reviewed-on: https://chromium-review.googlesource.com/c/1289952
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601308}(cherry picked from commit 68c4c258148ed1da7dd45128b172aad7aad39a83)
Reviewed-on: https://chromium-review.googlesource.com/c/1292440
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#177}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/e5812e59e21760f08db4572616cfdfe6ae2dad10/chrome/browser/ui/webui/settings/md_settings_ui.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e5812e59e21760f08db4572616cfdfe6ae2dad10

Commit: e5812e59e21760f08db4572616cfdfe6ae2dad10
Author: azeemarshad@chromium.org
Commiter: jlklein@chromium.org
Date: 2018-10-19 23:04:38 +0000 UTC

[MutlideviceSettings] Gate multidevice settings for guest profiles

This CL fixes issue with settings page crashing in guest profiles.

Bug:  896870 
Change-Id: I39f4df84843e723b25300fefb8936c7839c3bd8d
Reviewed-on: https://chromium-review.googlesource.com/c/1289952
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601308}(cherry picked from commit 68c4c258148ed1da7dd45128b172aad7aad39a83)
Reviewed-on: https://chromium-review.googlesource.com/c/1292440
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#177}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Issue 896883 has been merged into this issue.

Sign in to add a comment