New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 896868: depot_tools sometimes reports invalid metrics.

Reported by ehmaldonado@google.com, Oct 18 Project Member

Issue description

depot_tools sometimes reports invalid metrics.

These are not recorded by the server, but cause 500 errors anyway.
 

Comment 1 by bugdroid1@chromium.org, Oct 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/93277a7fc8ef8ad9b5e2f774ea6e2e91c8ed3c9b

commit 93277a7fc8ef8ad9b5e2f774ea6e2e91c8ed3c9b
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Thu Oct 18 22:04:26 2018

git-cl: Don't report metrics for not-known repos.

It is not recorded by the server, but causes a 500 status anyway.

Bug: 896868
Change-Id: Ic3bf0d989bf3c3641dae9ea49a58ffb28f52e865
Reviewed-on: https://chromium-review.googlesource.com/c/1289769
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/93277a7fc8ef8ad9b5e2f774ea6e2e91c8ed3c9b/git_cl.py

Comment 2 by bugdroid1@chromium.org, Oct 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f379566233afd499318fb185369d0d7abb0c24b2

commit f379566233afd499318fb185369d0d7abb0c24b2
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Oct 19 01:48:08 2018

Roll src/third_party/depot_tools c1e6594df580..93277a7fc8ef (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c1e6594df580..93277a7fc8ef


git log c1e6594df580..93277a7fc8ef --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ehmaldonado@chromium.org git-cl: Don't report metrics for not-known repos.


Created with:
  gclient setdep -r src/third_party/depot_tools@93277a7fc8ef

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:896868
TBR=agable@chromium.org

Change-Id: I6fc12fb825faf3aaac42ce49bca253c0b07cd855
Reviewed-on: https://chromium-review.googlesource.com/c/1289656
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601018}
[modify] https://crrev.com/f379566233afd499318fb185369d0d7abb0c24b2/DEPS

Comment 3 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/066ba1a6ea28a9f6255364af3f9a0e2128d87adb

commit 066ba1a6ea28a9f6255364af3f9a0e2128d87adb
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Jan 09 02:22:12 2019

depot_tools_metrics: Add missing arguments.

Tbr: tandrii@chromium.org
Bug: 896868
Change-Id: Iaf08836385f6bf2b9a058c18014c5497a902b73f
Reviewed-on: https://chromium-review.googlesource.com/c/1401631
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19847}
[modify] https://crrev.com/066ba1a6ea28a9f6255364af3f9a0e2128d87adb/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.json

Sign in to add a comment