History entries duplicated for custom tab navigations |
||||||
Issue descriptionVersion: Chrome Dev 71.0.3574.0 OS: Android Repro steps: Open a link in a custom tab (i.e. a news article from the AGSA Feed) Open Chrome from the home screen Go to the history page Expected: page visited appears once in history page Actual: page visited is present as two duplicate entries. Looks like the entries can be individually deleted just fine. Also, when I look at another syncing device, the navigation only appears once, so it appears that history sync is working correctly on other devices. I tried turning off the local network and opening the history page, and the duplicate entry still appeared. As such, this seems like a local history issue, but +mastiz FYI in case.
,
Oct 18
Good question, looks like it doesn't repro with sync disabled actually. So perhaps this is Sync related, although strange that having the device offline when opening history didn't make a difference?
,
Oct 19
Adding sync component, as in fact this does seem sync related.
,
Oct 22
,
Dec 4
Sorry for the long delay! I could repro this, with two entries in history with slightly different URLs (URL fragment stripped in one of the two): Entry 1 (longer, received from Google Servers): https://www-foxnews-com.cdn.ampproject.org/v/s/www.foxnews.com/entertainment/cnn-panel-trashes-trump-after-u-s-capitol-visit-to-honor-george-h-w-bush.amp?amp_js_v=a2&_gsa=1#referrer=https%3A%2F%2Fwww.google.com&_tf=From%20%251%24s&share=https%3A%2F%2Fwww.foxnews.com%2Fentertainment%2Fcnn-panel-trashes-trump-after-u-s-capitol-visit-to-honor-george-h-w-bush Entry 2 (truncated, provided by local history): https://www-foxnews-com.cdn.ampproject.org/v/s/www.foxnews.com/entertainment/cnn-panel-trashes-trump-after-u-s-capitol-visit-to-honor-george-h-w-bush.amp?amp_js_v=a2&_gsa=1#referrer=https%3A%2F%2Fwww.google.com&_tf=From%20%251%24s The second entry is missing the URL fragment. I don't see any redirects being relevant here: not observed in Footprints and the URLs actually don't redirect to each other. BrowsingHistoryService seems to implement deduping based on exact URL matches, which in this case is too strict. I don't really know why the two URLs differ, but it doesn't seem a sync issue, so unassigning for now.
,
Dec 4
I skimmed through the AGSA code and it looks like the app appends those fragments (including ampshare and referrer). I can't confirm this 100%, but googlers can codesearch for REFERRER_FRAGMENT_PARAM. On chromium's side, the only alternative would be to implement more aggressive deduping in BrowsingHistoryService, which is questionable. On to sky@ as owner of history: has this deduping logic in BrowsingHistoryService been discussed from the product's PoV?
,
Dec 4
I'm not aware of any discussion of trying to find similar visits and prune them. Any heuristics we try would likely cause problems for certain use cases. IMO if the page is triggering visits, we should show them as is and not attempt to decide what is relevant and what isn't. I'm going to close this out. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mastiz@chromium.org
, Oct 18