Issue metadata
Sign in to add a comment
|
13.5% regression in cpu_time_percentage at 600029:600102 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 18
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11b7e5aee40000
,
Oct 18
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11b7e5aee40000
,
Oct 18
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/140c9a7ae40000
,
Oct 18
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/140c9a7ae40000 Reland gpu: Add UMA metric for measuring total raster task duration. by khushalsagar@chromium.org https://chromium.googlesource.com/chromium/src/+/cd8fbb77cfa164eef66378204a588443af9bb875 cpu_time_percentage: 0.1824 → 0.2011 (+0.01872) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/power-benchmarks
,
Oct 18
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da82bcce69bf5384435976a1945c9cb3270c5abb commit da82bcce69bf5384435976a1945c9cb3270c5abb Author: Khushal <khushalsagar@chromium.org> Date: Fri Oct 19 01:01:30 2018 gpu: Fix raster implementation error for no flush result available query The enum GL_QUERY_RESULT_AVAILABLE_NO_FLUSH_CHROMIUM_EXT was not being handled, and as a result we were doing a check before the result was available and causing a flush. R=piman@chromium.org Bug: 896830 , 894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4dc1ec22b2768d7d47ee63c61cc410554be563e Reviewed-on: https://chromium-review.googlesource.com/c/1289958 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#601003} [modify] https://crrev.com/da82bcce69bf5384435976a1945c9cb3270c5abb/gpu/command_buffer/client/raster_implementation.cc [modify] https://crrev.com/da82bcce69bf5384435976a1945c9cb3270c5abb/gpu/command_buffer/client/raster_implementation_unittest.cc
,
Oct 19
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/10bfa396e40000
,
Oct 19
And now I notice that the regression range for the alert on this particular bug is outside where the patch in #5 landed. :P Its 600029 - 600102. I have triggered another bisect for this particular regression.
,
Oct 19
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/10bfa396e40000
,
Oct 19
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/11ac9a7ae40000
,
Oct 19
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/11ac9a7ae40000
,
Oct 19
I'm going to WontFix this now. Pinpoint is not able to repro anymore and the graph has already recovered.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa6aa1fe175cee9ca0db6e9f142b2f1b4c7c97e6 commit fa6aa1fe175cee9ca0db6e9f142b2f1b4c7c97e6 Author: Khushal <khushalsagar@chromium.org> Date: Mon Oct 22 18:20:12 2018 gpu: Fix raster implementation error for no flush result available query The enum GL_QUERY_RESULT_AVAILABLE_NO_FLUSH_CHROMIUM_EXT was not being handled, and as a result we were doing a check before the result was available and causing a flush. R=piman@chromium.org Bug: 896830 , 894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4dc1ec22b2768d7d47ee63c61cc410554be563e Reviewed-on: https://chromium-review.googlesource.com/c/1289958 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601003}(cherry picked from commit da82bcce69bf5384435976a1945c9cb3270c5abb) Reviewed-on: https://chromium-review.googlesource.com/c/1294396 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#229} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/fa6aa1fe175cee9ca0db6e9f142b2f1b4c7c97e6/gpu/command_buffer/client/raster_implementation.cc [modify] https://crrev.com/fa6aa1fe175cee9ca0db6e9f142b2f1b4c7c97e6/gpu/command_buffer/client/raster_implementation_unittest.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa6aa1fe175cee9ca0db6e9f142b2f1b4c7c97e6 Commit: fa6aa1fe175cee9ca0db6e9f142b2f1b4c7c97e6 Author: khushalsagar@chromium.org Commiter: khushalsagar@chromium.org Date: 2018-10-22 18:20:12 +0000 UTC gpu: Fix raster implementation error for no flush result available query The enum GL_QUERY_RESULT_AVAILABLE_NO_FLUSH_CHROMIUM_EXT was not being handled, and as a result we were doing a check before the result was available and causing a flush. R=piman@chromium.org Bug: 896830 , 894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic4dc1ec22b2768d7d47ee63c61cc410554be563e Reviewed-on: https://chromium-review.googlesource.com/c/1289958 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601003}(cherry picked from commit da82bcce69bf5384435976a1945c9cb3270c5abb) Reviewed-on: https://chromium-review.googlesource.com/c/1294396 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#229} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 18