Example command: ./third_party/blink/tools/run_web_tests.py --debug virtual/display-lock No handlers could be found for logger "blinkpy.web_tests.port.base" Seems to be caused by https://chromium.googlesource.com/chromium/src/+/5f74e5433d04e79587c8f452a0d6a5dc3c96ca05
Looking at this. Xianzhu also told me this probblem offline but I can't quite reproduce. How do you reproduce this?
I already have a local CL to fix the issue. The error message indicates that something error happened in Port.default_target() (https://cs.chromium.org/chromium/src/third_party/blink/tools/blinkpy/web_tests/port/base.py?rcl=d92c98e07a9dac670efdca916a40eb20782cda31&l=1451), but _log.error() failed because the logging handler has not been initialized. You can try to change the _log.error() to print to show the actual message. I'm debugging and trying to fix the underlying error.
I will upload the printing CL first. Leaving the root cause to Ned.
This was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1289431
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcf5246f166884166122a55f11b6fae0297bf9f6 commit dcf5246f166884166122a55f11b6fae0297bf9f6 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Oct 19 04:09:00 2018 [run_web_tests] Initialize printer earlier This allows logging before creating the port. Bug: 896799 Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 Reviewed-on: https://chromium-review.googlesource.com/c/1289305 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#601049} [modify] https://crrev.com/dcf5246f166884166122a55f11b6fae0297bf9f6/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner.py [modify] https://crrev.com/dcf5246f166884166122a55f11b6fae0297bf9f6/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner_unittest.py [modify] https://crrev.com/dcf5246f166884166122a55f11b6fae0297bf9f6/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py [modify] https://crrev.com/dcf5246f166884166122a55f11b6fae0297bf9f6/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py [modify] https://crrev.com/dcf5246f166884166122a55f11b6fae0297bf9f6/third_party/blink/tools/blinkpy/web_tests/views/printing.py [modify] https://crrev.com/dcf5246f166884166122a55f11b6fae0297bf9f6/third_party/blink/tools/blinkpy/web_tests/views/printing_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee22baed82b3806d7a06a2b1d552063b61744df5 commit ee22baed82b3806d7a06a2b1d552063b61744df5 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Oct 19 07:57:31 2018 Revert "[run_web_tests] Initialize printer earlier" This reverts commit dcf5246f166884166122a55f11b6fae0297bf9f6. Reason for revert: It looks like this broke web_tests on linux-xenial-rel Original change's description: > [run_web_tests] Initialize printer earlier > > This allows logging before creating the port. > > Bug: 896799 > Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 > Reviewed-on: https://chromium-review.googlesource.com/c/1289305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#601049} TBR=wangxianzhu@chromium.org,dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org Change-Id: I71ae432b2db53611d6cd44d788d8f450e714ba78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896799 , 897019 Reviewed-on: https://chromium-review.googlesource.com/c/1290151 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601076} [modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner.py [modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner_unittest.py [modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py [modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py [modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/views/printing.py [modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/views/printing_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bae194e3fbf85a4f41e9da89e3466469405ed1b4 commit bae194e3fbf85a4f41e9da89e3466469405ed1b4 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Oct 19 18:49:07 2018 Reland "[run_web_tests] Initialize printer earlier" This is a reland of dcf5246f166884166122a55f11b6fae0297bf9f6 The fix is to ensure the logger has proper log level. Original change's description: > [run_web_tests] Initialize printer earlier > > This allows logging before creating the port. > > Bug: 896799 > Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 > Reviewed-on: https://chromium-review.googlesource.com/c/1289305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#601049} Bug: 896799 Change-Id: I7145e2aebf122c6fecf0732d56a81a808cffbe4d Reviewed-on: https://chromium-review.googlesource.com/c/1291358 Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601243} [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner.py [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner_unittest.py [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/views/metered_stream.py [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/views/printing.py [modify] https://crrev.com/bae194e3fbf85a4f41e9da89e3466469405ed1b4/third_party/blink/tools/blinkpy/web_tests/views/printing_unittest.py
Xianzhu actually did work to fix this :D
Comment 1 by nedngu...@google.com
, Oct 18Status: Started (was: Assigned)