Looks like we may have to compare the event targets and make sure they're the same. Half a fix at [1], introduces another bug.

Passing this off to the launcher folks.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1289303

This is shelf, no?

re #2 - Its can be activated from the shelf, but i feel its more of a launcher bug since it modifies the launcher. The shelf just forwards gestures.

Updated the title after talking offline with sammie.

Sammie,

What is the expected behavior here?

Same root cause as 897988?

Issue 897988 has been merged into this issue.

I dont have any spare cycles. ginko, can you look into this?

details:
in tablet mode, with a window open, swiping up on the shelf minimizes all windows.

I won't get to this soon. If it needs done quickly someone else should take it.

(I'll pick it back up in the event that I get my other priorities done)

Won't be getting to this soon, but aesthetically claiming as "owned" to help it not get "lost"

I recommend creating a methodology to help track P1s that nobody is currently working on?

wdyt, kaznacheev@?

This works for me:

https://bugs.chromium.org/p/chromium/issues/list?can=2&q=+hotlist%3Dnewcomer%40chromium.org%3ALauncher-Tech-Debt%2CLauncher-A11y%2CLauncher-Polishes%2CLauncher-Horizon+m%3D71&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids

passing off

as discussed not really a Shelf bug, so probably not Manu's expertise

Investigated a bit, found that the location drag event in [1] suddenly changes from (1166,887) (bottom of screen) to (1166,56) (Almost top of screen) even finder is still at bottom bezel. So dragging up from bezel and dragging up from shelf have different code paths. Think it's a bezel sensor issue?

[1] https://cs.chromium.org/chromium/src/ash/shelf/shelf_layout_manager.cc?q=shelf_layout&sq=package:chromium&g=0&l=382

+oshima@

Thats what i noticed too. Is there a way to detect if we're on the bezel? Otherwise i noticed the window targets change when we're on the bezel, so we can apply logics accordingly.

can you check if the location you're getting is correct?

I've seen the same thing in the emulator for a little while, where a drag down will "loop around" if you continue to drag off of the bottom of the emulator.

You can also see this happen with the app list in laptop mode, where you can drag the app list "closed" but keep dragging below the bottom and it will "loop around" from the "open" state

Home Gesture Handler was improperly handling all scroll down events from the shelf, which was also preventing autohide shelf scroll down from working. Preventing the improper handling prevents this bug as well.

Hey newcomer@ can we confirm we still want this merged to M71?
I think so I just want to be sure

Synced offline, lets see if UX wants this. 

If we merge it, this change should be as small and simple as possible in order to reduce risks because we are 4 weeks post branch.

Also, lets be sure to extensively manually test it on M-71 prior to merging.

I actually don't think so

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88f31b8e5396daa6d0e4570df76b5e5aa7b302c2

commit 88f31b8e5396daa6d0e4570df76b5e5aa7b302c2
Author: Kevin Strohbehn <ginko@google.com>
Date: Tue Oct 30 20:51:34 2018

Prevents Home Gesture from handling down-swipes on shelf

Bug:  896790 
Change-Id: I2d8de828cea27caa210755a0de8304ee293e55f9
Reviewed-on: https://chromium-review.googlesource.com/c/1307233
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604007}
[modify] https://crrev.com/88f31b8e5396daa6d0e4570df76b5e5aa7b302c2/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/88f31b8e5396daa6d0e4570df76b5e5aa7b302c2/ash/shelf/shelf_layout_manager.h

 Issue 900346  has been merged into this issue.

We will ask for Merge Approval here but we need to wait till it hits a canary build as per the branch announcement -- it's been 4 weeks 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/012b8a8cc6bca0b92a2527afe0078ab68b0841f9

commit 012b8a8cc6bca0b92a2527afe0078ab68b0841f9
Author: Kevin Strohbehn <ginko@google.com>
Date: Tue Oct 30 23:29:52 2018

Prevents down scrolls in mid-home-gesture event from being ignored

Bug:  896790 
Change-Id: I8fef79fbbd3790d344ad92170f506fe46feefdd6
Reviewed-on: https://chromium-review.googlesource.com/c/1308600
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#604056}
[modify] https://crrev.com/012b8a8cc6bca0b92a2527afe0078ab68b0841f9/ash/shelf/shelf_layout_manager.cc

Next action: wait for a canary build to test with this change, then request merge approval

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a

commit 1838e5dbaeecc5d3313655bd6b0a4c222f80e87a
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Nov 15 01:06:23 2018

applist: Remove dead code from home_laucher_gesture_handler.cc.

The logic to check if we should handle certain scrolls was moved to
shelf_layout_manager.cc in [1]. The logic remaining in
home_laucher_gesture_handler.cc is no longer needed.

[1] https://chromium-review.googlesource.com/c/1307233

Test: manual
Bug:  896790 
Change-Id: Ic4b8a65ff8b4f6f3b5ed39147c09a68506bb1181
Reviewed-on: https://chromium-review.googlesource.com/c/1334648
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608205}
[modify] https://crrev.com/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a/ash/app_list/home_launcher_gesture_handler.cc
[modify] https://crrev.com/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a/ash/app_list/home_launcher_gesture_handler.h
[modify] https://crrev.com/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/1838e5dbaeecc5d3313655bd6b0a4c222f80e87a/ash/shelf/shelf_layout_manager_unittest.cc