MediaEngagementServiceTest.CleanUpDatabaseWhenHistoryIsExpired is slow |
||
Issue descriptionThis test reproducibly takes >30s on my linux workstation. I couldn't immediately see why but it is one of the slow tests in the unit_tests target.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b687eb30ec55fbd7a6c53eca90d909522db6dde2 commit b687eb30ec55fbd7a6c53eca90d909522db6dde2 Author: Charlie Harrison <csharrison@chromium.org> Date: Thu Nov 15 19:06:02 2018 Fix slow test CleanUpDatabaseWhenHistoryIsExpired This test currently waits 30s before completing. This CL speeds it up by injecting a TestMockTimeTaskRunner and using it to fast forward time. Bug: 896787 Change-Id: I35cb9ea8f269bfa1a9d2cb35858e3fd697a41ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1334289 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608465} [modify] https://crrev.com/b687eb30ec55fbd7a6c53eca90d909522db6dde2/chrome/browser/media/media_engagement_service_unittest.cc [modify] https://crrev.com/b687eb30ec55fbd7a6c53eca90d909522db6dde2/components/history/core/browser/history_service.cc [modify] https://crrev.com/b687eb30ec55fbd7a6c53eca90d909522db6dde2/components/history/core/browser/history_service.h
,
Nov 15
|
||
►
Sign in to add a comment |
||
Comment 1 by csharrison@chromium.org
, Nov 6