New issue
Advanced search Search tips

Issue 896774 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Change Lite Page UI Strings

Project Member Reported by robertogden@chromium.org, Oct 18

Issue description

Use "provided" instead of "delivered"
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c61543e8740e61b22be6f0f0d1943b09bd8ba7

commit c0c61543e8740e61b22be6f0f0d1943b09bd8ba7
Author: Robert Ogden <robertogden@chromium.org>
Date: Thu Oct 18 19:30:21 2018

Change the Lite Page strings

It was agreed that we should use "provided" instead of "delivered".

Bug:  896774 
Change-Id: I542a0ffc217aa5601d114e5cf1541c12b5b9f990
Reviewed-on: https://chromium-review.googlesource.com/c/1289293
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600865}
[modify] https://crrev.com/c0c61543e8740e61b22be6f0f0d1943b09bd8ba7/chrome/android/java/strings/android_chrome_strings.grd

Labels: Merge-Request-71 OS-Android
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: There is .grd file changes and we are only 46 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: benmason@chromium.org
Ping for merge request
Is this change critical for M71?
Yes, this string relates to a feature releasing in M71 and we'd like to change it for better user clarity with respect ot privacy and how Google may have changed the page in a preview.
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Thanks for the update. Approved for merge to 71, branch 3578.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 22

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6b931db7a62dc6544023c6da1c0b6e8505dd758

commit c6b931db7a62dc6544023c6da1c0b6e8505dd758
Author: Robert Ogden <robertogden@chromium.org>
Date: Mon Oct 22 17:22:03 2018

Change the Lite Page strings

It was agreed that we should use "provided" instead of "delivered".

Bug:  896774 
Change-Id: I542a0ffc217aa5601d114e5cf1541c12b5b9f990
Reviewed-on: https://chromium-review.googlesource.com/c/1289293
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600865}(cherry picked from commit c0c61543e8740e61b22be6f0f0d1943b09bd8ba7)
Reviewed-on: https://chromium-review.googlesource.com/c/1294229
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#222}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/c6b931db7a62dc6544023c6da1c0b6e8505dd758/chrome/android/java/strings/android_chrome_strings.grd

Status: Fixed (was: Started)
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c6b931db7a62dc6544023c6da1c0b6e8505dd758

Commit: c6b931db7a62dc6544023c6da1c0b6e8505dd758
Author: robertogden@chromium.org
Commiter: tbansal@chromium.org
Date: 2018-10-22 17:22:03 +0000 UTC

Change the Lite Page strings

It was agreed that we should use "provided" instead of "delivered".

Bug:  896774 
Change-Id: I542a0ffc217aa5601d114e5cf1541c12b5b9f990
Reviewed-on: https://chromium-review.googlesource.com/c/1289293
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600865}(cherry picked from commit c0c61543e8740e61b22be6f0f0d1943b09bd8ba7)
Reviewed-on: https://chromium-review.googlesource.com/c/1294229
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#222}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment