Issue metadata
Sign in to add a comment
|
ChromeVox support for app shortcut search |
||||||||||||||||||||||||
Issue description
What steps will reproduce the problem?
(1) enable EnableAppShortcutSearch feature
(2) install Android GMail app
(3) type "Comp" in the Launcher search
(4) Observer the shortcut for "Compose" action badged with GMail icon
(5) Enable ChromeVox and tab to this shortcut
What is the expected result?
Both action name and app name are announced (e.g. "Perform Compose with Gmail")
What happens instead?
Just the action name announced ("Compose").
Please use labels and text to provide additional information.
If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.
For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
,
Oct 18
Laura, can you help me pick the string? My ideas so far: "Perform Compose with GMail" "Compose with GMail" "Compose using Gmail"
,
Oct 18
,
Oct 18
Discussed with lpalmaro@, agreed on "Compose using GMail"
,
Oct 18
jonann@, Laura suggested that I consult with you whether a parametrized string "<action> using <app>" is a good solution, especially with regards to i18n.
,
Oct 18
I like Compose with Gmail just because "-ing" verbs are harder to translate.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82c60d400248a6a8acacf00688f6e3fb88e3279c commit 82c60d400248a6a8acacf00688f6e3fb88e3279c Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Oct 25 15:12:58 2018 Customize A11y name for app shortcut search result Introduce accessible_name property on SearchResultMetadata and use it in SearchResultTileItemView instead of the title. Set this property for ArcAppShortcutSearchResult to a string that includes both the shortcut name and the app name. Bug: 896771 Test: steps in bug Change-Id: I75aa67b844741d2e1ab4f0eafb17ef25d1d18a4d Reviewed-on: https://chromium-review.googlesource.com/c/1289330 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602711} [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/ash/app_list/model/search/search_result.h [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/ash/app_list/views/search_result_tile_item_view.cc [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/ash/public/interfaces/app_list.mojom [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/chrome/app/generated_resources.grd [add] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/chrome/app/generated_resources_grd/IDS_APP_ACTION_SHORTCUT_ACCESSIBILITY_NAME.png.sha1 [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/chrome/browser/ui/app_list/search/arc/arc_app_shortcut_search_result.cc [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/chrome/browser/ui/app_list/search/arc/arc_app_shortcut_search_result.h [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/chrome/browser/ui/app_list/search/chrome_search_result.cc [modify] https://crrev.com/82c60d400248a6a8acacf00688f6e3fb88e3279c/chrome/browser/ui/app_list/search/chrome_search_result.h
,
Oct 25
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kaznacheev@chromium.org
, Oct 18