New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 888744



Sign in to add a comment

Reduce the size of offline Play Store terms of service

Project Member Reported by norvez@chromium.org, Oct 18

Issue description

We're very short on rootfs space, see Issue 888744, and the TOS added by  Issue 857275  take up quite a lot:

localhost ~ # du -h /usr/share/chromeos-assets/arc_tos/
448K    /usr/share/chromeos-assets/arc_tos/sv-se
472K    /usr/share/chromeos-assets/arc_tos/fr-be
456K    /usr/share/chromeos-assets/arc_tos/nl-be
460K    /usr/share/chromeos-assets/arc_tos/fi-fi
472K    /usr/share/chromeos-assets/arc_tos/fr-fr
448K    /usr/share/chromeos-assets/arc_tos/nb-no
448K    /usr/share/chromeos-assets/arc_tos/da-dk
40K     /usr/share/chromeos-assets/arc_tos/apac
428K    /usr/share/chromeos-assets/arc_tos/en-us
456K    /usr/share/chromeos-assets/arc_tos/fr-ca
40K     /usr/share/chromeos-assets/arc_tos/emea
604K    /usr/share/chromeos-assets/arc_tos/ko-kr
44K     /usr/share/chromeos-assets/arc_tos/en-ie
44K     /usr/share/chromeos-assets/arc_tos/en-gb
440K    /usr/share/chromeos-assets/arc_tos/eu
456K    /usr/share/chromeos-assets/arc_tos/nl-nl
40K     /usr/share/chromeos-assets/arc_tos/en-ca
468K    /usr/share/chromeos-assets/arc_tos/de-de
6.2M    /usr/share/chromeos-assets/arc_tos/
localhost ~ # 

Most of it is the privacy policy PDFs. Would it be possible to reduce the size of those, or use HTML instead?
 
Labels: M-71
Cc: r...@chromium.org
Worth noting: These assets are not used in M-71, as offline Demo Mode was punted. We plan to use them in M-72. We can remove them from the M-71 branch if that buys us time to figure out a better solution.

The difficulty is that the online Privacy Policy is very complex and can't easily be exported as just HTML.

Let's reach out to someone to see if there's a plaintext or a simpler HTML version of the Privacy Policy. Looks like sp@google.com might be the right contact.

As an alternative, we could explore moving these PDFs to the offline resources component. We'd then have to find a way to serve PDFs from the component in our OOBE webview.
Removing them from M-71 sounds good, buying more time would help :-)
And we can explore other space saving opportunities at the same time.
Cc: agawronska@chromium.org
Owner: michae...@chromium.org
Any update on this?
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/1eadf14502cbf57149d39052325f05bf2346f2f8

commit 1eadf14502cbf57149d39052325f05bf2346f2f8
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Sat Dec 01 09:08:44 2018

Blocking: 888744
Labels: -M-71 M-72 Merge-Request-72
Status: Fixed (was: Assigned)
Requesting merge to M72 because:

* Saves 6MiB of space on device to alleviate issue 888744
* Has little risk because the removed files are never used (they're behind a developer flag that isn't enabled)
Cc: abodenha@chromium.org
Awesome!
Labels: Merge-Approved-72
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 4

Labels: merge-merged-release-R72-11316.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/68e89bb6d6dfa7f65b973858a7db24ea4fe22caf

commit 68e89bb6d6dfa7f65b973858a7db24ea4fe22caf
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Dec 04 23:09:22 2018

Project Member

Comment 11 by sheriffbot@chromium.org, Dec 5

Labels: -Merge-Request-72 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 10

Cc: djmm@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 14

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by michae...@chromium.org, Yesterday (43 hours ago)

Labels: -Hotlist-Merge-Approved -Merge-Approved-72

Sign in to add a comment