Fix header guards of generated files to chromium style |
|||
Issue descriptionHeader guards of generated files need to follow chromium style. e.g.) gen/third_party/blink/renderer/bindings/core/v8/v8_internals.h #ifndef V8Internals_h #define V8Internals_h ... #endif // V8Internals_h should be changed to #ifndef THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_INTERNALS_H_ #define THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_INTERNALS_H_ ... #endif // THIRD_PARTY_BLINK_RENDERER_BINDINGS_CORE_V8_V8_INTERNALS_H_ Approximate measures of header files not following the rule in gen/third_party/blink $ find gen/third_party/blink -iname '*.h' | xargs grep '^#ifndef .*$' | wc -l 2950 $ find gen/third_party/blink -iname '*.h' | xargs grep '^#ifndef THIRD_PARTY.*_H_$' | wc -l 1195
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/551cdd50d55b4c722fc022cd40d8c4a8ee31039c commit 551cdd50d55b4c722fc022cd40d8c4a8ee31039c Author: Amos Lim <eui-sang.lim@samsung.com> Date: Mon Oct 22 03:27:21 2018 probe: Let generated header files follow chromium style on header guards Generated header files need to follow chromium style on header guards. Follow up to crrev.com/c/1235356 Bug: 896720 Change-Id: I0b7e1f7a3e6ba2d743979808d2b6247b6a19e12c Reviewed-on: https://chromium-review.googlesource.com/c/1291192 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#601472} [modify] https://crrev.com/551cdd50d55b4c722fc022cd40d8c4a8ee31039c/third_party/blink/renderer/build/scripts/make_instrumenting_probes.py [modify] https://crrev.com/551cdd50d55b4c722fc022cd40d8c4a8ee31039c/third_party/blink/renderer/build/scripts/templates/instrumenting_probes_inl.h.tmpl [modify] https://crrev.com/551cdd50d55b4c722fc022cd40d8c4a8ee31039c/third_party/blink/renderer/build/scripts/templates/probe_sink.h.tmpl
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5 commit 977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5 Author: Amos Lim <eui-sang.lim@samsung.com> Date: Mon Oct 22 04:30:33 2018 Let generated header files follow chromium style on header guards Generated header files need to follow chromium style on header guards. This CL has no behavior changes. Bug: 896720 Change-Id: I97dbc277af5fc7b85fef3a6f93facdfce2742927 Reviewed-on: https://chromium-review.googlesource.com/c/1292652 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#601475} [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/core/css/make_css_value_keywords.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/core/css/make_media_features.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/core/css/make_style_shorthands.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/core/css/templates/css_value_keywords.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/core/css/templates/media_features.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/core/css/templates/style_property_shorthand.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/make_internal_runtime_flags.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/make_internal_settings.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/make_origin_trials.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/make_runtime_features.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/make_settings.py [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/templates/internal_runtime_flags.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/templates/internal_settings_generated.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/templates/origin_trials.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/templates/runtime_enabled_features.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/templates/runtime_enabled_features_test_helpers.h.tmpl [modify] https://crrev.com/977c0041f5763e2d1cece2c9f7a6e5ed6bb425b5/third_party/blink/renderer/build/scripts/templates/settings_macros.h.tmpl
,
Oct 22
remained so far out/Default/gen/third_party/blink/renderer/core/xpath_grammar.h:#ifndef xpath_grammarH out/Default/gen/third_party/blink/renderer/core/xpath_grammar.h:#ifndef YY_XPATHYY_GEN_THIRD_PARTY_BLINK_RENDERER_CORE_XPATH_GRAMMAR_HH_INCLUDED out/Default/gen/third_party/blink/renderer/core/xpath_grammar.h:#ifndef YYDEBUG out/Default/gen/third_party/blink/renderer/core/xpath_grammar.h:#ifndef YYTOKENTYPE out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Memory.h:#ifndef blink_protocol_Memory_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Database.h:#ifndef blink_protocol_Database_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_ErrorSupport_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_Values_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_Object_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_ValueConversions_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_Maybe_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_Array_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_DispatcherBase_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Protocol.h:#ifndef blink_protocol_Parser_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/LayerTree.h:#ifndef blink_protocol_LayerTree_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Runtime.h:#ifndef blink_protocol_Runtime_imported_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Animation.h:#ifndef blink_protocol_Animation_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/IO.h:#ifndef blink_protocol_IO_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Emulation.h:#ifndef blink_protocol_Emulation_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Audits.h:#ifndef blink_protocol_Audits_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Security.h:#ifndef blink_protocol_Security_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/IndexedDB.h:#ifndef blink_protocol_IndexedDB_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/CSS.h:#ifndef blink_protocol_CSS_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Target.h:#ifndef blink_protocol_Target_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Accessibility.h:#ifndef blink_protocol_Accessibility_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Debugger.h:#ifndef blink_protocol_Debugger_imported_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Network.h:#ifndef blink_protocol_Network_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/CacheStorage.h:#ifndef blink_protocol_CacheStorage_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Forward.h:#ifndef blink_protocol_Forward_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Forward.h:#ifndef blink_protocol_Allocator_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Forward.h:#ifndef blink_protocol_FrontendChannel_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Overlay.h:#ifndef blink_protocol_Overlay_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/DOMStorage.h:#ifndef blink_protocol_DOMStorage_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/DOMSnapshot.h:#ifndef blink_protocol_DOMSnapshot_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/ApplicationCache.h:#ifndef blink_protocol_ApplicationCache_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Log.h:#ifndef blink_protocol_Log_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Performance.h:#ifndef blink_protocol_Performance_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Page.h:#ifndef blink_protocol_Page_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/DOM.h:#ifndef blink_protocol_DOM_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/DeviceOrientation.h:#ifndef blink_protocol_DeviceOrientation_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/DOMDebugger.h:#ifndef blink_protocol_DOMDebugger_h out/Default/gen/third_party/blink/renderer/core/inspector/protocol/Testing.h:#ifndef blink_protocol_Testing_h
,
Oct 22
xpath_grammarH is produced by renderer/build/scripts/rule_bison.py. I remember inspector protocol stuff is generated by a script outside of blink.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ca8d3e1b2142fbf5a1bcf215dc555ede418442d commit 3ca8d3e1b2142fbf5a1bcf215dc555ede418442d Author: Amos Lim <eui-sang.lim@samsung.com> Date: Mon Oct 22 08:46:52 2018 Let generated xpath_grammar header follow chromium style on header guards Generated header files need to follow chromium style on header guards. This CL has no behavior changes. Bug: 896720 Change-Id: I5ed457086e369fd515f5969daebfc8e1ef623112 Reviewed-on: https://chromium-review.googlesource.com/c/1293059 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#601502} [modify] https://crrev.com/3ca8d3e1b2142fbf5a1bcf215dc555ede418442d/third_party/blink/renderer/build/scripts/rule_bison.py
,
Oct 22
It seems all headers are fixed since inspector protocol stuff is generated by a script outside of blink. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 19