New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896719 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 850606



Sign in to add a comment

[autofill] Implement differential privacy metadata uploads

Project Member Reported by rogerm@chromium.org, Oct 18

Issue description

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6fe2acab1556fab23123e768eba7a7b0daadd48

commit d6fe2acab1556fab23123e768eba7a7b0daadd48
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Aug 10 14:45:59 2018

[autofill] Support consolidated uploads for a field.

This CL changes the uploaded autofilltype (i.e. vote) field to be repeating instead of a single required field per uploaded field.

Background: The autofill upload proto has a repeated "Field" attribute that has a single required autofilltype field. Autofill can send multiple votes for a given field (if a field matches the users full address as well as address line 1, for example). Prior to this CL, clients would send multiple "Field" entries (repeating all attached metadata) in the event of multiple votes. Clients also send multiple "Field" entries if there are fields having the same signature (address line 1,2, sharing the same field name/id, for example, is not uncommon). The recipient of these votes is not able to tell these 2 cases apart (multiple votes for a single field vs votes for multiple fields with the same signature).

With this CL, clients will upload exactly one "Field" entry per logical field in the form. In this way all type votes for a field will be consolsidated to a single Field entry. It will also consolidate (instead of repeating) any additional metadata send about the field into that single entry for the field.

Bug: 850606
Change-Id: I73acea17f755b6ebe37f11c9e72e02f9bf1c5484
Reviewed-on: https://chromium-review.googlesource.com/1142485
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582158}
[modify] https://crrev.com/d6fe2acab1556fab23123e768eba7a7b0daadd48/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/d6fe2acab1556fab23123e768eba7a7b0daadd48/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/d6fe2acab1556fab23123e768eba7a7b0daadd48/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/d6fe2acab1556fab23123e768eba7a7b0daadd48/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/d6fe2acab1556fab23123e768eba7a7b0daadd48/components/autofill/core/browser/proto/server.proto

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3bfe69f32bb1027b6983419c099679fea5eb7b

commit 2f3bfe69f32bb1027b6983419c099679fea5eb7b
Author: Roger McFarlane <rogerm@chromium.org>
Date: Tue Sep 11 15:43:22 2018

[autofill] Randomized rich metadata uploads.

This CL extends the autofill form upload "vote" proto to include
rich form/field metadata.

Autofill will crowd-source bit-level randomized encodings of the
first 64 bytes of the form's id, name and action as well as each
field's id, name, label, aria-label, aria-description, css-class,
placeholder value, plus a hash of the field initial value (to
detect placeholders that are prepopulated as initial values).
Each uploaded bit will randomly be sent as the true value or as
a random value.

Bug: 850606
Change-Id: I470876e4a04fca6cfabf5482f998573eacf86aa1
Reviewed-on: https://chromium-review.googlesource.com/1213878
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590324}
[modify] https://crrev.com/2f3bfe69f32bb1027b6983419c099679fea5eb7b/components/autofill/core/browser/proto/server.proto
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5

commit 3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Oct 11 15:48:06 2018

[autofill] Add a RandomizedEncoder class.

This CL adds a randomized encoder class. Instances of this class will
be used to encode autofill form and field metadata using differential
privacy, specifically randomized responses.

Bug: 850606
Change-Id: If0600595dafc6d3233674b92f40e3d092b2d5381
Reviewed-on: https://chromium-review.googlesource.com/c/1265832
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598775}
[modify] https://crrev.com/3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5/components/autofill/core/browser/DEPS
[add] https://crrev.com/3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5/components/autofill/core/browser/randomized_encoder.cc
[add] https://crrev.com/3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5/components/autofill/core/browser/randomized_encoder.h
[add] https://crrev.com/3d3b0c0cc3b595c73ccd3da72b2bbc162ff6bec5/components/autofill/core/browser/randomized_encoder_unittest.cc
(Reland) [Autofill] Save form submission button's title for FormData

Save a button title into FormData for crowdsourcing.

Title is inferred in two ways:
Type 1) Value attribute of an <input type="submit">.
Type 2) Text content of <button>

If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>:
$ <input type="submit">
& <button type="submit">
% <button type="button">

The value is truncated if the length is more than 200. The same value is used for labels.

TODO: introduce title inference when there is no <form> tag.
TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>)

TBR=rogerm@chromium.org, mkwst@chromium.org, wjmaclean@chromium.org

Bug: 850606
Change-Id: Ie51b0d5adc7a144f75918cbc7cc5bc0acda58b50
Reviewed-on: https://chromium-review.googlesource.com/c/1279179
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599416}
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/content/renderer/form_autofill_util_browsertest.cc
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/core/common/form_data.cc
[modify] https://crrev.com/e6d022a51b630be4cc232cc0a1956a7fdb71191c/components/autofill/core/common/form_data.h
Blocking: 850606

Comment 6 Deleted

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95c8ebc6e5b760aa85692b012f448c4fa10d53d6

commit 95c8ebc6e5b760aa85692b012f448c4fa10d53d6
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Nov 08 18:02:39 2018

[autofill] add iOS helpers to get aria-label and aria-description

This CL adds the getAriaLabel() and getAriaDescription() helper
functions to the __GCrWeb.fill "namespace". These functions return
the ARIA label and description strings associated with an element.

The ARIA Label is the text referenced by one or more containing element
ids in the labelled elements aria-labelledby attribute, or the value
of the element's aria-label attribute, with preference given to the
aria-labelledby attribute. For example:

    <div id='foo-label'>Label for Foo</div>
    <input name='foo' aria-labelledby='foo-label'>
    <input name='bar' aria-label='Label for Bar'>

The aria-description is similar to aria-labelledby. For example:

    <div id='foo-description'>Long descriptive text for Foo</div>
    <input name='foo' aria-describedby='foo-descrition'>

Bug: 896719
Change-Id: I300b84298fc20e1b86474f60d08cdd1c9569036b
Reviewed-on: https://chromium-review.googlesource.com/c/1325032
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606534}
[modify] https://crrev.com/95c8ebc6e5b760aa85692b012f448c4fa10d53d6/components/autofill/ios/form_util/fill_js_unittest.mm
[modify] https://crrev.com/95c8ebc6e5b760aa85692b012f448c4fa10d53d6/components/autofill/ios/form_util/resources/fill.js

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62dd51a1163937c255844b681c661a78d387b4b8

commit 62dd51a1163937c255844b681c661a78d387b4b8
Author: Patrik Höglund <phoglund@chromium.org>
Date: Fri Nov 09 12:12:29 2018

Revert "[autofill] add iOS helpers to get aria-label and aria-description"

This reverts commit 95c8ebc6e5b760aa85692b012f448c4fa10d53d6.

Reason for revert: Breaks FillJsTest: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/1004

JavaScript error: TypeError: __gCrWeb.fill.getAriaDescription is not a function.

Original change's description:
> [autofill] add iOS helpers to get aria-label and aria-description
> 
> This CL adds the getAriaLabel() and getAriaDescription() helper
> functions to the __GCrWeb.fill "namespace". These functions return
> the ARIA label and description strings associated with an element.
> 
> The ARIA Label is the text referenced by one or more containing element
> ids in the labelled elements aria-labelledby attribute, or the value
> of the element's aria-label attribute, with preference given to the
> aria-labelledby attribute. For example:
> 
>     <div id='foo-label'>Label for Foo</div>
>     <input name='foo' aria-labelledby='foo-label'>
>     <input name='bar' aria-label='Label for Bar'>
> 
> The aria-description is similar to aria-labelledby. For example:
> 
>     <div id='foo-description'>Long descriptive text for Foo</div>
>     <input name='foo' aria-describedby='foo-descrition'>
> 
> Bug: 896719
> Change-Id: I300b84298fc20e1b86474f60d08cdd1c9569036b
> Reviewed-on: https://chromium-review.googlesource.com/c/1325032
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606534}

TBR=rogerm@chromium.org,sebsg@chromium.org,mahmadi@chromium.org

Change-Id: I00eb534e6639c829f6ed5b312406ce51ba2aa429
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896719
Reviewed-on: https://chromium-review.googlesource.com/c/1329002
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606803}
[modify] https://crrev.com/62dd51a1163937c255844b681c661a78d387b4b8/components/autofill/ios/form_util/fill_js_unittest.mm
[modify] https://crrev.com/62dd51a1163937c255844b681c661a78d387b4b8/components/autofill/ios/form_util/resources/fill.js

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13fd76a041fb3443821e8d57eb396248af04208c

commit 13fd76a041fb3443821e8d57eb396248af04208c
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Nov 09 19:38:33 2018

[autofill] Add helpers to get the ARIA labels and descriptions

This CL adds the GetAriaLabel() and GetAriaDescription() helper functions
to the autofill::form_util namespace. These functions return the ARIA
label and description strings associated with an element.

The ARIA Label is the text referenced by one or more containing element
ids in the labelled elements aria-labelledby attribute, or the value
of the element's aria-label attribute, with preference given to the
aria-labelledby attribute. For example:

    <div id='foo-label'>Label for Foo</div>
    <input name='foo' aria-labelledby='foo-label'>
    <input name='bar' aria-label='Label for Bar'>

The aria-description is similar to aria-labelledby. For example:

    <div id='foo-description'>Long descriptive text for Foo</div>
    <input name='foo' aria-describedby='foo-descrition'>

Bug: 896719
Change-Id: Ida72c467d2e876b4d7a60ad56de56c7bac5489ec
Reviewed-on: https://chromium-review.googlesource.com/c/1325535
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606936}
[modify] https://crrev.com/13fd76a041fb3443821e8d57eb396248af04208c/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/13fd76a041fb3443821e8d57eb396248af04208c/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/13fd76a041fb3443821e8d57eb396248af04208c/components/autofill/content/renderer/form_autofill_util_browsertest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb1ec49cbaf759b914ed33d3e2e407668aafdc4c

commit cb1ec49cbaf759b914ed33d3e2e407668aafdc4c
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Nov 09 20:29:42 2018

[autofill] add iOS helpers to get aria-label and aria-description

This CL adds the getAriaLabel() and getAriaDescription() helper
functions to the __gCrWeb.fill "namespace". These functions return
the ARIA label and description strings associated with an element.

The ARIA Label is the text referenced by one or more containing element
ids in the labelled elements aria-labelledby attribute, or the value
of the element's aria-label attribute, with preference given to the
aria-labelledby attribute. For example:

    <div id='foo-label'>Label for Foo</div>
    <input name='foo' aria-labelledby='foo-label'>
    <input name='bar' aria-label='Label for Bar'>

The aria-description is similar to aria-labelledby. For example:

    <div id='foo-description'>Long descriptive text for Foo</div>
    <input name='foo' aria-describedby='foo-descrition'>

Bug: 896719
Change-Id: Ib69154fe4a98389f466d8ce81cbb7c3b0cfe3215
Reviewed-on: https://chromium-review.googlesource.com/c/1329898
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606953}
[modify] https://crrev.com/cb1ec49cbaf759b914ed33d3e2e407668aafdc4c/components/autofill/ios/form_util/fill_js_unittest.mm
[modify] https://crrev.com/cb1ec49cbaf759b914ed33d3e2e407668aafdc4c/components/autofill/ios/form_util/resources/fill.js

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875398a1508765d3ef86de055619234ecc9a6c91

commit 875398a1508765d3ef86de055619234ecc9a6c91
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Nov 09 21:40:50 2018

[autofill] Inject only the necessary JS requred for the test

Bug: 896719
Change-Id: I52ae96084f32210ef187a023fa6090f57928a654
Reviewed-on: https://chromium-review.googlesource.com/c/1330343
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606974}
[modify] https://crrev.com/875398a1508765d3ef86de055619234ecc9a6c91/components/autofill/ios/form_util/fill_js_unittest.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70eb2e93c93a3be80da288b28bceb430638b684b

commit 70eb2e93c93a3be80da288b28bceb430638b684b
Author: Roger McFarlane <rogerm@chromium.org>
Date: Sat Nov 10 04:37:25 2018

[autofill] Send randomized form metadata with uploads

This is a two part change.

(1) Explicitly add the form/field id and name attributes to the data passed
    across the renderer/browser boundary. The pre-existing name and id
    properties of each form/field were computed values that attempted to
    capture whichever of the id/name was available. These values need to
    be passed from the renderer/JS to the browser so they can be included
    in the randomized form metadata sent with uploads.

    This part of the change is mostly mechanical, but involves updating a
    significant number of unittests.

(2) Integrate the RandomizedEncoder to enable Rich Metadata Uploads. This
    augments the vote information sent from the client with additional form
    and field metadata that has been randomized (differential privacy via
    randomized responses), preventing any given upload from revealing the
    metadata observed by the client, but reconstructible in aggregate if
    sufficient clients send the same underlying metadata.

Bug: 896719
Change-Id: Id866bd358eccbebdf952063bf5f6dcb9b59ad194
Reviewed-on: https://chromium-review.googlesource.com/c/1279202
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607101}
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/chrome/renderer/autofill/autofill_renderer_browsertest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/android/form_field_data_android.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/randomized_encoder.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/browser/randomized_encoder.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/autofill_switches.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/autofill_switches.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/form_data.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/form_field_data.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/form_field_data_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/core/common/password_form_fill_data.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/ios/browser/autofill_agent_unittests.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/ios/browser/autofill_util.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/ios/form_util/form_activity_tab_helper_unittest.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/autofill/ios/form_util/resources/fill.js
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/form_parser.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/form_parser_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/fuzzer/form_data_essentials.proto
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/fuzzer/form_data_producer.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/fuzzer/form_data_proto_producer.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/ios_form_parser.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_parsing/ios_form_parser_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_saver_impl.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/form_saver_impl_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/new_password_form_manager_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/core/browser/votes_uploader.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/ios/account_select_fill_data_unittest.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/components/password_manager/ios/test_helpers.cc
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/ios/chrome/browser/autofill/autofill_controller_js_unittest.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/ios/chrome/browser/autofill/js_autofill_manager_unittest.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/70eb2e93c93a3be80da288b28bceb430638b684b/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe

commit 68d6fb15d48a5b6a6faa61edaa88b5524a9946fe
Author: Roger McFarlane <rogerm@chromium.org>
Date: Wed Nov 28 04:52:21 2018

[autofill] add plumbing for ARIA label and description

This CL integrates ARIA label and description parsing into the render/JS
to browser communication path. This allows the browser to have knowledge
of the ARIA label and description.

Bug: 896719
Change-Id: If5e8d9389f10beecae102080ebcde066aae6c80a
Reviewed-on: https://chromium-review.googlesource.com/c/1342673
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611564}
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/components/autofill/ios/form_util/resources/fill.js
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/ios/chrome/browser/autofill/autofill_controller_js_unittest.mm
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/ios/chrome/browser/autofill/js_autofill_manager_unittest.mm
[modify] https://crrev.com/68d6fb15d48a5b6a6faa61edaa88b5524a9946fe/ios/chrome/browser/passwords/password_controller_js_unittest.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 3 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e740369e19bfcb30d64355098eb54e91763f68a6

commit e740369e19bfcb30d64355098eb54e91763f68a6
Author: Roger McFarlane <rogerm@chromium.org>
Date: Mon Dec 03 22:04:08 2018

[autofill] Add roundtrip unittests for the RandomizedEncoder.

This CL adds unittests which validate that a collection of independent
randomized encodings of a given input string can be decoded to recover
the portions common to most/all users.

Bug: 896719
Change-Id: Ibe3305b62ddcf643bef6979589a1011427cfcbd2
Reviewed-on: https://chromium-review.googlesource.com/c/1357642
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613276}
[modify] https://crrev.com/e740369e19bfcb30d64355098eb54e91763f68a6/components/autofill/core/browser/randomized_encoder_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 6 (3 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375260f7da26d6910344c5904c849b916ff217c8

commit 375260f7da26d6910344c5904c849b916ff217c8
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Dec 06 16:54:37 2018

Remove iOS Translate Event Logging in Sync

The feature is disabled by default, no config currently applies, and it
was decided to stop collecting these events. This removes the iOS
portion of the code because it allows removing a translate -> sync
dependency that was preventing another change from landing.

Bug: 896719,911781
Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
Reviewed-on: https://chromium-review.googlesource.com/c/1361927
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614385}
[modify] https://crrev.com/375260f7da26d6910344c5904c849b916ff217c8/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/375260f7da26d6910344c5904c849b916ff217c8/ios/chrome/browser/translate/chrome_ios_translate_client.mm

Project Member

Comment 16 by bugdroid1@chromium.org, Yesterday (47 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8833d2a079a192c103d4fe17d785aeb300ab0e8

commit f8833d2a079a192c103d4fe17d785aeb300ab0e8
Author: Roger McFarlane <rogerm@chromium.org>
Date: Fri Dec 07 23:14:57 2018

[autofill] Add page language to autofill uploads

This CL adds the detected language of the page to the metadata sent
with a form upload.

Bug: 896719
Change-Id: Ia7fa04dfc8f02af9399b923ca2056a2cb2b04371
Reviewed-on: https://chromium-review.googlesource.com/c/1358634
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614861}
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/autofill_client.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/components/password_manager/core/browser/votes_uploader.cc
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/ios/chrome/browser/passwords/ios_chrome_password_manager_client.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/f8833d2a079a192c103d4fe17d785aeb300ab0e8/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm

Sign in to add a comment