New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: ----



Sign in to add a comment
link

Issue 896710: Add EXO support to Chromecast

Reported by dnicoara@chromium.org, Oct 18 Project Member

Issue description

Feature description:

Add fullscreen shell support to EXO and remove ChromeOS specific dependencies from EXO to allow EXO to compile on other platforms (such as Chromecast).
 

Comment 1 by bugdroid1@chromium.org, Oct 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ed3026e6774df83c99804888ebc3a46d27abb8

commit 41ed3026e6774df83c99804888ebc3a46d27abb8
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Oct 19 17:23:37 2018

Remove ash dependencies from exo when not using ChromeOS

Removed ash dependencies within EXO BUILD.gn file to allow
non-ChromeOS compilation.

Bug: 896710
Test: Compiled client on ChromeOS and verified it still builds.
Change-Id: I57b36c10ad55a609b7969f00b225abecd2f55fd9
Reviewed-on: https://chromium-review.googlesource.com/c/1288894
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#601204}
[modify] https://crrev.com/41ed3026e6774df83c99804888ebc3a46d27abb8/components/exo/BUILD.gn

Comment 2 by bugdroid1@chromium.org, Oct 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6a3384ff6614f79139afdd7fd095211fcca1da7

commit a6a3384ff6614f79139afdd7fd095211fcca1da7
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Oct 26 18:05:31 2018

Add fullscreen client

Added a sample fullscreen client. The client demonstrates usage of the
Wayland Fullscreen Shell protocol.

Does not run without server-side fullscreen shell implementation.

Bug: 896710
Test: Compiled client on ChromeOS and verified it still builds.
Change-Id: I681e864c739faafee07b257fd4c15c49929859cc
Reviewed-on: https://chromium-review.googlesource.com/c/1281424
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603146}
[modify] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/client_base.cc
[modify] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/client_base.h
[modify] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/client_helper.cc
[modify] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/client_helper.h
[add] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/fullscreen_shell.cc
[add] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/fullscreen_shell.h
[add] https://crrev.com/a6a3384ff6614f79139afdd7fd095211fcca1da7/components/exo/wayland/clients/fullscreen_shell_main.cc

Comment 3 by bugdroid1@chromium.org, Oct 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be19d6d9275b04199449c9ee059a84551bdd034a

commit be19d6d9275b04199449c9ee059a84551bdd034a
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Oct 26 18:34:20 2018

Move ash/cros files under is_chromeos

Moved ash files under is_chromeos for eventual
non-ChromeOS compilation.

Bug: 896710
Test: Built on ChromeOS.
Change-Id: Ic03a4b6ce9edab2ce5b5d0c50f2cce46bd96ae50
Reviewed-on: https://chromium-review.googlesource.com/c/1291778
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603154}
[modify] https://crrev.com/be19d6d9275b04199449c9ee059a84551bdd034a/components/exo/wayland/BUILD.gn

Comment 4 by bugdroid1@chromium.org, Nov 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344

commit 0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344
Author: Shawn Gallea <sagallea@google.com>
Date: Mon Nov 05 18:55:04 2018

Change exo/WMHelper into an interface

Allows OS-specific implementations of WMHelper
Change ChromeOS-specific files to use WMHelperChromeOS.
This CL does not change functionality.

Bug: 896710
Test: Built and ran on ChromeOS.
Change-Id: I3e2970313e85b07fdab97bd6e8645d8d3b23b40d
Reviewed-on: https://chromium-review.googlesource.com/c/1292602
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605398}
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/ash/system/message_center/arc/arc_notification_content_view_unittest.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/ash/wayland/wayland_server_controller.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/BUILD.gn
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/pointer.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/pointer.h
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/wayland/server.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/wm_helper.cc
[modify] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/wm_helper.h
[add] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/wm_helper_chromeos.cc
[add] https://crrev.com/0a2ee0a310c2ec2d17f078f3cda2f391e1e5e344/components/exo/wm_helper_chromeos.h

Comment 5 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35677217d19818bfea32803e63a0f01b49be83ee

commit 35677217d19818bfea32803e63a0f01b49be83ee
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Nov 06 20:32:13 2018

EXO: Add GetRootWindowForNewWindows function to wm_helper interface

Added GetRootWindowForNewWindows and implemented in wm_helper_chromeos.
This allows simple retrieval of root window from
window manager, used for setting parent window when creating
widgets (https://chromium-review.googlesource.com/c/chromium/src/+/1298172/20,
fullscreen_shell_surface.cc).

Bug: 896710
Test: Built and ran on ChromeOS
Change-Id: Ie43bea17c31cdf79402fadea441d5bc924e64503
Reviewed-on: https://chromium-review.googlesource.com/c/1302823
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#605806}
[modify] https://crrev.com/35677217d19818bfea32803e63a0f01b49be83ee/components/exo/shell_surface_base.cc
[modify] https://crrev.com/35677217d19818bfea32803e63a0f01b49be83ee/components/exo/wm_helper.h
[modify] https://crrev.com/35677217d19818bfea32803e63a0f01b49be83ee/components/exo/wm_helper_chromeos.cc
[modify] https://crrev.com/35677217d19818bfea32803e63a0f01b49be83ee/components/exo/wm_helper_chromeos.h

Comment 6 by bugdroid1@chromium.org, Nov 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909fe15fb1722de6476e1d8a84762afe96abdced

commit 909fe15fb1722de6476e1d8a84762afe96abdced
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Nov 06 22:26:45 2018

Add cast shell wm_helper class

Add enable_cast_wayland_server flag to selectively enable exo server use.
Add a Cast-specific implementation of wm_helper.
This implementation contains the minimum required to make exo work on cast shell.

support EXO.

Bug: 896710
Test: Built on ChromeOS, is not utilized yet as cast does not yet
Change-Id: I0e38a415fbdecdbe7f116885ed9048834cbca1b5
Reviewed-on: https://chromium-review.googlesource.com/c/1294835
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605851}
[modify] https://crrev.com/909fe15fb1722de6476e1d8a84762afe96abdced/chromecast/BUILD.gn
[modify] https://crrev.com/909fe15fb1722de6476e1d8a84762afe96abdced/chromecast/browser/BUILD.gn
[add] https://crrev.com/909fe15fb1722de6476e1d8a84762afe96abdced/chromecast/browser/exo/DEPS
[add] https://crrev.com/909fe15fb1722de6476e1d8a84762afe96abdced/chromecast/browser/exo/wm_helper_cast_shell.cc
[add] https://crrev.com/909fe15fb1722de6476e1d8a84762afe96abdced/chromecast/browser/exo/wm_helper_cast_shell.h
[modify] https://crrev.com/909fe15fb1722de6476e1d8a84762afe96abdced/chromecast/chromecast.gni

Comment 7 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6190601c5bf4e7fec7e280c57f3e216b2ddd7163

commit 6190601c5bf4e7fec7e280c57f3e216b2ddd7163
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 08 20:44:16 2018

EXO: Change surface includes

Remove pointer.h include and replace with wm_helper.h include.
pointer.h is not needed, but wm_helper is needed as it was transitively
included through pointer.h.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ic3dea290b4662cc5d868e7568c4909257dd55122
Reviewed-on: https://chromium-review.googlesource.com/c/1324749
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#606594}
[modify] https://crrev.com/6190601c5bf4e7fec7e280c57f3e216b2ddd7163/components/exo/surface.cc

Comment 8 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6190601c5bf4e7fec7e280c57f3e216b2ddd7163

commit 6190601c5bf4e7fec7e280c57f3e216b2ddd7163
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 08 20:44:16 2018

EXO: Change surface includes

Remove pointer.h include and replace with wm_helper.h include.
pointer.h is not needed, but wm_helper is needed as it was transitively
included through pointer.h.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ic3dea290b4662cc5d868e7568c4909257dd55122
Reviewed-on: https://chromium-review.googlesource.com/c/1324749
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#606594}
[modify] https://crrev.com/6190601c5bf4e7fec7e280c57f3e216b2ddd7163/components/exo/surface.cc

Comment 9 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3803f14f3dd1df15fce9eb5b13bd8d7ac746fddb

commit 3803f14f3dd1df15fce9eb5b13bd8d7ac746fddb
Author: Shawn Gallea <sagallea@google.com>
Date: Mon Nov 12 15:41:41 2018

EXO: Adjusted client_base for cast

Moved shell and aura shell checks to when not using fullscreen shell.
This is needed for cast to run fullscreen clients.

Bug: 896710
Test: Compiled client on ChromeOS.
Change-Id: Ie4c408d8266a0957ad9b57ea332a8e38171b2be9
Reviewed-on: https://chromium-review.googlesource.com/c/1331170
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#607235}
[modify] https://crrev.com/3803f14f3dd1df15fce9eb5b13bd8d7ac746fddb/components/exo/wayland/clients/client_base.cc

Comment 10 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d190843847cdb5cff0dc258d15cf3fa5d763c19f

commit d190843847cdb5cff0dc258d15cf3fa5d763c19f
Author: Shawn Gallea <sagallea@google.com>
Date: Mon Nov 12 15:49:39 2018

EXO: Added FullscreenShellSurface

Created FullscreenShellSurface class, similar to ShellSurface but without
any ash dependencies, to be used with fullscreen wayland protocol
to allow EXO use on other platforms.

Added unit test for FullscreenShellSurface for cast.

Bug: 896710
Test: Compiled on ChromeOS
Change-Id: I542c9b0729b847f4cde2fa67d727143e18f4a2a5
Reviewed-on: https://chromium-review.googlesource.com/c/1298172
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607237}
[modify] https://crrev.com/d190843847cdb5cff0dc258d15cf3fa5d763c19f/components/exo/BUILD.gn
[add] https://crrev.com/d190843847cdb5cff0dc258d15cf3fa5d763c19f/components/exo/fullscreen_shell_surface.cc
[add] https://crrev.com/d190843847cdb5cff0dc258d15cf3fa5d763c19f/components/exo/fullscreen_shell_surface.h
[add] https://crrev.com/d190843847cdb5cff0dc258d15cf3fa5d763c19f/components/exo/fullscreen_shell_surface_unittest.cc
[add] https://crrev.com/d190843847cdb5cff0dc258d15cf3fa5d763c19f/components/exo/test/exo_test_base_cast.cc
[add] https://crrev.com/d190843847cdb5cff0dc258d15cf3fa5d763c19f/components/exo/test/exo_test_base_cast.h

Comment 11 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fbba49dc9e193e72b4c8680776404803b2d7a92

commit 3fbba49dc9e193e72b4c8680776404803b2d7a92
Author: Shawn Gallea <sagallea@google.com>
Date: Mon Nov 12 23:20:51 2018

EXO: Fullscreen protocol server implementation

An incomplete implementation of the fullscreen shell protocol,
separated from server.cc to allow selective compilation for
different platforms that support EXO. The rest of the protocols within
server.cc will be refactored in future CLs.

Bug: 896710
Test: Compiled on ChromeOS, works with fullscreen client
Change-Id: Idda3b73c97c72e5efd16dfe1f7c79831587c8066
Reviewed-on: https://chromium-review.googlesource.com/c/1299838
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607369}
[modify] https://crrev.com/3fbba49dc9e193e72b4c8680776404803b2d7a92/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/3fbba49dc9e193e72b4c8680776404803b2d7a92/components/exo/wayland/server.cc
[add] https://crrev.com/3fbba49dc9e193e72b4c8680776404803b2d7a92/components/exo/wayland/server_util.h
[add] https://crrev.com/3fbba49dc9e193e72b4c8680776404803b2d7a92/components/exo/wayland/zwp_fullscreen_shell.cc
[add] https://crrev.com/3fbba49dc9e193e72b4c8680776404803b2d7a92/components/exo/wayland/zwp_fullscreen_shell.h

Comment 12 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cffa68fb4f18d69306cce115f53781b5b12c6a4

commit 1cffa68fb4f18d69306cce115f53781b5b12c6a4
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Nov 13 01:48:52 2018

EXO: Refactored zcr_notification_shell interface into its own file

EXO: Moved zcr_notification_shell_v1_interface into another file,
to be followed by refactoring of more protocols.

Bug: 896710
Test: Compiled on ChromeOS.
Change-Id: I0884132357f8acadb8d5659b9330abae8acc7cd1
Reviewed-on: https://chromium-review.googlesource.com/c/1302861
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607424}
[modify] https://crrev.com/1cffa68fb4f18d69306cce115f53781b5b12c6a4/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/1cffa68fb4f18d69306cce115f53781b5b12c6a4/components/exo/wayland/server.cc
[add] https://crrev.com/1cffa68fb4f18d69306cce115f53781b5b12c6a4/components/exo/wayland/zcr_notification_shell.cc
[add] https://crrev.com/1cffa68fb4f18d69306cce115f53781b5b12c6a4/components/exo/wayland/zcr_notification_shell.h

Comment 13 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aad8b28a8aade3673fc088a466d5af7b99c1bd33

commit aad8b28a8aade3673fc088a466d5af7b99c1bd33
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Nov 13 21:05:08 2018

EXO: Refactored text input interface into its own file

Moved text_input_manager_v1 interface into another file,
to be followed by refactoring of more protocols.

Refactor wayland_text_input_delegate.* from server.cc
with no new code.

Modify server_util to add more utilities

Bug: 896710
Test: Compiled on ChromeOS.
Change-Id: I2739c538a16640fdaebed1cd7493d300dd42a5a9
Reviewed-on: https://chromium-review.googlesource.com/c/1306406
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#607738}
[modify] https://crrev.com/aad8b28a8aade3673fc088a466d5af7b99c1bd33/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/aad8b28a8aade3673fc088a466d5af7b99c1bd33/components/exo/wayland/server.cc
[add] https://crrev.com/aad8b28a8aade3673fc088a466d5af7b99c1bd33/components/exo/wayland/server_util.cc
[modify] https://crrev.com/aad8b28a8aade3673fc088a466d5af7b99c1bd33/components/exo/wayland/server_util.h
[add] https://crrev.com/aad8b28a8aade3673fc088a466d5af7b99c1bd33/components/exo/wayland/zwp_text_input_manager.cc
[add] https://crrev.com/aad8b28a8aade3673fc088a466d5af7b99c1bd33/components/exo/wayland/zwp_text_input_manager.h

Comment 14 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02bb1be52442d9786b9faa4d94477a95504bcce7

commit 02bb1be52442d9786b9faa4d94477a95504bcce7
Author: Shawn Gallea <sagallea@google.com>
Date: Wed Nov 14 18:10:54 2018

EXO: Move WaylandInputDelegate out of server.cc

Include wayland_input_delegate.h in server.cc until a later CL,
this is needed for classes in server.cc that inherit from it.

Bug: 896710
Test: Build ChromeOS
Change-Id: I668280ccceab8a9e75874247919d0d0b3fea1cb1
Reviewed-on: https://chromium-review.googlesource.com/c/1316100
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608035}
[modify] https://crrev.com/02bb1be52442d9786b9faa4d94477a95504bcce7/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/02bb1be52442d9786b9faa4d94477a95504bcce7/components/exo/wayland/server.cc
[add] https://crrev.com/02bb1be52442d9786b9faa4d94477a95504bcce7/components/exo/wayland/wayland_input_delegate.cc
[add] https://crrev.com/02bb1be52442d9786b9faa4d94477a95504bcce7/components/exo/wayland/wayland_input_delegate.h

Comment 15 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1

commit 0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1
Author: Shawn Gallea <sagallea@google.com>
Date: Wed Nov 14 20:24:50 2018

EXO: Move WaylandPointerDelegate out of server.cc

This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Id9567918d751a9768d00489b5532a1abea3490e6
Reviewed-on: https://chromium-review.googlesource.com/c/1318083
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608106}
[modify] https://crrev.com/0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1/components/exo/wayland/server.cc
[add] https://crrev.com/0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1/components/exo/wayland/wayland_pointer_delegate.cc
[add] https://crrev.com/0f4e2cd968006ac3a6a608ea3a44657ceebe2bb1/components/exo/wayland/wayland_pointer_delegate.h

Comment 16 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1310d8a56bf35875b40caf2919e6944b5b13b15a

commit 1310d8a56bf35875b40caf2919e6944b5b13b15a
Author: Shawn Gallea <sagallea@google.com>
Date: Wed Nov 14 23:07:21 2018

EXO: Refactor WaylandKeyboardDelegate from server.cc

Move WaylandKeyboardDelegate out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I09a062796c987ca23137acb081b05ea129badeba
Reviewed-on: https://chromium-review.googlesource.com/c/1318576
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608159}
[modify] https://crrev.com/1310d8a56bf35875b40caf2919e6944b5b13b15a/components/exo/keyboard_delegate.h
[modify] https://crrev.com/1310d8a56bf35875b40caf2919e6944b5b13b15a/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/1310d8a56bf35875b40caf2919e6944b5b13b15a/components/exo/wayland/server.cc
[add] https://crrev.com/1310d8a56bf35875b40caf2919e6944b5b13b15a/components/exo/wayland/wayland_keyboard_delegate.cc
[add] https://crrev.com/1310d8a56bf35875b40caf2919e6944b5b13b15a/components/exo/wayland/wayland_keyboard_delegate.h

Comment 17 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc16b65e4922f22c2d2b3c37172c9541dc0f0af

commit ebc16b65e4922f22c2d2b3c37172c9541dc0f0af
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 15 01:24:42 2018

EXO: Refactor WaylandTouchDelegate into its own file

Move WaylandTouchDelegate out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I8fc2cb3d52c76bdcc4d52c70e63beeb6cd403894
Reviewed-on: https://chromium-review.googlesource.com/c/1318737
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608211}
[modify] https://crrev.com/ebc16b65e4922f22c2d2b3c37172c9541dc0f0af/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/ebc16b65e4922f22c2d2b3c37172c9541dc0f0af/components/exo/wayland/server.cc
[add] https://crrev.com/ebc16b65e4922f22c2d2b3c37172c9541dc0f0af/components/exo/wayland/wayland_touch_delegate.cc
[add] https://crrev.com/ebc16b65e4922f22c2d2b3c37172c9541dc0f0af/components/exo/wayland/wayland_touch_delegate.h

Comment 18 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2761eb6a36be2d79ebfba0959ce87c96e2248174

commit 2761eb6a36be2d79ebfba0959ce87c96e2248174
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 15 02:16:19 2018

EXO: Refactor input timestamps manager interface

Move input timestamps manager out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I65e8baba6d20b726cf69fed3b90286d6ea7cd756
Reviewed-on: https://chromium-review.googlesource.com/c/1318789
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608228}
[modify] https://crrev.com/2761eb6a36be2d79ebfba0959ce87c96e2248174/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/2761eb6a36be2d79ebfba0959ce87c96e2248174/components/exo/wayland/server.cc
[add] https://crrev.com/2761eb6a36be2d79ebfba0959ce87c96e2248174/components/exo/wayland/zwp_input_timestamps_manager.cc
[add] https://crrev.com/2761eb6a36be2d79ebfba0959ce87c96e2248174/components/exo/wayland/zwp_input_timestamps_manager.h

Comment 19 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac6e26e178cc7ec47f245df631d4dc6efd8e301c

commit ac6e26e178cc7ec47f245df631d4dc6efd8e301c
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 15 18:15:25 2018

EXO: Refactored keyboard extension interface

Move keyboard extension out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I15ea4ac7f9c5cabf9470d0478cd91a409c0b5e6a
Reviewed-on: https://chromium-review.googlesource.com/c/1320028
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608439}
[modify] https://crrev.com/ac6e26e178cc7ec47f245df631d4dc6efd8e301c/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/ac6e26e178cc7ec47f245df631d4dc6efd8e301c/components/exo/wayland/server.cc
[add] https://crrev.com/ac6e26e178cc7ec47f245df631d4dc6efd8e301c/components/exo/wayland/zcr_keyboard_extension.cc
[add] https://crrev.com/ac6e26e178cc7ec47f245df631d4dc6efd8e301c/components/exo/wayland/zcr_keyboard_extension.h

Comment 20 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a

commit 9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 15 20:40:40 2018

EXO: Refactored keyboard configuration interface

Move keyboard configuration out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ia40aa6614ff1d386bdb3241c0fee9499d73d18a7
Reviewed-on: https://chromium-review.googlesource.com/c/1320655
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#608500}
[modify] https://crrev.com/9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a/components/exo/wayland/server.cc
[add] https://crrev.com/9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a/components/exo/wayland/zcr_keyboard_configuration.cc
[add] https://crrev.com/9e5c91f5695c84ffdc06ddbff56f1a7b8d2bb42a/components/exo/wayland/zcr_keyboard_configuration.h

Comment 21 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a14927161820befb917de50f511f76cca40267da

commit a14927161820befb917de50f511f76cca40267da
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 01:54:05 2018

EXO: Refactored gaming input interface

Move gaming input interface  out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I9202fc459a4f1095d20f83e7d1b64822beca9028
Reviewed-on: https://chromium-review.googlesource.com/c/1323693
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608626}
[modify] https://crrev.com/a14927161820befb917de50f511f76cca40267da/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/a14927161820befb917de50f511f76cca40267da/components/exo/wayland/server.cc
[add] https://crrev.com/a14927161820befb917de50f511f76cca40267da/components/exo/wayland/zcr_gaming_input.cc
[add] https://crrev.com/a14927161820befb917de50f511f76cca40267da/components/exo/wayland/zcr_gaming_input.h

Comment 22 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a98ab8d1ffe8be4c8fcff147778c8c5ee4df579

commit 5a98ab8d1ffe8be4c8fcff147778c8c5ee4df579
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 03:21:05 2018

EXO: Refactored wl_shell interface

Move wl_shell interface  out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ic9b4a8d0cb68c30c0836af103c326aee70f66811
Reviewed-on: https://chromium-review.googlesource.com/c/1323969
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608644}
[modify] https://crrev.com/5a98ab8d1ffe8be4c8fcff147778c8c5ee4df579/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/5a98ab8d1ffe8be4c8fcff147778c8c5ee4df579/components/exo/wayland/server.cc
[add] https://crrev.com/5a98ab8d1ffe8be4c8fcff147778c8c5ee4df579/components/exo/wayland/wl_shell.cc
[add] https://crrev.com/5a98ab8d1ffe8be4c8fcff147778c8c5ee4df579/components/exo/wayland/wl_shell.h

Comment 23 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb7196c9fff019e9cfa914bcece3027e2d5e728

commit 8cb7196c9fff019e9cfa914bcece3027e2d5e728
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 04:47:37 2018

EXO: Refactored xdg_shell interface

Move xdg_shell interface  out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Idb117f086ffa995661291772b122b261aa869794
Reviewed-on: https://chromium-review.googlesource.com/c/1323901
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608666}
[modify] https://crrev.com/8cb7196c9fff019e9cfa914bcece3027e2d5e728/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/8cb7196c9fff019e9cfa914bcece3027e2d5e728/components/exo/wayland/server.cc
[add] https://crrev.com/8cb7196c9fff019e9cfa914bcece3027e2d5e728/components/exo/wayland/zxdg_shell.cc
[add] https://crrev.com/8cb7196c9fff019e9cfa914bcece3027e2d5e728/components/exo/wayland/zxdg_shell.h

Comment 24 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d60abd6863674f2dee022c207aab7b869ef1b8f

commit 4d60abd6863674f2dee022c207aab7b869ef1b8f
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 06:45:43 2018

EXO: Refactored remote shell interface

Move zcr_remote_shell interface out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I4ed019e376e5c374315c6bd5c0dab330588376f5
Reviewed-on: https://chromium-review.googlesource.com/c/1324092
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608675}
[modify] https://crrev.com/4d60abd6863674f2dee022c207aab7b869ef1b8f/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/4d60abd6863674f2dee022c207aab7b869ef1b8f/components/exo/wayland/server.cc
[add] https://crrev.com/4d60abd6863674f2dee022c207aab7b869ef1b8f/components/exo/wayland/zcr_remote_shell.cc
[add] https://crrev.com/4d60abd6863674f2dee022c207aab7b869ef1b8f/components/exo/wayland/zcr_remote_shell.h

Comment 25 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7702f587458103caefab5ae442bd361c5d6b779

commit a7702f587458103caefab5ae442bd361c5d6b779
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 16:32:21 2018

EXO: Change FullscreenShellSurface to correctly set widget bounds

Set params.bounds for widget within FullscreenShellSurface

Bug: 896710
Test: FullscreenShellSurfaceTest.Bounds
Change-Id: I250e99c177a2fd4ad15fab64d5a7929195441cb6
Reviewed-on: https://chromium-review.googlesource.com/c/1336000
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608793}
[modify] https://crrev.com/a7702f587458103caefab5ae442bd361c5d6b779/components/exo/fullscreen_shell_surface.cc
[modify] https://crrev.com/a7702f587458103caefab5ae442bd361c5d6b779/components/exo/fullscreen_shell_surface_unittest.cc

Comment 26 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca8bd3c4e9d20d51254ef56fdf8b85c4882e779

commit 0ca8bd3c4e9d20d51254ef56fdf8b85c4882e779
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 20:36:26 2018

EXO: Fix FullscreenShellSurface Bounds Unittest

Fix bounds unittest to make sure an offset from fullscreen_surface
will be detected.

Bug: 896710
Test: FullscreenShellSurfaceTest.Bounds
Change-Id: Ia8e3213b5c854f423537a9d0e58455f3d497bea7
Reviewed-on: https://chromium-review.googlesource.com/c/1340863
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#608926}
[modify] https://crrev.com/0ca8bd3c4e9d20d51254ef56fdf8b85c4882e779/components/exo/fullscreen_shell_surface_unittest.cc

Comment 27 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39d6f944c40d550b980388f05cbb83feed614398

commit 39d6f944c40d550b980388f05cbb83feed614398
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 20:55:26 2018

EXO: Refactored wl_seat interface for cast usage

Move wl_seat interface out of server.cc,
removed usage of keyboard and pointer for cast shell.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I3e91381883ff028e684b5c4bfbb1dd744cf31ed8
Reviewed-on: https://chromium-review.googlesource.com/c/1324099
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608933}
[modify] https://crrev.com/39d6f944c40d550b980388f05cbb83feed614398/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/39d6f944c40d550b980388f05cbb83feed614398/components/exo/wayland/server.cc
[add] https://crrev.com/39d6f944c40d550b980388f05cbb83feed614398/components/exo/wayland/wl_seat.cc
[add] https://crrev.com/39d6f944c40d550b980388f05cbb83feed614398/components/exo/wayland/wl_seat.h

Comment 28 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69bc5c76e250b9961e9d9797dd063ab4382e354d

commit 69bc5c76e250b9961e9d9797dd063ab4382e354d
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 22:00:25 2018

EXO: Refactored cursor_shapes interface

Move cursor_shapes interface out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I43f93d25bf08f57d0f111ba99404a1fecb3723da
Reviewed-on: https://chromium-review.googlesource.com/c/1324139
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608970}
[modify] https://crrev.com/69bc5c76e250b9961e9d9797dd063ab4382e354d/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/69bc5c76e250b9961e9d9797dd063ab4382e354d/components/exo/wayland/server.cc
[add] https://crrev.com/69bc5c76e250b9961e9d9797dd063ab4382e354d/components/exo/wayland/zcr_cursor_shapes.cc
[add] https://crrev.com/69bc5c76e250b9961e9d9797dd063ab4382e354d/components/exo/wayland/zcr_cursor_shapes.h

Comment 29 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75550404ad791fa7e2d8873fe4651db1e7fbbd0a

commit 75550404ad791fa7e2d8873fe4651db1e7fbbd0a
Author: Shawn Gallea <sagallea@google.com>
Date: Fri Nov 16 22:49:26 2018

EXO: Refactored stylus_tools interface

Move stylus_tools interface out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: Ie891710ea8df139f49ae350cd40ec9f083870460
Reviewed-on: https://chromium-review.googlesource.com/c/1324141
Commit-Queue: Shawn Gallea <sagallea@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609003}
[modify] https://crrev.com/75550404ad791fa7e2d8873fe4651db1e7fbbd0a/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/75550404ad791fa7e2d8873fe4651db1e7fbbd0a/components/exo/wayland/server.cc
[add] https://crrev.com/75550404ad791fa7e2d8873fe4651db1e7fbbd0a/components/exo/wayland/zcr_stylus_tools.cc
[add] https://crrev.com/75550404ad791fa7e2d8873fe4651db1e7fbbd0a/components/exo/wayland/zcr_stylus_tools.h

Comment 30 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad8550ccb548b7572d8928ec24d7fc3573938063

commit ad8550ccb548b7572d8928ec24d7fc3573938063
Author: Shawn Gallea <sagallea@google.com>
Date: Mon Nov 19 19:26:05 2018

EXO: Refactor pointer_gestures interface

Move pointer_gestures interface out of server.cc
This CL only moves code around.

Bug: 896710
Test: Built on ChromeOS
Change-Id: I5f33889794bc1ff3645f6bb0006fd9b8c87de5df
Reviewed-on: https://chromium-review.googlesource.com/c/1324146
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609392}
[modify] https://crrev.com/ad8550ccb548b7572d8928ec24d7fc3573938063/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/ad8550ccb548b7572d8928ec24d7fc3573938063/components/exo/wayland/server.cc
[add] https://crrev.com/ad8550ccb548b7572d8928ec24d7fc3573938063/components/exo/wayland/zwp_pointer_gestures.cc
[add] https://crrev.com/ad8550ccb548b7572d8928ec24d7fc3573938063/components/exo/wayland/zwp_pointer_gestures.h

Comment 31 by dnicoara@chromium.org, Nov 22

Owner: dnicoara@chromium.org

Comment 32 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2c085ec43c3f07126244a599cf6b39afc08cbf2

commit a2c085ec43c3f07126244a599cf6b39afc08cbf2
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Nov 27 18:40:23 2018

EXO: Modify exo/seat for cast, add shell_surface_util

Prevented ChromeOS-specific funcionality in seat.cc
from compiling for other platforms. To be used for EXO on cast shell.

Added shell_surface_util, containing utility functions previously
included in shell_surface_base, needed for exo on cast.

TBR=yusukes@chromium.org

Bug: 896710
Test: Run exo_unittests and unit_tests on ChromeOS build.
Change-Id: I3d66b09a6e236e731913ecc77cd0fdbe7937e74a
Reviewed-on: https://chromium-review.googlesource.com/c/1327562
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611215}
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/chromeos/crostini/crostini_registry_service.h
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/ui/ash/launcher/arc_app_window.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/ui/ash/launcher/crostini_app_window_shelf_controller.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/arc/ime/arc_ime_service.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/BUILD.gn
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/fullscreen_shell_surface.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/fullscreen_shell_surface.h
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/fullscreen_shell_surface_unittest.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/gaming_seat.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/notification_surface.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/seat.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/shell_surface.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/shell_surface_base.cc
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/shell_surface_base.h
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/shell_surface_unittest.cc
[add] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/shell_surface_util.cc
[add] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/shell_surface_util.h
[modify] https://crrev.com/a2c085ec43c3f07126244a599cf6b39afc08cbf2/components/exo/wayland/zcr_remote_shell.cc

Comment 33 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/787ef559970542f236413f4a6c27c7269af64494

commit 787ef559970542f236413f4a6c27c7269af64494
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Nov 27 23:29:24 2018

EXO: Move zaura_shell interface and wl_output out of server.cc

Refactor zaura_shell and wl_output out of server.cc to isolate generic
Wayland API implementations from ChromeOS specific ones. This will allow
ChromeOS specific APIs to be conditionally compiled on builds that don't
need them. This helps port EXO to Chromecast where Ash (ChromeOS' window
manager) isn't present.

Changes:
 * Move zaura_shell into its own file since this won't be compiled on
 Chromecast.
 * Move Output and WaylandDisplayObserver into their own files since
 these are shared between zaura_shell, wl_output and Server.
 * Move wl_output into its own file since all its dependencies have been
 refactored out of server.cc.

Bug: 896710
Test: Run exo_unittests
Change-Id: I51b42301b5b7fcf53b1879373a2b50db6e799dd1
Reviewed-on: https://chromium-review.googlesource.com/c/1328233
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611410}
[modify] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/server.cc
[modify] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/server.h
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/wayland_display_observer.cc
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/wayland_display_observer.h
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/wayland_display_output.cc
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/wayland_display_output.h
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/wl_output.cc
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/wl_output.h
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/zaura_shell.cc
[add] https://crrev.com/787ef559970542f236413f4a6c27c7269af64494/components/exo/wayland/zaura_shell.h

Comment 34 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cc35fded983ded85d04ccd487e4b1590c70fdb5

commit 1cc35fded983ded85d04ccd487e4b1590c70fdb5
Author: Shawn Gallea <sagallea@google.com>
Date: Wed Nov 28 14:50:17 2018

EXO: Add OnDisplayMetricsChanged, TargetHandlers for WMHelperCastShell

Change OnDisplayMetricsChanged to create new ManagedDisplayInfo for
display if OnDisplayAdded was never called for the display.
This is needed for the initial display on cast.

Bug: 896710
Test: None
Change-Id: I3b7d4829874b61b2115d25071a0de7bb74dba246
Reviewed-on: https://chromium-review.googlesource.com/c/1329859
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611692}
[modify] https://crrev.com/1cc35fded983ded85d04ccd487e4b1590c70fdb5/chromecast/browser/exo/wm_helper_cast_shell.cc

Comment 35 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a1bf38bf40f4674aab3e6cf048e445c291d062a

commit 9a1bf38bf40f4674aab3e6cf048e445c291d062a
Author: Shawn Gallea <sagallea@google.com>
Date: Wed Nov 28 16:40:17 2018

EXO: Conditionally build ChromeOS Wayland protocols

Moved protocols under is_chromeos for selective compilation. These
protocols have ChromeOS dependencies and would not compile on other
platforms. This is needed for eventual compilation of exo on Chromecast.

Bug: 896710
Test: Run exo_unittests
Change-Id: Id30ebdc8bf8338cba9e21a87350ab206b6d6057c
Reviewed-on: https://chromium-review.googlesource.com/c/1328566
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611729}
[modify] https://crrev.com/9a1bf38bf40f4674aab3e6cf048e445c291d062a/components/exo/wayland/BUILD.gn

Comment 36 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac50cd4a8c6089d2ee55f2139605343da97c1ea4

commit ac50cd4a8c6089d2ee55f2139605343da97c1ea4
Author: Shawn Gallea <sagallea@google.com>
Date: Wed Nov 28 18:39:56 2018

EXO: Conditionally bind ChromeOS APIs

APIs that have Ash dependencies can only run on ChromeOS so bind them
only when building for ChromeOS. This allows EXO to build on Chromecast.

Bug: 896710
Test: None
Change-Id: I60acf956b5a0f682f89c97b5818bb54cefcc7113
Reviewed-on: https://chromium-review.googlesource.com/c/1328702
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611791}
[modify] https://crrev.com/ac50cd4a8c6089d2ee55f2139605343da97c1ea4/components/exo/wayland/server.cc

Comment 37 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/217b468d2f79d37781269a07785df00672a68cb9

commit 217b468d2f79d37781269a07785df00672a68cb9
Author: Shawn Gallea <sagallea@google.com>
Date: Thu Nov 29 16:20:23 2018

EXO: Refactor out CrOS-specific functionality (exo/display)

Prevented ChromeOS-specific funcionality from compiling
for other platforms. To be used for EXO on cast shell.
This CL does not offer any additional functionality.

Bug: 896710
Test: Run exo_unittests on ChromeOS
Change-Id: I72678ae35efce395f932b7d0ade816d61dd6e992
Reviewed-on: https://chromium-review.googlesource.com/c/1327402
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612224}
[modify] https://crrev.com/217b468d2f79d37781269a07785df00672a68cb9/components/exo/display.cc
[modify] https://crrev.com/217b468d2f79d37781269a07785df00672a68cb9/components/exo/display.h

Comment 38 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fde3d8fc7eb82fc76e2e7be654680aa6710695bd

commit fde3d8fc7eb82fc76e2e7be654680aa6710695bd
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Dec 04 21:17:55 2018

EXO: Move LayerTreeFrameSinkHolder lifetime hook into exo interface

LayerTreeFrameSinkHolder needs to outlive its SurfaceTreeHost parent
when buffers are still in flight and haven't been released. To work
around this issue EXO currently relies on an ash::Shell lifetime
observer to determine when to release the resources during shutdown. In
order to remove the Ash dependency create a LifetimeManager object owned
by WMHelper and have LayerTreeFrameSinkHolder use that to cleanup during
shutdown.

This should be equivalent on ChromeOS as EXO is destroyed as part of the
same shutdown procedure as ash::Shell and EXO needs to be destroyed just
before ash::Shell as EXO has dependencies on ash::Shell.

Bug: 896710
Test: Run exo_unittests
Change-Id: I9518bc2ec8e5e5955e26f52e4ce61b9870085c8d
Reviewed-on: https://chromium-review.googlesource.com/c/1327408
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613696}
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/chromecast/browser/exo/wm_helper_cast_shell.cc
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/chromecast/browser/exo/wm_helper_cast_shell.h
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/test/exo_test_base_cast.cc
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/wm_helper.cc
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/wm_helper.h
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/wm_helper_chromeos.cc
[modify] https://crrev.com/fde3d8fc7eb82fc76e2e7be654680aa6710695bd/components/exo/wm_helper_chromeos.h

Comment 39 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4ff65627e9699ea0085d5fb9267429f9474bd4

commit 3b4ff65627e9699ea0085d5fb9267429f9474bd4
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Dec 04 21:52:52 2018

EXO: Move GetTargetSurfaceForLocatedEvent out of ShellSurfaceBase

Moved GetTargetSurfaceForLocatedEvent out of shell_surface_base and
into shell_surface_util. This is needed so cast can use this function
for touch events in exo.

Bug: 896710
Test: Run exo_unittests
Change-Id: Ifa8f6219ffa54a349922eb78f51a56dda953191c
Reviewed-on: https://chromium-review.googlesource.com/c/1334557
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613710}
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/pointer.cc
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/shell_surface_base.cc
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/shell_surface_base.h
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/shell_surface_util.cc
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/shell_surface_util.h
[modify] https://crrev.com/3b4ff65627e9699ea0085d5fb9267429f9474bd4/components/exo/touch.cc

Comment 40 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f12f6eb83fc6715086d4d70193d070db909c8932

commit f12f6eb83fc6715086d4d70193d070db909c8932
Author: Shawn Gallea <sagallea@google.com>
Date: Tue Dec 04 23:08:08 2018

EXO: Enable wayland server in cast

Conditionally instantiate the Wayland server based on a BUILDFLAG in
Chromecast.

This change also splits out the WaylandWatcher from Ash code so that it
is shared between different builds.

Bug: 896710
Test: Compile cast_shell
Change-Id: I2d2e129add5f0bcf6f2368909c5c83b2ad00a9cc
Reviewed-on: https://chromium-review.googlesource.com/c/1329858
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613746}
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/ash/wayland/wayland_server_controller.cc
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/ash/wayland/wayland_server_controller.h
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/BUILD.gn
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/cast_browser_main_parts.h
[add] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/exo/wayland_server_controller.cc
[add] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/exo/wayland_server_controller.h
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/exo/wm_helper_cast_shell.cc
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/chromecast/browser/exo/wm_helper_cast_shell.h
[modify] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/components/exo/wayland/BUILD.gn
[add] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/components/exo/wayland/wayland_watcher.cc
[add] https://crrev.com/f12f6eb83fc6715086d4d70193d070db909c8932/components/exo/wayland/wayland_watcher.h

Comment 41 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec62bcf45d9a5099349554e383c17041e178e632

commit ec62bcf45d9a5099349554e383c17041e178e632
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Wed Dec 05 21:22:42 2018

exo: Fix private test deps for cast build

These dependencies were pulled via Ash test deps. Need to explicitly
depend on to build for Chromecast.

Bug: 896710
Test: "gn gen out/cast --check" to ensure there are no errors
Change-Id: Iaa51ddbc7f729a730a16e6837c22e2b57de0739b
Reviewed-on: https://chromium-review.googlesource.com/c/1341003
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614103}
[modify] https://crrev.com/ec62bcf45d9a5099349554e383c17041e178e632/components/exo/BUILD.gn
[modify] https://crrev.com/ec62bcf45d9a5099349554e383c17041e178e632/components/exo/wayland/BUILD.gn

Comment 42 by bugdroid1@chromium.org, Dec 5

Project Member

Comment 43 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a94195344227f5c195e4930b7004fca4b33681a

commit 2a94195344227f5c195e4930b7004fca4b33681a
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Wed Dec 05 22:10:28 2018

cast: Add //ui/display/manager dep for EXO

Cast implementation of WMHelper depends on display manager. When
building with EXO enabled GN check fails without this dependency.

Test: gn gen out/cast --check
Bug: 896710
Change-Id: Idc647aedfb5697944019f97c08dd1938f33487dc
Reviewed-on: https://chromium-review.googlesource.com/c/1363951
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614123}
[modify] https://crrev.com/2a94195344227f5c195e4930b7004fca4b33681a/chromecast/browser/BUILD.gn

Comment 44 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28545265a6276301939742891d22b3d794647434

commit 28545265a6276301939742891d22b3d794647434
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Wed Dec 05 22:31:50 2018

EXO: Move CaptureClient getter in WMHelper

ChromeOS and Chromecast use different capture clients. This allows
platforms to inject their own capture clients via the WMHelper
abstraction.

Bug: 896710
Test: Run exo_unittests
Change-Id: Ic7dd5737529db53e35ef6f5192fc86af04bb28c7
Reviewed-on: https://chromium-review.googlesource.com/c/1362246
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614138}
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/chromecast/browser/exo/wm_helper_cast_shell.cc
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/chromecast/browser/exo/wm_helper_cast_shell.h
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/chromecast/graphics/cast_window_manager_aura.h
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/shell_surface_base.cc
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/shell_surface_util.cc
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/test/exo_test_base_aura.cc
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/wm_helper.h
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/wm_helper_chromeos.cc
[modify] https://crrev.com/28545265a6276301939742891d22b3d794647434/components/exo/wm_helper_chromeos.h

Comment 45 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef632fd5250e123e39931f34f711716ecfce0864

commit ef632fd5250e123e39931f34f711716ecfce0864
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Wed Dec 05 22:38:03 2018

EXO: Change Surface before committing in fullscreen shell test

This fixes a DCHECK caused by an empty output surface rect since there
is no change in the Surface when comitting.

Bug: 896710
Test: Run exo_unittests on Chromecast with debug build
Change-Id: I661a1ca206a3f0e9a607d4afdcd4680e4fa76c7c
Reviewed-on: https://chromium-review.googlesource.com/c/1345241
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614142}
[modify] https://crrev.com/ef632fd5250e123e39931f34f711716ecfce0864/components/exo/fullscreen_shell_surface_unittest.cc

Comment 46 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3327612042a3a8a5cdf3c43fde1969149671746f

commit 3327612042a3a8a5cdf3c43fde1969149671746f
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Mon Dec 10 20:00:59 2018

EXO: Use base::TestSuite on non-CrOS builds

Allows running tests without ChromeOS dependencies (Ash).
Changes:
 * Add ExoTestSuiteAura to initialize state that would otherwise be
 initialized by the AshTestSuite.
 * Initialize the test InputMethodFactory otherwise tests using input
 will DCHECK() when using ExoTestBaseAura.

Bug: 896710
Test: Run exo_unittests from a Chromecast build
Change-Id: I709bae42574442cd3d46e834b19f97f8a20a5505
Reviewed-on: https://chromium-review.googlesource.com/c/1345242
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615209}
[modify] https://crrev.com/3327612042a3a8a5cdf3c43fde1969149671746f/components/exo/BUILD.gn
[modify] https://crrev.com/3327612042a3a8a5cdf3c43fde1969149671746f/components/exo/test/exo_test_base_aura.cc
[add] https://crrev.com/3327612042a3a8a5cdf3c43fde1969149671746f/components/exo/test/exo_test_suite_aura.cc
[add] https://crrev.com/3327612042a3a8a5cdf3c43fde1969149671746f/components/exo/test/exo_test_suite_aura.h
[modify] https://crrev.com/3327612042a3a8a5cdf3c43fde1969149671746f/components/exo/test/run_all_unittests.cc

Comment 47 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6bfb4722098d367279f20b6bde372c1c32d470d

commit d6bfb4722098d367279f20b6bde372c1c32d470d
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Mon Dec 10 23:02:33 2018

Add exo_unittests to "Cast Linux" bots

Bug: 896710
Test: Ran exo_unittests locally to verify they work.
Change-Id: I7d015adeaf762bc7c4b1b1a5f9955f93d2dea26c
Reviewed-on: https://chromium-review.googlesource.com/c/1340902
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615298}
[modify] https://crrev.com/d6bfb4722098d367279f20b6bde372c1c32d470d/chromecast/BUILD.gn
[modify] https://crrev.com/d6bfb4722098d367279f20b6bde372c1c32d470d/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d6bfb4722098d367279f20b6bde372c1c32d470d/testing/buildbot/test_suites.pyl

Comment 48 by spang@google.com, Jan 9

exo_unittests is causing build breakage as the target sysroot needs libffi to compile.

Comment 49 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to default.

Comment 50 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8572138f48f5f39449d8df713db73f3c27b45af

commit a8572138f48f5f39449d8df713db73f3c27b45af
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Wed Jan 16 15:12:34 2019

EXO: Initialize NativePixmapFactory in exo::Display()

Initializes the NativePixmapFactory in the constructor without any
arguments. This constructor is used by Chromecast and allows buffers to
be imported via dmabuf.

Bug: 896710
Test: Run on device with sample client using accelerated buffers.
Change-Id: I669b3a8613418b2041ce9d02ae0707fe0b117b40
Reviewed-on: https://chromium-review.googlesource.com/c/1412512
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623237}
[modify] https://crrev.com/a8572138f48f5f39449d8df713db73f3c27b45af/components/exo/display.cc

Comment 51 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c67926a079b00dba2ca1f38711c94bac401d97dc

commit c67926a079b00dba2ca1f38711c94bac401d97dc
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Thu Jan 17 17:05:35 2019

EXO: Refactor wl_shm interface

Move the wl_shm interface into its own files. This change only moves
code around, no functional changes.

Bug: 896710
Test: Build and ran exo_unittests
Change-Id: If553a9db14ea9bc965f28667a685f60d5446735a
Reviewed-on: https://chromium-review.googlesource.com/c/1412692
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623724}
[modify] https://crrev.com/c67926a079b00dba2ca1f38711c94bac401d97dc/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/c67926a079b00dba2ca1f38711c94bac401d97dc/components/exo/wayland/server.cc
[add] https://crrev.com/c67926a079b00dba2ca1f38711c94bac401d97dc/components/exo/wayland/wl_shm.cc
[add] https://crrev.com/c67926a079b00dba2ca1f38711c94bac401d97dc/components/exo/wayland/wl_shm.h

Comment 52 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ec2e2df357a91fb6376a38b07ac10a1e59d4495

commit 3ec2e2df357a91fb6376a38b07ac10a1e59d4495
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Mon Jan 21 21:00:19 2019

EXO: Refactor wl_compositor interface

Move the wl_compositor interface into its own files. This change only
moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: I7973a1c72b7b33c9f0b3c22dabf48cd0afe75177
Reviewed-on: https://chromium-review.googlesource.com/c/1425482
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624660}
[modify] https://crrev.com/3ec2e2df357a91fb6376a38b07ac10a1e59d4495/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/3ec2e2df357a91fb6376a38b07ac10a1e59d4495/components/exo/wayland/server.cc
[add] https://crrev.com/3ec2e2df357a91fb6376a38b07ac10a1e59d4495/components/exo/wayland/wl_compositor.cc
[add] https://crrev.com/3ec2e2df357a91fb6376a38b07ac10a1e59d4495/components/exo/wayland/wl_compositor.h

Comment 53 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/473c49b8a79bf984c000c656b4c21cfadde34b70

commit 473c49b8a79bf984c000c656b4c21cfadde34b70
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Tue Jan 22 14:53:07 2019

EXO: Refactor zwp_linux_dmabuf interface

Move the zwp_linux_dmabuf interface into its own files. This change only
moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: Ib0529be9f793565a20fcc05cde3a7d8f864eb690
Reviewed-on: https://chromium-review.googlesource.com/c/1425563
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624777}
[modify] https://crrev.com/473c49b8a79bf984c000c656b4c21cfadde34b70/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/473c49b8a79bf984c000c656b4c21cfadde34b70/components/exo/wayland/server.cc
[add] https://crrev.com/473c49b8a79bf984c000c656b4c21cfadde34b70/components/exo/wayland/zwp_linux_dmabuf.cc
[add] https://crrev.com/473c49b8a79bf984c000c656b4c21cfadde34b70/components/exo/wayland/zwp_linux_dmabuf.h

Comment 54 by bugdroid, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dcabc483da121f2accf9c3a1f5bb8e70a5f46f9

commit 3dcabc483da121f2accf9c3a1f5bb8e70a5f46f9
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Tue Jan 22 22:25:32 2019

EXO: Refactor wl_subcompositor interface

Move the wl_subcompositor interface into its own files. This change only
moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: I7675d455bb46d356025d1fd6479ac61bf4b92bae
Reviewed-on: https://chromium-review.googlesource.com/c/1427568
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624965}
[modify] https://crrev.com/3dcabc483da121f2accf9c3a1f5bb8e70a5f46f9/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/3dcabc483da121f2accf9c3a1f5bb8e70a5f46f9/components/exo/wayland/server.cc
[add] https://crrev.com/3dcabc483da121f2accf9c3a1f5bb8e70a5f46f9/components/exo/wayland/wl_subcompositor.cc
[add] https://crrev.com/3dcabc483da121f2accf9c3a1f5bb8e70a5f46f9/components/exo/wayland/wl_subcompositor.h

Comment 55 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ffb8c63f97dec6d64659a734c8d645d7d783454

commit 0ffb8c63f97dec6d64659a734c8d645d7d783454
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Wed Jan 23 14:30:34 2019

EXO: Refactor zcr_vsync_feedback interface

Move the zcr_vsync_feedback interface into its own files. This change
only moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: I74885b5a6692306b05a1d86350f627ed7046045b
Reviewed-on: https://chromium-review.googlesource.com/c/1427571
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625190}

Comment 56 by bugdroid, Jan 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2b2351fe0c2aa1b4f0e7e271719b3123dc583d1

commit a2b2351fe0c2aa1b4f0e7e271719b3123dc583d1
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Mon Jan 28 16:42:08 2019

EXO: Refactor wl_data_device_manager interface

Move the wl_data_device_manager interface into its own files. This
change only moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: I3dcd3849e9e7766a97c0792dc17a2fbe84b0f312
Reviewed-on: https://chromium-review.googlesource.com/c/1435625
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626564}

Comment 57 by bugdroid, Yesterday (24 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6005aa49a781d3aa06774b864567f765f79035b

commit b6005aa49a781d3aa06774b864567f765f79035b
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Fri Feb 22 20:00:30 2019

EXO: Refactor wp_viewporter interface

Move the wp_viewporter interface into its own files. This
change only moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: Ie9e2ea1a52ab26f77da3eca392f96d9099198fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1481061
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634792}
[modify] https://crrev.com/b6005aa49a781d3aa06774b864567f765f79035b/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/b6005aa49a781d3aa06774b864567f765f79035b/components/exo/wayland/server.cc
[add] https://crrev.com/b6005aa49a781d3aa06774b864567f765f79035b/components/exo/wayland/wp_viewporter.cc
[add] https://crrev.com/b6005aa49a781d3aa06774b864567f765f79035b/components/exo/wayland/wp_viewporter.h

Comment 58 by bugdroid, Today (23 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e9fa490ac22441c54ea71f0d3f169eddb0fe4f8

commit 1e9fa490ac22441c54ea71f0d3f169eddb0fe4f8
Author: Daniel Nicoara <dnicoara@chromium.org>
Date: Fri Feb 22 20:54:18 2019

EXO: Refactor wp_presentation interface

Move the wp_presentation interface into its own files. This
change only moves code around, no functional changes.

Bug: 896710
Test: Build and run exo_unittests
Change-Id: I221c199074376420f3ca842dcd063c4bd4057589
Reviewed-on: https://chromium-review.googlesource.com/c/1480995
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634815}
[modify] https://crrev.com/1e9fa490ac22441c54ea71f0d3f169eddb0fe4f8/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/1e9fa490ac22441c54ea71f0d3f169eddb0fe4f8/components/exo/wayland/server.cc
[add] https://crrev.com/1e9fa490ac22441c54ea71f0d3f169eddb0fe4f8/components/exo/wayland/wp_presentation.cc
[add] https://crrev.com/1e9fa490ac22441c54ea71f0d3f169eddb0fe4f8/components/exo/wayland/wp_presentation.h

Sign in to add a comment