New issue
Advanced search Search tips

Issue 896709 link

Starred by 1 user
Status: Verified
Owner:
jlebel@chromium.org
Closed: Oct 19
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 827072



Sign in to add a comment

[iOS][Unity] The identity chooser dialog should open automatically only when the identity is not set

Project Member Reported by jlebel@chromium.org, Oct 18 
== Issue with importing data dialog
Sign-in with one identity
Sign-out
Open the sign-in dialog with tapping on "Not johndoe@example.com"
Select a second identity
Tap on "Yes, I'm in"
Choose "Combine my data" or "Keep my data separate"

result:
When this last dialog disappear, the unified consent dialog appears again, and the identity chooser is automatically opened, while signing in.

== Issue with adding an account
Open the sign-in dialog with tapping on "Not johndoe@example.com"
Add a new identity

result:
When the SSO dialog disappears, the identity chooser dialog is opened again. It should not be the case since the user selected its identity.

Comment 1 by jlebel@chromium.org, Oct 18 

The identity chooser dialog needs to be opened automatically only when the user didn't set the identity.

When the identity chooser dialog should not open:
+ After adding a new account, the unified consent dialog appears again.
+ When the import data dialog (keep data separate) closes, and the unified consent appears again (while finishing sign-in).

When the identity chooser dialog should open:
+ When the sign-in opens after clicking on "Not johndoe@example.com" and when the SSO dialog (to open a new account) is canceled.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c8d19003100147d59ff4c348aeb4d9c7ec2bc3b

commit 3c8d19003100147d59ff4c348aeb4d9c7ec2bc3b
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Fri Oct 19 10:00:01 2018

[iOS][Unity] Fixing issue to open automatically the identity chooser dialog

Adding -UnifiedConsentCoordinator.identitySelectedByUser to track when
the user selects an identity. This is to make sure the identity chooser
dialog is opened automatically only when the user didn't select an
identity yet.

Bug:  896709 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib849ac7d385910398f62bf7e7e933f79983e3691
Reviewed-on: https://chromium-review.googlesource.com/c/1288790
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601097}
[modify] https://crrev.com/3c8d19003100147d59ff4c348aeb4d9c7ec2bc3b/ios/chrome/browser/ui/authentication/unified_consent/identity_chooser/identity_chooser_coordinator.mm
[modify] https://crrev.com/3c8d19003100147d59ff4c348aeb4d9c7ec2bc3b/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm

Comment 3 by jlebel@chromium.org, Oct 19

Status: Fixed (was: Started)

Comment 4 by jlebel@chromium.org, Oct 19

Blocking: 827072

Comment 5 by rakurati@chromium.org, Oct 30

Status: Verified (was: Fixed)
Verified in 72.0.3595.0 Canary

Devices: iPhone8(iOS 11.4.1), iPhone X(iOS 12.0.1), iPhone 7plus(iOS 10.3.3), iPad Air(iOS 11.4.1)

1. Identity chooser dialog does not appear after adding a new account and after dismissing import data dialog
2. Identity chooser dialog appears on tapping "Change Account"

Looks good, issue fixed

Link to video:
https://drive.google.com/file/d/1eC0yG3obw32hBz3PfHMHE2st0eOzkalW/view?usp=sharing
►

Sign in to add a comment