New issue
Advanced search Search tips

Issue 896702 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable system echo cancellation in ChromeOS for supported boards

Project Member Reported by guidou@chromium.org, Oct 18

Issue description

To allow devices to use system echo cancellation by default, set the ECHO_CANCELLER bit in AudioManagerCras for supported devices.

See also  bug 880708 .
 
Labels: -Type-Feature Type-Bug
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e19a4276faaca3173a43d29806842596c98c9546

commit e19a4276faaca3173a43d29806842596c98c9546
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Oct 23 14:10:49 2018

Enable echo canceller bit for devices that support it in AudioManagerCras.

This CL reverts crrev.com/595745 so that only devices that are
intended to support system echo cancellation by default report that.

To enable experimentation, this CL enables the experimental echo
cancellation bit on all CrOS devices, and enables the default system
echo cancellation bit only on devices that (correctly) report support.

Bug:  896702 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4211b93c096226651f3993dd462f10f05c9ab8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1288451
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601935}
[modify] https://crrev.com/e19a4276faaca3173a43d29806842596c98c9546/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/e19a4276faaca3173a43d29806842596c98c9546/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/e19a4276faaca3173a43d29806842596c98c9546/media/audio/audio_features.cc
[modify] https://crrev.com/e19a4276faaca3173a43d29806842596c98c9546/media/audio/audio_features.h
[modify] https://crrev.com/e19a4276faaca3173a43d29806842596c98c9546/media/audio/cras/audio_manager_cras.cc

Cc: hlundin@chromium.org
Labels: Merge-Request-70 Merge-Request-71
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 23

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Is this critical for M70 Chrome OS?
Yes, it is.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 24

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 24

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46a12aea04ef05ddc092816e6294affec9b6d715

commit 46a12aea04ef05ddc092816e6294affec9b6d715
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Oct 24 14:25:29 2018

Enable echo canceller bit for devices that support it in AudioManagerCras.

This CL reverts crrev.com/595745 so that only devices that are
intended to support system echo cancellation by default report that.

To enable experimentation, this CL enables the experimental echo
cancellation bit on all CrOS devices, and enables the default system
echo cancellation bit only on devices that (correctly) report support.

Bug:  896702 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4211b93c096226651f3993dd462f10f05c9ab8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1288451
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601935}(cherry picked from commit e19a4276faaca3173a43d29806842596c98c9546)
Reviewed-on: https://chromium-review.googlesource.com/c/1298012
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#290}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/46a12aea04ef05ddc092816e6294affec9b6d715/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/46a12aea04ef05ddc092816e6294affec9b6d715/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/46a12aea04ef05ddc092816e6294affec9b6d715/media/audio/audio_features.cc
[modify] https://crrev.com/46a12aea04ef05ddc092816e6294affec9b6d715/media/audio/audio_features.h
[modify] https://crrev.com/46a12aea04ef05ddc092816e6294affec9b6d715/media/audio/cras/audio_manager_cras.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/46a12aea04ef05ddc092816e6294affec9b6d715

Commit: 46a12aea04ef05ddc092816e6294affec9b6d715
Author: guidou@chromium.org
Commiter: guidou@chromium.org
Date: 2018-10-24 14:25:29 +0000 UTC

Enable echo canceller bit for devices that support it in AudioManagerCras.

This CL reverts crrev.com/595745 so that only devices that are
intended to support system echo cancellation by default report that.

To enable experimentation, this CL enables the experimental echo
cancellation bit on all CrOS devices, and enables the default system
echo cancellation bit only on devices that (correctly) report support.

Bug:  896702 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4211b93c096226651f3993dd462f10f05c9ab8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1288451
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601935}(cherry picked from commit e19a4276faaca3173a43d29806842596c98c9546)
Reviewed-on: https://chromium-review.googlesource.com/c/1298012
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#290}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Assigned)
Labels: -Merge-Review-70
Removing M70 reuqest label. This was resolved in offline email with hllundin@, hychao@, and guidou@.

Sign in to add a comment