New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896699 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Variations.UserChannel histogram is no longer logged after refactoring for Webview variations

Project Member Reported by asvitk...@chromium.org, Oct 18

Issue description

Variations.UserChannel histogram is no longer logged after refactoring for WebView variations.

We used to log this histogram but it got lost by this refactoring CL:
https://chromium-review.googlesource.com/c/chromium/src/+/576288

This histogram is useful for debugging issues with Finch, such as the recent bug here:
 crbug.com/896416 

Kyle - as author of that CL - or Paul as current owner of Webview variations code - can one of you take this bug and restore the histogram? Thanks!
 
Cc: -kmilka@chromium.org
Owner: kmilka@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99130adeed9bfaf664f664b74125e8bc0716d79

commit c99130adeed9bfaf664f664b74125e8bc0716d79
Author: Kyle Milka <kmilka@chromium.org>
Date: Thu Oct 18 17:00:32 2018

Restore Variations.UserChannel histogram

The histogram was lost during refactoring to support WebView variations.

Bug:  896699 
Change-Id: I011f137205213c773b4f9d84fe18e083cd864812
Reviewed-on: https://chromium-review.googlesource.com/c/1288969
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600801}
[modify] https://crrev.com/c99130adeed9bfaf664f664b74125e8bc0716d79/components/variations/service/variations_field_trial_creator.cc

Status: Fixed (was: Started)

Sign in to add a comment