New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896694 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

No specific OWNERS for //components/sync_wifi

Project Member Reported by sdefresne@chromium.org, Oct 18

Issue description

src/components/sync_wifi/OWNERS contains only commented out lines. So there is no OWNERS for this component. We should find someone to own it.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c484a489830efb5e04fca851f4ce4a3f1f0ead3e

commit c484a489830efb5e04fca851f4ce4a3f1f0ead3e
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Oct 25 16:37:36 2018

Set OWNERS of components/sync_wifi

According to git history, this directory never had any proper OWNERS
since its introduction:

  $ git log --follow --oneline -- components/sync_wifi/OWNERS
  53381b6f53fe [Sync] Rename wifi_sync to sync_wifi.
  271c6cca48a6 Add a new component for WiFi credential sync. ...

This component is only ever used from chrome/browser/sync, and is
controlled by a flag defined in components/browser_sync. Both are
owned by the same group of people (file://components/sync/OWNERS).

Bug:  896694 
Change-Id: Ib09c7dd3ffa049ef71b1b05e3c8637153e299851
Reviewed-on: https://chromium-review.googlesource.com/c/1298393
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602746}
[modify] https://crrev.com/c484a489830efb5e04fca851f4ce4a3f1f0ead3e/components/sync_wifi/OWNERS

Cc: treib@chromium.org
Components: Services>Sync
Owner: sdefresne@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment