New issue
Advanced search Search tips

Issue 896693 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 874077



Sign in to add a comment

[AF Android] Footers don't display under refresh on legacy Android

Project Member Reported by tmartino@chromium.org, Oct 18

Issue description

Because older versions (J-M) use a different implementation of DropdownPopupWindowInterface, the footers don't currently display properly. We need to update that impl to do something that at least resembles how the footers should look.

For more context on the legacy Android issues, see crbug.com/896339
 
Blocking: 874077
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/955f0598a0a58a8b262262c8ecb8fc4a249f1f8b

commit 955f0598a0a58a8b262262c8ecb8fc4a249f1f8b
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Oct 18 14:38:40 2018

[AF Android] Adding footers on legacy Android

This CL implements footers in the Autofill dropdown on legacy
(Jellybean - Marshmallow) Android. It does so by implementing an
interface method which is currently empty. This also required
AutofillPopup to be changed slightly, as the new implementation cannot
be invoked after show()ing the popup.

Change-Id: I9387be794382a32a3abd92a267c7de9e7b04d8b1
Bug:  896693 
Reviewed-on: https://chromium-review.googlesource.com/c/1281723
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600757}
[modify] https://crrev.com/955f0598a0a58a8b262262c8ecb8fc4a249f1f8b/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java
[modify] https://crrev.com/955f0598a0a58a8b262262c8ecb8fc4a249f1f8b/ui/android/java/src/org/chromium/ui/DropdownPopupWindowInterface.java
[modify] https://crrev.com/955f0598a0a58a8b262262c8ecb8fc4a249f1f8b/ui/android/java/src/org/chromium/ui/DropdownPopupWindowJellyBean.java

Labels: -Pri-2 Pri-1
Status: Fixed (was: Untriaged)
This is fixed.

Verifying will require a device running an older Android version (J, K, L, or M).

Test steps (Canary):
1. Go to chrome://flags and set enable-autofill-refresh-style to Enabled. Fully close the browser (using the recent apps/ menu) and reopen it.
2. Navigate to https://rsolomakhin.github.io/autofill/ and focus on the "Name" field near the top of the page.
3. Verify that an Autofill dropdown appears. If no dropdown appears, click on "Fill Form (Simpsons)" button, click the nearest Submit button, and retry step 2.
4. Verify that a footer reading "Manage addresses..." appears at the bottom of the dropdown.
5. Tap on "Manage addresses..." and verify that the relevant settings page is opened.
Labels: Merge-Request-71
Status: Verified (was: Fixed)
Verified on device using Marshmallow.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 30

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
For context, this CL is a prerequisite for a conflict-free merge of  https://bugs.chromium.org/p/chromium/issues/detail?id=898927, which is already approved. It fixes an issue with missing UI elements.

The CL in question is quite small (a good chunk is comments), and I'm comfortable saying it's a low-risk merge based on my testing, and my knowledge of the invocations of the code and of any other changes which might conflict with it.
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Approved for merge to 71, branch 3578.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 1

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26b12e657d096ce425d582c53573ed1a419f3c17

commit 26b12e657d096ce425d582c53573ed1a419f3c17
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Nov 01 16:21:08 2018

[AF Android] Adding footers on legacy Android

This CL implements footers in the Autofill dropdown on legacy
(Jellybean - Marshmallow) Android. It does so by implementing an
interface method which is currently empty. This also required
AutofillPopup to be changed slightly, as the new implementation cannot
be invoked after show()ing the popup.

Change-Id: I9387be794382a32a3abd92a267c7de9e7b04d8b1
Bug:  896693 
Reviewed-on: https://chromium-review.googlesource.com/c/1281723
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600757}(cherry picked from commit 955f0598a0a58a8b262262c8ecb8fc4a249f1f8b)
Reviewed-on: https://chromium-review.googlesource.com/c/1312970
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#444}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/26b12e657d096ce425d582c53573ed1a419f3c17/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java
[modify] https://crrev.com/26b12e657d096ce425d582c53573ed1a419f3c17/ui/android/java/src/org/chromium/ui/DropdownPopupWindowInterface.java
[modify] https://crrev.com/26b12e657d096ce425d582c53573ed1a419f3c17/ui/android/java/src/org/chromium/ui/DropdownPopupWindowJellyBean.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/26b12e657d096ce425d582c53573ed1a419f3c17

Commit: 26b12e657d096ce425d582c53573ed1a419f3c17
Author: tmartino@chromium.org
Commiter: tmartino@chromium.org
Date: 2018-11-01 16:21:08 +0000 UTC

[AF Android] Adding footers on legacy Android

This CL implements footers in the Autofill dropdown on legacy
(Jellybean - Marshmallow) Android. It does so by implementing an
interface method which is currently empty. This also required
AutofillPopup to be changed slightly, as the new implementation cannot
be invoked after show()ing the popup.

Change-Id: I9387be794382a32a3abd92a267c7de9e7b04d8b1
Bug:  896693 
Reviewed-on: https://chromium-review.googlesource.com/c/1281723
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600757}(cherry picked from commit 955f0598a0a58a8b262262c8ecb8fc4a249f1f8b)
Reviewed-on: https://chromium-review.googlesource.com/c/1312970
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#444}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment