New issue
Advanced search Search tips

Issue 896689 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

[autofill] Remove the "name" property of forms and fields, switch to unique_id

Project Member Reported by rogerm@chromium.org, Oct 18

Issue description

The name property represents the identifier by which autofill refers to the or field. This is generally either the value of the name attribute or the id attribute, whichever is non-empty with priority given to the name attribute.

This name property is used when computing form/field signatures, but is often not ideal to use as an identifier because it is not quaranteed to be unique.

Tasks:

  - remove the name property from autofill::FormData and FormFieldData

  - remove the renderer/JS code which computes the name property

  - in the browser, calculate the "name for signature" value as needed
    from the name_attribute and id_attribute values

  - switch to using a unique identifier (unique_renderer_id or iOS
    unique id) to otherwise refer to forms/fields for the scope of a
    given navigation.
 
Owner: mahmadi@chromium.org
Owner: rogerm@chromium.org
Status: Started (was: Available)
Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.

Sign in to add a comment