Low end device detection doesn't work well on desktop |
||
Issue descriptionbase::SysInfo::IsLowEndDevice is (almost) guaranteed to always return false on desktop platforms because its implementation is effectively: if (ram_size_mb <= kLowMemoryDeviceThresholdMB) return true; else return false; and kLowMemoryDeviceThresholdMB is set to 512MB regardless of the platform (https://cs.chromium.org/chromium/src/base/sys_info.cc?l=25&rcl=fdda9f64969342df4a958995b7f360e18e74c23c) The problem is that this function is used to determine how much memory should be freed when we detect that the system is running low on memory (e.g. entering the moderate memory pressure state). E.g. the discardable shared memory manager will try to limit the amount of memory it uses to 256MB if we enter the moderate memory pressure state, which is a lot on low-end machines (e.g. a Win10 laptop with 2GB of RAM). This value should probably be increased, but this might be risky as some of the buffer sizes used on low end devices might not all be appropriate for a desktop environment (i.e. they have never really been tested on desktop).
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37b6dbdc3db7ba41bb402ebb220b23c456b1fb22 commit 37b6dbdc3db7ba41bb402ebb220b23c456b1fb22 Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Fri Oct 19 03:09:16 2018 Put the RAM limit to classify a device as LowEnd behind a feature flag Having this feature will make it easier to measure the various impact of changing this value. Bug: 896687 Change-Id: I4f976a41dc402c1b1b49625c4105cee3814a12fe Reviewed-on: https://chromium-review.googlesource.com/c/1288892 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#601038} [modify] https://crrev.com/37b6dbdc3db7ba41bb402ebb220b23c456b1fb22/base/sys_info.cc
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||
►
Sign in to add a comment |
||
Comment 1 by sebmarchand@chromium.org
, Oct 18