New issue
Advanced search Search tips

Issue 896680 link

Starred by 1 user
Status: Assigned
Owner:
brat...@opera.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue gn:7


Sign in to add a comment

.gn check_targets is not maintained, meaning new builds targets lose out on gn check

Project Member Reported by brat...@opera.com, Oct 18 
In the file .gn there is a list of folders that gn check will check, but that list, being a white-list, requires additions whenever a new, non-broken, target/folder is added. That addition rarely happen.

I have a proposition of a new more powerful format that will make it easier to maintain, and easier to make new folders get the checks right away.

Comment 1 by dpranke@chromium.org, Oct 18 

See https://crbug.com/gn/7 ; I'm not sure if we need anything more than what is suggested there, but I'm interested in what you have in mind.

We should probably move this bug over to the GN project, too (click on "move issue" under the more actions select box at the bottom of the page).

Comment 2 by brat...@opera.com, Oct 18 

I wrote a mail about it to gn-dev (but you found this bug some other way!) and it looks like what I proposed and what gn/7 talks about is very similar. 

I see this bug as being specifically about the check_targets list in //.gn in the Chromium repository so it should be fine with just gn/7, especially since what I proposed is a duplicate of that bug.

Comment 3 by dpranke@chromium.org, Oct 18

Blockedon: gn:7
Ah, yeah, I saw the notification of the new bug before your note to gn-dev :).

I'm fine with leaving this to track cleaning up //.gn in src.git specifically.
►

Sign in to add a comment