Refactor ExtensionsGuestViewMessageFilter |
|
Issue descriptionThis class is a subclass of GuestViewMessage filter which is generally required by all guests for IPCs such as Resize. However, it now also includes a lot of logic for MimeHandlerView related IPCs (implementation of guest_view.mojom) and also some state keeping logic for handling frame-based MimeHandlerView. It should be refactored to separate MimeHandlerView logic from the rest of the guests logic once BrowserPlugin is gone.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f461bf8f5e6149abfae57d1abff10ed48b2863ad commit f461bf8f5e6149abfae57d1abff10ed48b2863ad Author: Ehsan Karamad <ekaramad@chromium.org> Date: Wed Dec 05 22:25:09 2018 Remove attaching logic from GuestViewMessageFilter This CL will remove part of the logic to the GuestViewBase itself and exposes a public method rather than marking GuestViewMessageFilter a friend class. A motivation for the change the refactoring need for frame-based MimeHandlerViewGuest to be separated form ExtensionsGuestViewMessageFilter. Bug: 896679, 659750 Change-Id: I16a21117c06dcfd00426dcec6fc4927d3e287342 Reviewed-on: https://chromium-review.googlesource.com/c/1361794 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#614132} [modify] https://crrev.com/f461bf8f5e6149abfae57d1abff10ed48b2863ad/components/guest_view/browser/guest_view_base.cc [modify] https://crrev.com/f461bf8f5e6149abfae57d1abff10ed48b2863ad/components/guest_view/browser/guest_view_base.h [modify] https://crrev.com/f461bf8f5e6149abfae57d1abff10ed48b2863ad/components/guest_view/browser/guest_view_message_filter.cc [modify] https://crrev.com/f461bf8f5e6149abfae57d1abff10ed48b2863ad/components/guest_view/browser/guest_view_message_filter.h [modify] https://crrev.com/f461bf8f5e6149abfae57d1abff10ed48b2863ad/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bb223676defeba9c44a5ce42460c86e24561e73 commit 5bb223676defeba9c44a5ce42460c86e24561e73 Author: Ehsan Karamad <ekaramad@chromium.org> Date: Wed Jan 09 15:53:27 2019 [GuestView] - Introduce MimeHandlerViewAttachHelper This CL is for the most part a mechanical change which extracts almost all the frame-based MimeHandlerView code out of ExtensionsGuestViewMessageFilter. This change both removes the current clutter form EGVMF as well as fixesa race introduced when the frame-based logic was added to EGVMF. The reason for the race was that EGVMF is destroyed on IO thread but all the access to it (for frame-based MHV) are from UI. TBR=avi@chromium.org,lazyboy@chromium.org Bug: 659750, 896679, 911161, 918861 Change-Id: I6474b870e4d56daa68be03637bb633665d9f9dda Reviewed-on: https://chromium-review.googlesource.com/c/1401451 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#621155} [modify] https://crrev.com/5bb223676defeba9c44a5ce42460c86e24561e73/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/5bb223676defeba9c44a5ce42460c86e24561e73/extensions/browser/BUILD.gn [modify] https://crrev.com/5bb223676defeba9c44a5ce42460c86e24561e73/extensions/browser/guest_view/extensions_guest_view_message_filter.cc [modify] https://crrev.com/5bb223676defeba9c44a5ce42460c86e24561e73/extensions/browser/guest_view/extensions_guest_view_message_filter.h [add] https://crrev.com/5bb223676defeba9c44a5ce42460c86e24561e73/extensions/browser/guest_view/mime_handler_view/mime_handler_view_attach_helper.cc [add] https://crrev.com/5bb223676defeba9c44a5ce42460c86e24561e73/extensions/browser/guest_view/mime_handler_view/mime_handler_view_attach_helper.h |
|
►
Sign in to add a comment |
|
Comment 1 by ekaramad@chromium.org
, Oct 18