New issue
Advanced search Search tips

Issue 896647 link

Starred by 0 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

Improve submission tests for autofill

Project Member Reported by vabr@chromium.org, Oct 18

Issue description

The AutofillTest.* suite (chrome/browser/autofill/autofill_browsertest.cc) might have differences in filling behaviour compared to user-driven Chrome, and these might have led to missing a breaking change in the past.

We might need to mimic the behaviour to the real Chrome better in the test.

More details:

Back in April 2018, a Boolean flag "is_default" was accidentally included in the FormFieldData comparison. As explained in [1], when a form was cached with "is_default" true, that cache entry would not match the same form once filled-in (is_default false) upon submission. That, in turn, would cause Chrome to believe that this form actually does only have default values and so the address would not be saved.

The existing tests, such as AutofillTest.AggregatesMinValidProfile, seem to test such situations, yet they did not catch the regression. The hypothesis that currently, the re-parsing is not triggered in the test by the time the form is submitted.


[1] https://chromium-review.googlesource.com/c/chromium/src/+/1030070#message-118a66baa63bd59bdd9f10157d39b09598ffc829
 

Sign in to add a comment