Non-Regression: "PIN must be at least 6 digits" text is seen in English when display language is Arabic |
|||||
Issue descriptionChrome Version:72.0.3582.0/11168.0.0 dev channel Candy, Celes & Peppy OS:Chrome OS What steps will reproduce the problem? (1)In OOBE screen, Set the display language as Arabic (2)Sign into user >> In Choose your PIN overlay, observe the text "PIN must be at least 6 digits" Actual: "PIN must be at least 6 digits" text is seen in English when display language is Arabic Expected: "PIN must be at least 6 digits" text should be seen in Arabic when display language is Arabic This is a Non-Regression issue as 'Choose your PIN' screen is seen from 72.0.3580.0/11159.0.0 dev Attached the screencast for reference..
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a128abfe40dedecf137b4a45dce9759ad624c24 commit 3a128abfe40dedecf137b4a45dce9759ad624c24 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Oct 19 20:17:52 2018 Chrome OS: Support dynamic language change in PIN setup. Bug: 896645 Change-Id: Id12e434ba7b284829d10b3c489e05278beebbb02 Reviewed-on: https://chromium-review.googlesource.com/c/1290200 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#601274} [modify] https://crrev.com/3a128abfe40dedecf137b4a45dce9759ad624c24/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js [modify] https://crrev.com/3a128abfe40dedecf137b4a45dce9759ad624c24/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html [modify] https://crrev.com/3a128abfe40dedecf137b4a45dce9759ad624c24/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
,
Oct 19
,
Oct 20
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a598a4732975af8240f3c16962210c95c6a01dc7 commit a598a4732975af8240f3c16962210c95c6a01dc7 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Oct 22 05:10:23 2018 Chrome OS: Support dynamic language change in PIN setup. TBR=alemate@chromium.org (cherry picked from commit 3a128abfe40dedecf137b4a45dce9759ad624c24) Bug: 896645 Change-Id: Id12e434ba7b284829d10b3c489e05278beebbb02 Reviewed-on: https://chromium-review.googlesource.com/c/1290200 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601274} Reviewed-on: https://chromium-review.googlesource.com/c/1293183 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#200} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/a598a4732975af8240f3c16962210c95c6a01dc7/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js [modify] https://crrev.com/a598a4732975af8240f3c16962210c95c6a01dc7/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.html [modify] https://crrev.com/a598a4732975af8240f3c16962210c95c6a01dc7/ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a598a4732975af8240f3c16962210c95c6a01dc7 Commit: a598a4732975af8240f3c16962210c95c6a01dc7 Author: alemate@chromium.org Commiter: alemate@chromium.org Date: 2018-10-22 05:10:23 +0000 UTC Chrome OS: Support dynamic language change in PIN setup. TBR=alemate@chromium.org (cherry picked from commit 3a128abfe40dedecf137b4a45dce9759ad624c24) Bug: 896645 Change-Id: Id12e434ba7b284829d10b3c489e05278beebbb02 Reviewed-on: https://chromium-review.googlesource.com/c/1290200 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601274} Reviewed-on: https://chromium-review.googlesource.com/c/1293183 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#200} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by alemate@chromium.org
, Oct 19Labels: -Pri-2 -M-72 ReleaseBlock-Beta M-71 Pri-1
Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)