New issue
Advanced search Search tips

Issue 896641 link

Starred by 1 user
Status: Fixed
Owner:
f...@opera.com
Closed: Nov 29
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Shapes for which the rendering has been disabled will still partake in hit-testing

Project Member Reported by f...@opera.com, Oct 18 
When a shape is "disabled" because the geometry it defines is "empty" (by some definition), we don't render the shape, but it's still possible to hit it when hit-testing (it's not in Gecko.)
svg-hittest-on-disabled-shape-with-pe-stroke.html
285 bytes View Download

Comment 1 by f...@opera.com, Oct 18

Summary: Shapes for which the rendering has been disabled will still partake in hit-testing (was: Shapes for which the rendering has been disabled, will still partake in hit-testing)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3625eeacb4eeaece65518d63711dacb69bbd9d1c

commit 3625eeacb4eeaece65518d63711dacb69bbd9d1c
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Nov 28 20:09:33 2018

Disabled (empty) SVG shapes cannot be hit

Disabled SVG shapes [1][2][3] should not be possible to hit since they
are considered "not rendered".

[1] https://svgwg.org/svg2-draft/shapes.html#RectElement
[2] https://svgwg.org/svg2-draft/shapes.html#CircleElement
[3] https://svgwg.org/svg2-draft/shapes.html#EllipseElement

Bug:  896641 
Change-Id: I5fe530722a4d60ecd416cd68f06a7555bb6a520f
Reviewed-on: https://chromium-review.googlesource.com/c/1353983
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#611840}
[modify] https://crrev.com/3625eeacb4eeaece65518d63711dacb69bbd9d1c/third_party/blink/renderer/core/layout/svg/layout_svg_shape.cc
[add] https://crrev.com/3625eeacb4eeaece65518d63711dacb69bbd9d1c/third_party/blink/web_tests/external/wpt/svg/shapes/reftests/disabled-shapes-01.svg
[add] https://crrev.com/3625eeacb4eeaece65518d63711dacb69bbd9d1c/third_party/blink/web_tests/external/wpt/svg/shapes/reftests/support/empty.svg
[add] https://crrev.com/3625eeacb4eeaece65518d63711dacb69bbd9d1c/third_party/blink/web_tests/external/wpt/svg/shapes/scripted/disabled-shapes-not-hit.svg

Comment 3 by f...@opera.com, Nov 29

Owner: f...@opera.com
Status: Fixed (was: Available)
►

Sign in to add a comment