New issue
Advanced search Search tips

Issue 896634 link

Starred by 1 user
Status: Duplicate
Merged: issue 896674
Owner: ----
Closed: Oct 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: No space is seen between the Text and 'Cancel sync' button of toast message on chrome://settings/syncSetup page

Reported by khushal....@etouch.net, Oct 18 
Chrome Version: 72.0.3584.0 (Official Build) Revision 945ab041ec6ac3fb389f94dcbfebb1839a12a69b-refs/branch-heads/3584@{#1} (32/64-bit)

OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux (14.04 LTS)

Steps to reproduce:
1. Launch chrome and click on Avatar icon.
2. Click on 'Turn on Sync' button to proceed to sign in.
3. Enter valid username and password and click on 'Sign in' button (Turn on Sync overlay will appear).
4. Click on 'Settings' link present on overlay (chrome://settings/syncSetup page will open).
5. Now Observe the toast message.

Actual Result: No space is seen between the Text and 'Cancel sync' button of toast message on chrome://settings/syncSetup page.

Expected Result: Proper space should be seen between the text and 'Cancel sync' button.

This is a regression issue, broken in 'M-72' series, below is the manual regression range and will soon provide the bisect info:
Good Build: 72.0.3583.0 (Revision: 600164)
Bad Build:  72.0.3584.0 (Revision: 600616)

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mp4
891 KB View Download
Expected Video.mp4
884 KB View Download

Comment 1 by khushal....@etouch.net, Oct 18

Components: Services>SignIn
Labels: hasbisect
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

Change-Log URL:

https://chromium.googlesource.com/chromium/src/+log/72.0.3583.0..72.0.3584.0?pretty=fuller&n=10000

Suspecting: r600390 ?

treib@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: 
1. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.
2. Unable to perform Chromium bisect as 'Sign in to Chrome' feature is unavailable in chromium builds.
3. Hence, providing suspect manually.

Thank You..!!

Comment 2 by treib@chromium.org, Oct 18

Cc: dpa...@chromium.org
Owner: ----
Status: Available (was: Assigned)
No, that CL only changed tests.

I don't see any changes to this particular UI in the changelog. Maybe https://crrev.com/177774d57a744b75630cba5507c3bf1ed419aea3 had an effect here?

Comment 3 by dpa...@chromium.org, Oct 18

Mergedinto: 896674
Status: Duplicate (was: Available)
►

Sign in to add a comment