Issue metadata
Sign in to add a comment
|
Regression:[NTP]Focus skips a tile and traverses to alternate tile option on pressing up/down arrow key
Reported by
vineetha...@etouch.net,
Oct 18
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3584.0 (Official Build) Revision 945ab041ec6ac3fb389f94dcbfebb1839a12a69b-refs/branch-heads/3584@{#1}(32/64-bit) OS: Windows(7,8,8.1,10), Linux (14.04 LTS), Mac(10.13.1, 10.13.6, 10.14.1) Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags. What steps will reproduce the problem? 1. Launch chrome, open NTP, zoom in to 125% or beyond. 2. Now resize browser window from RHS to the maximum possible limit. 3. Click on the gear icon > click on 'Chrome backgrounds'(observe that tiles appear one in a row). 4. On 'Select a collection' overlay ,try traversing through the tile options using up/down arrow key and observe. Actual Result : Focus skips a tile and traverses to alternate tile option on pressing up/down arrow key. Expected Result: Focus should traverse to next available tile option on pressing up/down arrow key. This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information: Good Build : 71.0.3557.0 (Revision : 592638) Bad Build : 71.0.3558.0 (Revision : 593042) You are probably looking for a change made after 575961 (known good), but no later than 575962 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3f032eff4aefd78a635b88bf61938a9c7b7f485d..a4286e847423c2ab642b80eef7135a7e60aa021a Suspect: https://chromium.googlesource.com/chromium/src/+/a4286e847423c2ab642b80eef7135a7e60aa021a @sweilun : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the attached screen-cast. Note: Issue is reproducible on Dev build #71.0.3578.10 Thank you
,
Oct 19
Mac triage: marking bug with owner Assigned. Triage rotation considers bugs directly from TE or QA automatically confirmed :)
,
Oct 23
,
Nov 9
,
Nov 14
The NextAction date has arrived: 2018-11-14
,
Nov 14
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1435238d0479568e8fe957f618b36ad707c7e030 commit 1435238d0479568e8fe957f618b36ad707c7e030 Author: Kyle Milka <kmilka@chromium.org> Date: Thu Nov 15 16:21:27 2018 [NTP] Correct arrow key navigation through tiles Make arrow key navigation through tiles not depend on the pixel width of the dialog. When using the up and down keys first search for a tile in the indicated direction that's in a different row ('top' is different) then the tile that's in the same column ('left' is the same). Bug: 896630 Change-Id: Ie5c9f7ebffba521dad1b8056626573c5015b3a36 Reviewed-on: https://chromium-review.googlesource.com/c/1335956 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608389} [modify] https://crrev.com/1435238d0479568e8fe957f618b36ad707c7e030/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Nov 15
,
Nov 16
Hi, Retested the above issue on Windows(7,8,8.1,10), Linux (14.04 LTS), Mac(10.13.1, 10.13.6, 10.14.2) using latest Canary #72.0.3612.0 and issue is fixed. Now, Focus does not skip tile when pressing up/down key. Please refer the attached screen-cast for reference. Thank You! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ramyan@chromium.org
, Oct 18Labels: -Pri-1 -Target-71 Pri-2
Owner: kmilka@chromium.org
Status: Unconfirmed (was: Assigned)