New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896605 link

Starred by 5 users

Issue metadata

Status: Duplicate
Merged: issue 897236
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Chrome-ES


Sign in to add a comment

Regression:Cookies get automatically disable after Sign in to chrome.

Reported by shruti.j...@etouch.net, Oct 18

Issue description

Chrome Version: 72.0.3584.0 Revision 945ab041ec6ac3fb389f94dcbfebb1839a12a69b-refs/branch-heads/3584@{#1}(32/64 bit)
OS: MAC(10.13.1,10.13.6,10.14.1)

What steps will reproduce the problem?
(1) Launch chrome and Sign in to chrome with valid credentials.
(2) In Turn On sync Overlay,Bring Tab focus on 'Turn On' button  and hit enter so that Sign in to chrome is successful.
(3) Observe in omni-box.

Actual: Cookies get automatically disable after Sign in to chrome.
Expected: Cookies should not get disable as further activities get blocked due to blocked cookies.

This is a regression issue, broken in 'M72', will soon update other info:

Good Build:72.0.3583.0
Bad Build:72.0.3584.0

Thank You!
 
Actual_result.mov
15.0 MB View Download
Expected_result.mov
10.7 MB View Download
Cc: dpa...@chromium.org
Labels: hasbisect OS-Linux OS-Windows
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)
Update: 
Bisect Info:
Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/72.0.3583.0..72.0.3584.0?pretty=fuller&n=10000

Suspecting: r600390 ?

treib@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.
2. Unable to perform Chromium bisect as 'File is not a zip file' Error is seen.
3. Hence providing suspect manually.
4. Issue is also seen on Windows(7,8,8.1,10 and Linux()14.04 LTS) OS
5. As Issue is only observed with Mouse click, user is able to sign-in with 'Enter' key via keyboard.

Thank You!
Cc: msarda@chromium.org
Owner: tangltom@chromium.org
I think this is probably the same as  bug 896596 ?
Anyway, my CL only changed tests, so it can't be the culprit.
Owner: msarda@chromium.org
Thomas is very busy working on a RBB blocker. I'll pick up this bug.
This may be actually fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1287258 . I just need to test.
Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
As this is a recent regression adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Cc: jam@chromium.org dxie@google.com
Components: Internals>Network>Cookies
Adding more folks that work on network. May be related to network service.

I can see this happening now, however the behavior is really strange and I do not know of any change in the UI or WebUI code for the sync confirmation dialog that could explain the issue. I'll see if I can debug it.


Status: Started (was: Assigned)
Cc: msramek@chromium.org mkwst@chromium.org
Components: UI>Settings
Labels: -ReleaseBlock-Stable ReleaseBlock-Dev
Owner: dpa...@chromium.org
Status: Assigned (was: Started)
This bug is not related to sign-in or to the network service. Assigning to dpapad@ as this is an issue in the settings code. I am marking this bug as RBS for dev channel as I think this may change the default value for blocking cookies, which is a pref that is synced so setting a bad value may affect the user ever after the bug is fixed.

I managed to debug this as it is not related to sign-in. The issue is way more complex IMHO and the bug is in the settings UI. The problem occurs after turning on sync as the cookies blocked pref is a synable pref, so if it is disabled on one profile it will be synced afterwards to all profiles.

Steps to reproduce the issue:
* Start Chrome in a new user data dir.
* Without opening settings, observe that you can sign in to gmail.com
* Open settings and go to chrome://settings/content/cookies

Expected:
* Cookies should be allowed

Actual:
* Cookies are blocked 
=> After opening settings, observe that signing in to gmail.com in a new tab no longer works

After spending a couple of hours debugging this, I found that the settings WebUI code forces the default cookie setting to CONTENT_SETTING_BLOCK. Here is the stack trace when this happens:

>	chrome.dll!HostContentSettingsMap::SetDefaultContentSetting(ContentSettingsType content_type, ContentSetting setting) Line 409	C++	Symbols loaded.
 	chrome.dll!settings::SiteSettingsHandler::HandleSetDefaultValueForContentType(const base::ListValue * args) Line 558	C++	Symbols loaded.
 	chrome.dll!base::internal::FunctorTraits<void (settings::SiteSettingsHandler::*)(const base::ListValue *),void>::Invoke<void (settings::SiteSettingsHandler::*)(const base::ListValue *),settings::SiteSettingsHandler *,const base::ListValue *>(void(settings::SiteSettingsHandler::*)(const base::ListValue *) method, settings::SiteSettingsHandler * && receiver_ptr, const base::ListValue * && args) Line 516	C++	Symbols loaded.
 	chrome.dll!base::internal::InvokeHelper<0,void>::MakeItSo<void (settings::SiteSettingsHandler::*const &)(const base::ListValue *),settings::SiteSettingsHandler *,const base::ListValue *>(void(settings::SiteSettingsHandler::*)(const base::ListValue *) & functor, settings::SiteSettingsHandler * && args, const base::ListValue * && args) Line 616	C++	Symbols loaded.
 	chrome.dll!base::internal::Invoker<base::internal::BindState<void (settings::SiteSettingsHandler::*)(const base::ListValue *),base::internal::UnretainedWrapper<settings::SiteSettingsHandler> >,void (const base::ListValue *)>::RunImpl<void (settings::SiteSettingsHandler::*const &)(const base::ListValue *),const std::tuple<base::internal::UnretainedWrapper<settings::SiteSettingsHandler> > &,0>(void(settings::SiteSettingsHandler::*)(const base::ListValue *) & functor, const std::tuple<base::internal::UnretainedWrapper<settings::SiteSettingsHandler> > & bound, std::integer_sequence<unsigned long long,0>, const base::ListValue * && unbound_args) Line 689	C++	Symbols loaded.
 	chrome.dll!base::internal::Invoker<base::internal::BindState<void (settings::SiteSettingsHandler::*)(const base::ListValue *),base::internal::UnretainedWrapper<settings::SiteSettingsHandler> >,void (const base::ListValue *)>::Run(base::internal::BindStateBase * base, const base::ListValue * unbound_args) Line 671	C++	Symbols loaded.
 	content.dll!base::RepeatingCallback<void (const base::ListValue *)>::Run(const base::ListValue * args) Line 129	C++	Symbols loaded.
 	content.dll!content::WebUIImpl::ProcessWebUIMessage(const GURL & source_url, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & message, const base::ListValue & args) Line 268	C++	Symbols loaded.
 	content.dll!content::WebUIImpl::OnWebUISend(content::RenderFrameHost * sender, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & message, const base::ListValue & args) Line 135	C++	Symbols loaded.
 	content.dll!IPC::DispatchToMethodImpl<content::WebUIImpl,void (content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &),content::RenderFrameHost,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,0,1>(content::WebUIImpl * obj, void(content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &) method, content::RenderFrameHost * parameter, std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue> && tuple, std::integer_sequence<unsigned long long,0,1>) Line 65	C++	Symbols loaded.
 	content.dll!IPC::DispatchToMethod<content::WebUIImpl,content::RenderFrameHost,const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &,const base::ListValue &,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue> >(content::WebUIImpl * obj, void(content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &) method, content::RenderFrameHost * parameter, std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue> && tuple) Line 76	C++	Symbols loaded.
 	content.dll!IPC::MessageT<FrameHostMsg_WebUISend_Meta,std::tuple<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::ListValue>,void>::Dispatch<content::WebUIImpl,content::WebUIImpl,content::RenderFrameHost,void (content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &)>(const IPC::Message * msg, content::WebUIImpl * obj, content::WebUIImpl * sender, content::RenderFrameHost * parameter, void(content::WebUIImpl::*)(content::RenderFrameHost *, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > &, const base::ListValue &) func) Line 147	C++	Symbols loaded.
 	content.dll!content::WebUIImpl::OnMessageReceived(const IPC::Message & message, content::RenderFrameHost * sender) Line 102	C++	Symbols loaded.
 	content.dll!content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl * render_frame_host, const IPC::Message & message) Line 880	C++	Symbols loaded.
 	content.dll!content::RenderFrameHostImpl::OnMessageReceived(const IPC::Message & msg) Line 1206	C++	Symbols loaded.
 	content.dll!content::RenderProcessHostImpl::OnMessageReceived(const IPC::Message & msg) Line 3331	C++	Symbols loaded.
 	ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage(const IPC::Message & message) Line 321	C++	Symbols loaded.
 	ipc.dll!base::internal::FunctorTraits<void (IPC::ChannelProxy::Context::*)(const IPC::Message &),void>::Invoke<void (IPC::ChannelProxy::Context::*)(const IPC::Message &),const scoped_refptr<IPC::ChannelProxy::Context> &,const IPC::Message &>(void(IPC::ChannelProxy::Context::*)(const IPC::Message &) method, const scoped_refptr<IPC::ChannelProxy::Context> & receiver_ptr, const IPC::Message & args) Line 516	C++	Symbols loaded.
 	ipc.dll!base::internal::InvokeHelper<0,void>::MakeItSo<void (IPC::ChannelProxy::Context::*const &)(const IPC::Message &),const scoped_refptr<IPC::ChannelProxy::Context> &,const IPC::Message &>(void(IPC::ChannelProxy::Context::*)(const IPC::Message &) & functor, const scoped_refptr<IPC::ChannelProxy::Context> & args, const IPC::Message & args) Line 616	C++	Symbols loaded.
 	ipc.dll!base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(const IPC::Message &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void ()>::RunImpl<void (IPC::ChannelProxy::Context::*const &)(const IPC::Message &),const std::tuple<scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message> &,0,1>(void(IPC::ChannelProxy::Context::*)(const IPC::Message &) & functor, const std::tuple<scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message> & bound, std::integer_sequence<unsigned long long,0,1>) Line 689	C++	Symbols loaded.
 	ipc.dll!base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(const IPC::Message &),scoped_refptr<IPC::ChannelProxy::Context>,IPC::Message>,void ()>::Run(base::internal::BindStateBase * base) Line 671	C++	Symbols loaded.
 	base.dll!base::OnceCallback<void ()>::Run() Line 100	C++	Symbols loaded.
 	base.dll!base::debug::TaskAnnotator::RunTask(const char * queue_function, base::PendingTask * pending_task) Line 101	C++	Symbols loaded.
 	base.dll!base::MessageLoop::RunTask(base::PendingTask * pending_task) Line 434	C++	Symbols loaded.
 	base.dll!base::MessageLoop::DeferOrRunPendingTask(base::PendingTask pending_task) Line 448	C++	Symbols loaded.
 	base.dll!base::MessageLoop::DoWork() Line 517	C++	Symbols loaded.
 	base.dll!base::MessagePumpForUI::DoRunLoop() Line 179	C++	Symbols loaded.
 	base.dll!base::MessagePumpWin::Run(base::MessagePump::Delegate * delegate) Line 54	C++	Symbols loaded.
 	base.dll!base::MessageLoop::Run(bool application_tasks_allowed) Line 388	C++	Symbols loaded.
 	base.dll!base::RunLoop::Run() Line 102	C++	Symbols loaded.
 	chrome.dll!ChromeBrowserMainParts::MainMessageLoopRun(int * result_code) Line 2030	C++	Symbols loaded.
 	content.dll!content::BrowserMainLoop::RunMainMessageLoopParts() Line 993	C++	Symbols loaded.
 	content.dll!content::BrowserMainRunnerImpl::Run() Line 165	C++	Symbols loaded.
 	content.dll!content::BrowserMain(const content::MainFunctionParams & parameters) Line 47	C++	Symbols loaded.
 	content.dll!content::RunBrowserProcessMain(const content::MainFunctionParams & main_function_params, content::ContentMainDelegate * delegate) Line 541	C++	Symbols loaded.
 	content.dll!content::ContentMainRunnerImpl::Run(bool start_service_manager_only) Line 914	C++	Symbols loaded.
 	content.dll!content::ContentServiceManagerMainDelegate::RunEmbedderProcess() Line 53	C++	Symbols loaded.
 	embedder.dll!service_manager::Main(const service_manager::MainParams & params) Line 472	C++	Symbols loaded.
 	content.dll!content::ContentMain(const content::ContentMainParams & params) Line 20	C++	Symbols loaded.
 	chrome.dll!ChromeMain(HINSTANCE__ * instance, sandbox::SandboxInterfaceInfo * sandbox_info, __int64 exe_entry_point_ticks) Line 102	C++	Symbols loaded.
 	chrome.exe!MainDllLoader::Launch(HINSTANCE__ * instance, base::TimeTicks exe_entry_point_ticks) Line 201	C++	Symbols loaded.
 	chrome.exe!wWinMain(HINSTANCE__ * instance, HINSTANCE__ * prev, wchar_t *, int) Line 229	C++	Symbols loaded.
 	[External Code]		Annotated Frame

Cc: swarnasree.mukkala@chromium.org
 Issue 897551  has been merged into this issue.
Owner: hkamila@chromium.org
> I managed to debug this as it is not related to sign-in. The issue is way more complex IMHO and the bug is in the settings UI.

@msarda: Does the issue happen if you --disable-features=WebUIPolymer2 ? Trying to understand whether r600225 (which is in the bisection range) is related to this regression.

Otherwise, looking at the bisection range, https://chromium-review.googlesource.com/c/chromium/src/+/1238461 seems related to the issue here, even though per description this should only affect Android?

@hkamila: Can you take a look?
Following up from comment #8: Could it be that after signing in to Android Chrome, because of https://chromium-review.googlesource.com/c/chromium/src/+/1238461, cookies get disabled, which then syncs to Desktop Chrome?
@dpapad I don't think my cl is the culprit, as it only changes android code, and we don't sync content settings between android and desktop.
Owner: dpa...@chromium.org
crbug seems to be misbehaving. I already marked this bug as a duplicate of  issue 897236 , but neither of the issues seem to have been updated accordingly.
Today's update Version 72.0.3590.0 (Official Build) canary (32-bit) fixed my problem of allowing cookies.  When might we see a 64-bit release?

Sign in to add a comment