Issue metadata
Sign in to add a comment
|
Port forwarding doesn't work |
||||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.67 (Official Build) (64-bit) OS: Mac OS X / Linux Android Chrome version: 69.0.3497.100 What steps will reproduce the problem? (1) Run "python -m SimpleHTTPServer 8000" on PC. (2) Connect Android device to PC. (3) Open chrome://inspect/#devices on PC and click "Port forwarding..." (4) Add 8000 localhost:8000. (5) Check "Enable port forwarding" and click "Done" (6) Open localhost:8000 on Android What is the expected result? The response from the SimpleHTTPServer should be shown. What happens instead? The error page is shown: This page isn't working 127.0.0.1 didn't send any data. ERR_EMPTY_RESPONSE I think this is a regression. Port forwarding worked well in Chrome 69.0.3497.100.
,
Oct 19
,
Oct 19
,
Oct 20
,
Oct 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/290959673f4e335d0e84443224712af0c2518813 commit 290959673f4e335d0e84443224712af0c2518813 Author: Jun Cai <juncai@chromium.org> Date: Sat Oct 20 02:07:42 2018 Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#601390} [modify] https://crrev.com/290959673f4e335d0e84443224712af0c2518813/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/290959673f4e335d0e84443224712af0c2518813/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 20
To be safe, I reverted the CL that caused this issue while I am working on the fix. I also added merge-request for M70 and M71.
,
Oct 20
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 21
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 21
Approving merge to M71 branch 3578 based on comment #6. Pls merge latest by 1:00 PM PT, Monday, 10/22 so we can pick it up for next week beta release. Thank you.
,
Oct 21
Pls merge your change to M71 branch 3578 latest by 1:00 PM PT, Monday, 10/22 so we can pick it up for next week beta release. Thank you.
,
Oct 22
Able to reproduce the issue with steps in c#0, using Chrome version 70.0.3538.67 and Android Chrome Version 69.0.3497.100. i.e; Observed ERR_EMPTY_RESPONSE error in Android Chrome. Hence verifying the fix on latest canary #72.0.3588.0 and Android chrome version 69.0.3497.100 Now observing directory listing data on opening localhost:8000 in Android chrome version. As this fix is working as expected adding TE-Verified labels. Thanks!
,
Oct 22
NOTE: Verified the issue on Mac, Linux and Windows.
,
Oct 22
Why is this critical for M70? We will need a postmortem for this also, if it's absolutely critical and needs to be merged
,
Oct 22
Developers can't serve up local content from their workstation via DevTools to their Android devices for testing. This is a severe regression.
,
Oct 22
Is this only happening with network-service exp enabled? How safe is this fix overall?
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74fd5460d048035f72385d2098d20a0832770469 commit 74fd5460d048035f72385d2098d20a0832770469 Author: Jun Cai <juncai@chromium.org> Date: Mon Oct 22 17:17:08 2018 Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294192 Cr-Commit-Position: refs/branch-heads/3578@{#221} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/74fd5460d048035f72385d2098d20a0832770469/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/74fd5460d048035f72385d2098d20a0832770469/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 22
abdulsyed@, it doesn't need the network service flag enabled. So it can happen with or without network service enabled. I believe it is safe since it just reverts to the previous working code.
,
Oct 22
I am writing a postmortem for this issue, and will share it soon.
,
Oct 22
Let's verify this further in M71 dev tomorrow. Approving merge to M70.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6deffe5b4ec63d84909c05c0270f2101ce40d895 commit 6deffe5b4ec63d84909c05c0270f2101ce40d895 Author: Jun Cai <juncai@chromium.org> Date: Mon Oct 22 19:03:27 2018 Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294410 Cr-Commit-Position: refs/branch-heads/3538@{#1028} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/6deffe5b4ec63d84909c05c0270f2101ce40d895/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/6deffe5b4ec63d84909c05c0270f2101ce40d895/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6deffe5b4ec63d84909c05c0270f2101ce40d895 Commit: 6deffe5b4ec63d84909c05c0270f2101ce40d895 Author: juncai@chromium.org Commiter: juncai@chromium.org Date: 2018-10-22 19:03:27 +0000 UTC Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294410 Cr-Commit-Position: refs/branch-heads/3538@{#1028} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 22
postmortem tracking bug was created: https://bugs.chromium.org/p/chromium/issues/detail?id=897876 and the postmortem doc link can be found in the above link.
,
Oct 22
,
Oct 23
Able to reproduce the issue with steps in c#0, using Chrome version 70.0.3538.67 and Android Chrome Version 69.0.3497.100. i.e; Observed ERR_EMPTY_RESPONSE error in Android Chrome. Hence verifying the fix on #71.0.3578.20 and Android chrome version 69.0.3497.100 Now observing directory listing data on opening localhost:8000 in Android chrome version. As this fix is working as expected adding TE-Verified labels. Thanks!
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74fd5460d048035f72385d2098d20a0832770469 Commit: 74fd5460d048035f72385d2098d20a0832770469 Author: juncai@chromium.org Commiter: juncai@chromium.org Date: 2018-10-22 17:17:08 +0000 UTC Revert "Network Service: Convert port_forwarding_controller.cc to mojo host resolver" This reverts commit 8e3e6c835acc68d8962a0beb98ccf866564b82e7. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=896603 Original change's description: > Network Service: Convert port_forwarding_controller.cc to mojo host resolver > > Bug: 874651 > Change-Id: I4762526cc8fc4dbf18512b8ab7fbeeda8434336d > Reviewed-on: https://chromium-review.googlesource.com/1184306 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585658} TBR=caseq@chromium.org,mmenke@chromium.org,juncai@chromium.org,ericorth@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874651 , 896603 Change-Id: Iaeede103359aeb369589620ec10085dcf20311ee Reviewed-on: https://chromium-review.googlesource.com/c/1292824 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601390}(cherry picked from commit 290959673f4e335d0e84443224712af0c2518813) Reviewed-on: https://chromium-review.googlesource.com/c/1294192 Cr-Commit-Position: refs/branch-heads/3578@{#221} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 24
Able to reproduce the issue with steps in c#0, using Chrome version 70.0.3538.67 and Android Chrome Version 69.0.3497.100. i.e; Observed ERR_EMPTY_RESPONSE error in Android Chrome. Hence verifying the fix on #70.0.3538.77 and Android chrome version 69.0.3497.100 Now observing directory listing data on opening localhost:8000 in Android chrome version. As this fix is working as expected adding TE-Verified labels. Thanks!
,
Oct 24
Is there a way to workaround the issue in M70 while waiting for the fix to make it tox stable?
,
Oct 24
I guess there is no obvious workaround here.
,
Oct 24
From the command line, you can run (taking port 8080 for example): adb root && adb reverse tcp:8080 tcp:8080 to set up reverse port forwarding. However, I think this is incompatible with DevTools' debugging, as it uses a different adb and conflicts with any one that's accessible from the command line.
,
Oct 30
spoke with Jun and this does not block stable.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a312ce969ef219e926aa0c0e87effe7c9a943cb6 commit a312ce969ef219e926aa0c0e87effe7c9a943cb6 Author: Jun Cai <juncai@chromium.org> Date: Wed Oct 31 17:57:04 2018 Reland: Network Service: Convert port_forwarding_controller.cc to mojo host resolver The "Initial upload" patch is the same as the reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1184306 Bug: 874651 , 896603 Change-Id: I406f587cf4b9e69a80fb82e4558a78209eca801c Reviewed-on: https://chromium-review.googlesource.com/c/1294719 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604325} [modify] https://crrev.com/a312ce969ef219e926aa0c0e87effe7c9a943cb6/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/a312ce969ef219e926aa0c0e87effe7c9a943cb6/chrome/browser/devtools/device/port_forwarding_controller.h
,
Oct 31
,
Nov 2
Able to reproduce the issue with steps in c#0, using Chrome version 70.0.3538.67 and Android Chrome Version 69.0.3497.100. i.e; Observed ERR_EMPTY_RESPONSE error in Android Chrome. Hence verifying the fix on #72.0.3599.0 and Android chrome version 69.0.3497.100 Now observing directory listing data on opening localhost:8000 in Android chrome version. As this fix is working as expected adding TE-Verified labels. Thanks!
,
Nov 3
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by horo@chromium.org
, Oct 19Components: Internals>Services>Network
Owner: juncai@chromium.org
Status: Assigned (was: Untriaged)