New issue
Advanced search Search tips

Issue 896581 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
rbpotter@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 896748



Sign in to add a comment

Regression: No space is seen between Relaunch and Toggle button in chrome://settings.

Reported by aiman.an...@etouch.net, Oct 18 
Chrome Version: 72.0.3584.0 (Official Build) Revision 945ab041ec6ac3fb389f94dcbfebb1839a12a69b-refs/branch-heads/3584@{#1} (32/64-bit)
 	
OS: Win(7,8,8.1,10).
	       
What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/system
2. Toggle button for Hardware Acceleration and observe.
 
Actual Result: No space is seen between Relaunch and Toggle button

Expected Result: Proper defined spacing should be there between Relaunch and Toggle button

This is a regression issue, broken in M-72, and below is the bisect provided using per-revision script.

Good Build:72.0.3583.0 (Revision:600164)
Bad Build: 72.0.3584.0 (Revision:600616)

Kindly refer the attached screen-cast for reference.

Thank You!
Actual Result.mp4
282 KB View Download
Expected Result.mp4
192 KB View Download

Comment 1 by aiman.an...@etouch.net, Oct 18

Labels: hasbisect OS-Linux OS-Mac
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

1. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.
2. Hence providing suspect via Chromium bisect.

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/62f2f8f209a82db0dd5a311eb4f844bddb75c98e..631a939b2b9a02a05cd1db367c7ea7fb17d14f50?pretty=fuller&n=10000

Suspect: r600225 ?

dpapad@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also seen on Mac(10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTS).

Thank You!

Comment 2 by dpa...@chromium.org, Oct 18

Blocking: 896748
Cc: rbpotter@chromium.org

Comment 3 by dpa...@chromium.org, Oct 18

Labels: Pri-2
Owner: ----
Status: Available (was: Assigned)

Comment 4 by dpa...@chromium.org, Oct 23

Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c9f4003994d80e078a35ce3c53874b2ba712f42

commit 3c9f4003994d80e078a35ce3c53874b2ba712f42
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 24 02:01:14 2018

Fix slotted style for more-actions slot within settings-toggle-button.

Bug:  896581 
Change-Id: Ie8542938f8eb92670ea17fd8a8feb9df91368040
Reviewed-on: https://chromium-review.googlesource.com/c/1297599
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602216}
[modify] https://crrev.com/3c9f4003994d80e078a35ce3c53874b2ba712f42/chrome/browser/resources/settings/controls/settings_toggle_button.html

Comment 6 by dpa...@chromium.org, Oct 24

Status: Fixed (was: Started)

Comment 7 by aiman.an...@etouch.net, Oct 25

Labels: TE-Verified-M72 TE-Verified-72.0.3591.0
Hi,

Retested the above issue on Win(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTS) using latest Canary build #72.0.3591.0 and Issue is fixed.

Now, Proper spacing is seen between Relaunch and Toggle button.

Kindly refer the attached screen-cast for reference.

Thank You!
Canary Behavior.mp4
294 KB View Download
►

Sign in to add a comment