New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896556 link

Starred by 1 user
Status: Fixed
Owner:
mmoroz@chromium.org
Closed: Oct 18
Cc:
█ robert...@chromium.org
liaoyuke@chromium.org
mmoroz@chromium.org
infe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Code Coverage tools bundle is getting incorrectly unpacked

Project Member Reported by mmoroz@chromium.org, Oct 18 
Just noticed the the bots are failing to produce new reports because llvm-cov and llvm-profdata files are in /chromium/src/third_party/llvm-build/Release+Asserts/bin/bin/ directory instead of /chromium/src/third_party/llvm-build/Release+Asserts/bin/  <--- single "bin" at the end.

I suspect this was introduced in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1274127/9/tools/code_coverage/update_clang_coverage_tools.py#52

Comment 1 by mmoroz@chromium.org, Oct 18

Owner: mmoroz@chromium.org
Status: Started (was: Assigned)
Verified that this is the issue and uploaded the fix: https://chromium-review.googlesource.com/c/chromium/src/+/1288689
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d26f5c50005671c4200120c7d9ca347259c0279d

commit d26f5c50005671c4200120c7d9ca347259c0279d
Author: Max Moroz <mmoroz@chromium.org>
Date: Thu Oct 18 13:49:00 2018

Code Coverage: use correct path to llvm binaries in update_clang_coverage_tools.py.

TBR=liaoyuke@chromium.org,robertocn@chromium.org

Change-Id: I783b07eacca213f2815f6c0f66bfb77c55b9435f
Bug:  896556 
Reviewed-on: https://chromium-review.googlesource.com/c/1288689
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600748}
[modify] https://crrev.com/d26f5c50005671c4200120c7d9ca347259c0279d/tools/code_coverage/update_clang_coverage_tools.py

Comment 3 by mmoroz@chromium.org, Oct 18

Status: Fixed (was: Started)

Comment 4 by mmoroz@chromium.org, Oct 18 

Restarted bot -0001 and scheduled restarts for the others with 2 hours interval.
►

Sign in to add a comment