Cocoa regression, I'm sure.
Related to bug 788049 ?
#1: Likely the same bug honestly - I'll mark as a duplicate.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6 commit f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Oct 22 22:06:35 2018 bookmarks: show ampersands in bookmark titles in app menu This change: 1) Moves and renames ui::EscapeWindowsStyleAccelerators to make it available on other platforms; 2) Has BookmarkMenuDelegate call that function if the bookmark menu is being shown in the app menu; 3) Has BackForwardMenuModel call that function instead of hand-rolling escaping In MenuItemViews whose root MenuItemView has_mnemonics(), '&' is interpreted as a mnemonic marker, which makes it necessary to escape them. Bug: 896550 , 788049 Change-Id: I83f6bc6f5b71efa1d7220d8d20afa7dd833771ba Reviewed-on: https://chromium-review.googlesource.com/c/1287325 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601744} [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/chrome/browser/ui/toolbar/back_forward_menu_model.cc [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/ui/base/accelerators/menu_label_accelerator_util.cc [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/ui/base/accelerators/menu_label_accelerator_util.h [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/ui/base/accelerators/menu_label_accelerator_util_linux.cc [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/ui/base/accelerators/menu_label_accelerator_util_linux.h [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/ui/base/accelerators/menu_label_accelerator_util_linux_unittest.cc [modify] https://crrev.com/f8b6b9dc2e636fdc5d3333c4dae832ff1a9baad6/ui/base/accelerators/menu_label_accelerator_util_unittest.cc
Issue 913656 has been merged into this issue.
Comment 1 by a...@chromium.org
, Oct 18