New issue
Advanced search Search tips

Issue 896548 link

Starred by 1 user
Status: Assigned
Owner:
mahmadi@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Uniquely identify and retrieve forms and fields in Javascript

Project Member Reported by mahmadi@chromium.org, Oct 18 
expand __gCrWeb.form.getFormIdentifier and __gCrWeb.form.getFieldIdentifier so that the generated ids (or their combination) can be used to uniquely identify and retrieve forms and fields in Javascript for Autofill purposes.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7103b1715f77c5710c24df8926c4a4b864abc0f9

commit 7103b1715f77c5710c24df8926c4a4b864abc0f9
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Oct 23 14:29:23 2018

[AF][IOS] Removes "field name" from form activity event and suggestions API

Field name is not used to retrieve/apply suggestions in iOS. It can be
removed from form activity events (FormActivityParams) as well as the
suggestions API (FormSuggestionProvider). Note that field name is still
present in the autofill::FormFieldData and used for calculating form
signatures, identifying fields in server type suggestions, and field
heuristic types.

This change also disables Autocomplete suggestion for ios/web_view which is
the desired behavior.

Bug: 896548
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7542c2e5bc8526d7b83d027f1a3db29728507047
Reviewed-on: https://chromium-review.googlesource.com/c/1287302
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601947}
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/browser/autofill_agent_unittests.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/browser/fake_autofill_agent.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/browser/fake_autofill_agent.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/browser/form_suggestion_provider.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/form_util/form_activity_observer_bridge_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/form_util/form_activity_params.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/form_util/form_activity_tab_helper.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/form_util/form_activity_tab_helper_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/components/autofill/ios/form_util/resources/form_handlers.js
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/chrome/browser/autofill/form_suggestion_controller.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/chrome/browser/ui/autofill/manual_fill/form_observer_helper_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/autofill/cwv_autofill_suggestion.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/autofill/cwv_autofill_suggestion_internal.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/autofill/cwv_autofill_suggestion_unittest.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/passwords/cwv_password_controller.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/internal/passwords/cwv_password_controller.mm
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/public/cwv_autofill_controller.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/public/cwv_autofill_controller_delegate.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/public/cwv_autofill_suggestion.h
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/shell/shell_autofill_delegate.m
[modify] https://crrev.com/7103b1715f77c5710c24df8926c4a4b864abc0f9/ios/web_view/test/web_view_autofill_inttest.mm
►

Sign in to add a comment