New issue
Advanced search Search tips

Issue 896542 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 888973
issue 893797



Sign in to add a comment

Perf-improve tracking for r596492 "Make ObserverList 10~20 times faster"

Project Member Reported by tapted@chromium.org, Oct 18

Issue description

Dumping ground for pinpoints tracking perf changes around r596492. i.e. https://chromeperf.appspot.com/group_report?rev=59649

This is difficult because of Issue 894287 "rendering benchmark results is noisy"

There are
1016+25+8+59+16+6+37+5+4+3+51+5+3+2+1+1+5+1+2+1+3+2
= 1256 items in that group.

That first blob is rendering.desktop

Hm. And a lot of the other stuff is  Issue 892685 .

I dunno if I can get useful stuff out of this experiment. I'll do some spot checks.
 
Cc: tapted@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/106bb88ee40000

Make ObserverList iteration 10~20 times faster. by tapted@chromium.org
https://chromium.googlesource.com/chromium/src/+/f59cdf0d304cd451e2507a13dd12da6f8fccaffb
FocusUpdate: 3.404e+04 → 3.792e+04 (+3878)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
#c3 is a 12.4% perf improve for mac-10_12_laptop_low_end-perf/blink_perf.css/FocusUpdate
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/159612b6e40000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14e682e6e40000

All of the runs failed. The most common error (330/800 runs) was:
ReadValueError: Could not find values matching: {'story': u'https://www.google.com/calendar/', 'histogram': u'LevelDB_memory_dump_cpu_overhead'}

Sign in to add a comment