New JSErrorCount count makes tests in VideoPlayer and AudioPlayer flaky |
|||
Issue descriptionSome tests from AudioPlayer and VideoPlayer became flaky when I switched AudioPlayer and VideoPlayer to use the new JSErrorCount functions. The reason for this is that now it counts errors from unhandled promise rejections. Example error: [ RUN ] VideoPlayerBrowserTest.ClickControlButtons [25397:25397:1017/051759.460442:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user [25397:25397:1017/051759.766870:INFO:easy_unlock_service_regular.cc(163)] DeviceSyncClient is not ready yet, delaying UseLoadedRemoteDevices(). [25397:25397:1017/051801.077206:INFO:secure_channel_service.cc(25)] SecureChannelService::OnStart() [25397:25397:1017/051801.077651:INFO:secure_channel_initializer.cc(64)] SecureChannelInitializer::SecureChannelInitializer(): Fetching Bluetooth adapter. All requests received before the adapter is fetched will be queued. [25397:25397:1017/051801.078304:INFO:secure_channel_service.cc(38)] SecureChannelService::OnBindInterface() for interface chromeos.secure_channel.mojom.SecureChannel. [25397:25397:1017/051801.080570:INFO:device_sync_service.cc(30)] DeviceSyncService::OnStart() [25397:25397:1017/051801.081195:INFO:device_sync_service.cc(46)] DeviceSyncService::OnBindInterface() from interface chromeos.device_sync.mojom.DeviceSync. [25397:25397:1017/051801.083522:INFO:multidevice_setup_service.cc(60)] MultiDeviceSetupService::OnStart() [25397:25397:1017/051801.084144:INFO:multidevice_setup_service.cc(73)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup. [25397:25397:1017/051801.128014:INFO:secure_channel_initializer.cc(119)] SecureChannelInitializer::OnBluetoothAdapterReceived(): Bluetooth adapter has been fetched. Passing all queued requests to the service. [25397:25397:1017/051801.136795:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [25397:25397:1017/051801.365062:INFO:multidevice_setup_service.cc(73)] MultiDeviceSetupService::OnBindInterface() from interface chromeos.multidevice_setup.mojom.MultiDeviceSetup. [25397:25397:1017/051802.019437:INFO:file_manager_browsertest_base.cc(1160)] FileManagerBrowserTest::StartTest clickControlButtons [25397:25397:1017/051811.629166:INFO:CONSOLE(4942)] "Waiting for the result of getFilesUnderVolume", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4942) [25397:25397:1017/051811.640637:INFO:CONSOLE(5553)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5553) [25397:25397:1017/051811.935507:INFO:CONSOLE(5555)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5555) [25397:25397:1017/051811.939648:INFO:CONSOLE(5565)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5565) [25397:25397:1017/051811.940658:INFO:CONSOLE(6019)] "Requesting file system: android_files android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6019) [25397:25397:1017/051811.943612:INFO:CONSOLE(5565)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5565) [25397:25397:1017/051811.944389:INFO:CONSOLE(6019)] "Requesting file system: downloads downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6019) [25397:25397:1017/051812.026927:INFO:CONSOLE(5565)] "Initializing volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5565) [25397:25397:1017/051812.027976:INFO:CONSOLE(6019)] "Requesting file system: drive drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6019) [25397:25397:1017/051813.149080:INFO:CONSOLE(6069)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6069) [25397:25397:1017/051813.149495:INFO:CONSOLE(5569)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5569) [25397:25397:1017/051813.150187:INFO:CONSOLE(6069)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6069) [25397:25397:1017/051813.150571:INFO:CONSOLE(5569)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5569) [25397:25397:1017/051813.280322:INFO:CONSOLE(5553)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5553) [25397:25397:1017/051813.309399:INFO:CONSOLE(6069)] "File system obtained: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6069) [25397:25397:1017/051813.324488:INFO:CONSOLE(5569)] "Initialized volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5569) [25397:25397:1017/051813.329434:INFO:CONSOLE(5573)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5573) [25397:25397:1017/051813.361481:INFO:CONSOLE(5555)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5555) [25397:25397:1017/051813.362090:INFO:CONSOLE(5565)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5565) [25397:25397:1017/051813.362624:INFO:CONSOLE(6019)] "Requesting file system: android_files android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6019) [25397:25397:1017/051813.363546:INFO:CONSOLE(4939)] "Received the result of getFilesUnderVolume", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4939) [25397:25397:1017/051813.368389:INFO:CONSOLE(720)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (720) [25397:25397:1017/051813.502738:INFO:CONSOLE(5565)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5565) [25397:25397:1017/051813.503345:INFO:CONSOLE(6019)] "Requesting file system: downloads downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6019) [25397:25397:1017/051813.504747:INFO:CONSOLE(5565)] "Initializing volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5565) [25397:25397:1017/051813.505216:INFO:CONSOLE(6019)] "Requesting file system: drive drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6019) [25397:25397:1017/051813.543324:INFO:CONSOLE(4942)] "Waiting for the result of openVideoPlayer", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4942) [25397:25397:1017/051813.601573:INFO:CONSOLE(6069)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6069) [25397:25397:1017/051813.621914:INFO:CONSOLE(5569)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5569) [25397:25397:1017/051813.757576:INFO:CONSOLE(6069)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6069) [25397:25397:1017/051813.758353:INFO:CONSOLE(5569)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5569) [25397:25397:1017/051813.758921:INFO:CONSOLE(6069)] "File system obtained: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (6069) [25397:25397:1017/051813.799121:INFO:CONSOLE(5569)] "Initialized volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5569) [25397:25397:1017/051813.799593:INFO:CONSOLE(5573)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5573) [25397:25397:1017/051814.290958:INFO:CONSOLE(4939)] "Received the result of openVideoPlayer", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4939) [25397:25397:1017/051814.358567:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [25397:25397:1017/051815.292790:INFO:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442) [25397:25397:1017/051817.156038:INFO:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083) [25397:25397:1017/051817.960863:ERROR:private_api_drive.cc(928)] Not supported file system type. [25397:25397:1017/051821.688616:INFO:CONSOLE(62)] "[unhandled-error]: Either "Google Cast API" or "Google Cast" extension seems not to be installed? Error: original stack at console.error.args [as error] (chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/js/video_player_scripts.js:59:19) at chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/js/video_player_scripts.js:9485:15 at wrappedCallback (chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/js/video_player_scripts.js:102:19)", source: chrome-extension://jcgeabjmjgoblfofpppfkcoakmfobdko/js/video_player_scripts.js (62) [25397:25397:1017/051821.801868:INFO:CONSOLE(0)] "[FAIL] [clickControlButtons]: API Test Error in [clickControlButtons]: The error count is not 0. Actual: 1 Expected: 0 Error at extensions::test:243:18 at chrome-extension://ljoplibgfehghmibaoaepfagnmbbfiga/test_util.js:56:17", source: chrome-extension://ljoplibgfehghmibaoaepfagnmbbfiga/_generated_background_page.html (0) [25397:25397:1017/051821.803206:INFO:CONSOLE(0)] "Uncaught (in promise) chrome.test.failure", source: chrome-extension://ljoplibgfehghmibaoaepfagnmbbfiga/_generated_background_page.html (0) ../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:1187: Failure Failed Failed 1 of 1 tests Stack trace:
,
Oct 18
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/506ce45de04c748b9c4481c2a1d43ffcd83d7692 commit 506ce45de04c748b9c4481c2a1d43ffcd83d7692 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Oct 18 02:49:32 2018 Revert "Unify JSErrorCounter for Files, Audio, Video and Gallery apps." This reverts commit c4d25f5b67f67cf274db8a2fdc9b03342f113ac6. Reason for revert: This made some tests for Video and Audio players flaky crbug.com/896529 Original change's description: > Unify JSErrorCounter for Files, Audio, Video and Gallery apps. > > Bug: 893430 > Change-Id: I4cb8149eaec9c9ab22700905dae804ac893fdb6c > Reviewed-on: https://chromium-review.googlesource.com/c/1282517 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600308} TBR=tapted@chromium.org,noel@chromium.org,lucmult@chromium.org Change-Id: I676ef1e26b98ff842158501ebf1221520db18bc9 Bug: 896529 Reviewed-on: https://chromium-review.googlesource.com/c/1287729 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#600642} [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/audio_player/js/BUILD.gn [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/audio_player/js/audio_player_scripts.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/audio_player/js/background_scripts.js [add] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/audio_player/js/error_util.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/file_manager/background/js/background_common_scripts.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/file_manager/background/js/background_scripts.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/gallery/js/gallery_scripts.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/gallery/js/test_util.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/video_player/js/BUILD.gn [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/video_player/js/background_scripts.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/video_player/js/cast/BUILD.gn [add] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/video_player/js/error_util.js [modify] https://crrev.com/506ce45de04c748b9c4481c2a1d43ffcd83d7692/ui/file_manager/video_player/js/video_player_scripts.js
,
Oct 18
Cool thanks, starting to AudioPlayer VideoPlayer tests recover https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AudioPlayer%20VideoPLayer BTW, how's GalleryBrowserTest going?
,
Oct 18
Gallery tests are all green, there is one CRASH,PASS, but it isn't related to this change, so the bug title is correct. I don't intend to work on this in the near term, I'm trying to focus on my OKRs. :-) |
|||
►
Sign in to add a comment |
|||
Comment 1 by lucmult@chromium.org
, Oct 18