Change "Themes & Wallpapers" string in Sync/Unity settings to "Themes" everywhere but ChromeOS |
|||||
Issue descriptionIf there are no wallpapers (e.g. everywhere but ChromeOS), the string shouldn't mention them. Change "Themes & Wallpapers" string in Sync/Unity settings to "Themes" everywhere but ChromeOS. Sabine/Marc - please triage.
,
Oct 18
Assigning to Eli to answer in comment #1
,
Oct 18
We just carried over the strings from the old sync settings. Nothing changed with Unity. So no, not a conscious decision.
,
Oct 18
Assigning to Thomas to fix the string as this is Unity work.
,
Oct 26
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d98a61051050e6ea95e9724baa182eb6575b7ff commit 2d98a61051050e6ea95e9724baa182eb6575b7ff Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Oct 29 11:36:18 2018 Rename sync string for Themes on non-ChromeOS Bug: 896515 Change-Id: Idd45447bd092e934286f0b574782b92caa61a051 Reviewed-on: https://chromium-review.googlesource.com/c/1301517 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#603458} [modify] https://crrev.com/2d98a61051050e6ea95e9724baa182eb6575b7ff/chrome/app/settings_strings.grdp
,
Oct 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by treib@chromium.org
, Oct 18