Flaky test: TopControlsSlideControllerTest.TestToggleChromeVox Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=409d0de99a3aef10 Test output log: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29624 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5NjI0L3Zpel9icm93c2VyX3Rlc3RzL1ZHOXdRMjl1ZEhKdmJITlRiR2xrWlVOdmJuUnliMnhzWlhKVVpYTjBMbFJsYzNSVWIyZG5iR1ZEYUhKdmJXVldiM2c9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20TopControlsSlideControllerTest.TestToggleChromeVox&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5NjI0L3Zpel9icm93c2VyX3Rlc3RzL1ZHOXdRMjl1ZEhKdmJITlRiR2xrWlVOdmJuUnliMnhzWlhKVVpYTjBMbFJsYzNSVWIyZG5iR1ZEYUhKdmJXVldiM2c9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86380d8b8f6163a5138d9dd91c740d3e0a58b40b commit 86380d8b8f6163a5138d9dd91c740d3e0a58b40b Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Oct 17 23:58:57 2018 Revert "top-chrome-slide: Disable the behavior when Chromevox is enabled." This reverts commit ac77d3be9db2aba1c1ee14b7cefa400b6bfdc0e0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600408 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWM3N2QzYmU5ZGIyYWJhMWMxZWUxNGI3Y2VmYTQwMGI2YmZkYzBlMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29624 Sample Failed Step: viz_browser_tests Sample Flaky Test: TopControlsSlideControllerTest.TestToggleChromeVox Original change's description: > top-chrome-slide: Disable the behavior when Chromevox is enabled. > > Users of Chromevox may need to touch explore the webpage, and for > things to remain consistent, we should disable hiding top-chrome > with gesture scrolls as long as Chromevox is enabled. > > BUG=857331 > TEST=Added a new browser test. > > Change-Id: Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b > Reviewed-on: https://chromium-review.googlesource.com/c/1284289 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600408} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=857331, 896514 Change-Id: If1640bcc475ecbf869dd26dc11b35e6f9bc4fc75 Reviewed-on: https://chromium-review.googlesource.com/c/1287429 Cr-Commit-Position: refs/heads/master@{#600609} [modify] https://crrev.com/86380d8b8f6163a5138d9dd91c740d3e0a58b40b/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/86380d8b8f6163a5138d9dd91c740d3e0a58b40b/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/86380d8b8f6163a5138d9dd91c740d3e0a58b40b/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
The flaky test has been reverted. afakhry@, you wrote the reverted CL so I'm assigning the bug to you.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12e9672133ae5b047614abfb2789315df2cb1e83 commit 12e9672133ae5b047614abfb2789315df2cb1e83 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Thu Oct 18 23:42:00 2018 (Reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. R=sky@chromium.org BUG=857331, 896514 TEST=Added a new browser test. Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600408} Change-Id: I388bc5056f956bea2edffc7127dcab533824e56b Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Commit-Position: refs/heads/master@{#600966} [modify] https://crrev.com/12e9672133ae5b047614abfb2789315df2cb1e83/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/12e9672133ae5b047614abfb2789315df2cb1e83/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/12e9672133ae5b047614abfb2789315df2cb1e83/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ebd4db9fe1456bba70fd6dcd3fd23d2d6c8dd00 commit 5ebd4db9fe1456bba70fd6dcd3fd23d2d6c8dd00 Author: Fergal Daly <fergal@chromium.org> Date: Mon Oct 22 02:27:07 2018 Revert "(Reland) top-chrome-slide: Disable the behavior when Chromevox is enabled." This reverts commit 12e9672133ae5b047614abfb2789315df2cb1e83. Reason for revert: Reland also causes flakes https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyygELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKTAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0OTYzL3NpbmdsZV9wcm9jZXNzX21hc2hfYnJvd3Nlcl90ZXN0cy9WRzl3UTI5dWRISnZiSE5UYkdsa1pVTnZiblJ5YjJ4c1pYSlVaWE4wTGxSbGMzUlViMmRuYkdWRGFISnZiV1ZXYjNnPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Original change's description: > (Reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. > > Users of Chromevox may need to touch explore the webpage, and for > things to remain consistent, we should disable hiding top-chrome > with gesture scrolls as long as Chromevox is enabled. > > R=sky@chromium.org > BUG=857331, 896514 > TEST=Added a new browser test. > > Reviewed-on: https://chromium-review.googlesource.com/c/1284289 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#600408} > Change-Id: I388bc5056f956bea2edffc7127dcab533824e56b > Reviewed-on: https://chromium-review.googlesource.com/c/1287510 > Cr-Commit-Position: refs/heads/master@{#600966} TBR=sky@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 857331, 896514 Change-Id: I62e0f5202c2b5c408dfeb6555d4ca378038be267 Reviewed-on: https://chromium-review.googlesource.com/c/1293091 Reviewed-by: Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601466} [modify] https://crrev.com/5ebd4db9fe1456bba70fd6dcd3fd23d2d6c8dd00/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/5ebd4db9fe1456bba70fd6dcd3fd23d2d6c8dd00/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/5ebd4db9fe1456bba70fd6dcd3fd23d2d6c8dd00/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5743609504ecca4eb89ba55b26722ad76be2cb23 commit 5743609504ecca4eb89ba55b26722ad76be2cb23 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Thu Oct 25 22:14:51 2018 (Reland of reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. R=sky@chromium.org BUG=857331, 896514 , 867063, 898502 TEST=Added a new browser test. Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#600408} Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Original-Commit-Position: refs/heads/master@{#600966} Change-Id: I82713fcf642e06cd8e62342d0291ca40e4cd6ffb Reviewed-on: https://chromium-review.googlesource.com/c/1294406 Cr-Commit-Position: refs/heads/master@{#602893} [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27390fd98a365a3a898610371193062efb414ffb commit 27390fd98a365a3a898610371193062efb414ffb Author: Ahmed Fakhry <afakhry@chromium.org> Date: Wed Oct 31 23:29:56 2018 [Merge to M-71] (Reland of reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. TBR=sky@chromium.org BUG=857331, 896514 , 867063, 898502 TEST=Added a new browser test. (cherry picked from commit 5743609504ecca4eb89ba55b26722ad76be2cb23) Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#600408} Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Original-Original-Commit-Position: refs/heads/master@{#600966} Change-Id: I82713fcf642e06cd8e62342d0291ca40e4cd6ffb Reviewed-on: https://chromium-review.googlesource.com/c/1294406 Cr-Original-Commit-Position: refs/heads/master@{#602893} Reviewed-on: https://chromium-review.googlesource.com/c/1311934 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#440} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27390fd98a365a3a898610371193062efb414ffb Commit: 27390fd98a365a3a898610371193062efb414ffb Author: afakhry@chromium.org Commiter: afakhry@chromium.org Date: 2018-10-31 23:29:56 +0000 UTC [Merge to M-71] (Reland of reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. TBR=sky@chromium.org BUG=857331, 896514 , 867063, 898502 TEST=Added a new browser test. (cherry picked from commit 5743609504ecca4eb89ba55b26722ad76be2cb23) Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#600408} Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Original-Original-Commit-Position: refs/heads/master@{#600966} Change-Id: I82713fcf642e06cd8e62342d0291ca40e4cd6ffb Reviewed-on: https://chromium-review.googlesource.com/c/1294406 Cr-Original-Commit-Position: refs/heads/master@{#602893} Reviewed-on: https://chromium-review.googlesource.com/c/1311934 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#440} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Comment 1 by bugdroid1@chromium.org
, Oct 18