New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896507 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

sync confirmation dialog seems broken

Project Member Reported by scottchen@chromium.org, Oct 17

Issue description

see screenshot.

clicking on turn-on also doesn't do anything anymore.

 
Screenshot 2018-10-17 at 4.14.28 PM.png
359 KB View Download
Cc: -dpa...@chromium.org tangltom@chromium.org
Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
Fix at https://chromium-review.googlesource.com/c/chromium/src/+/1287258. It only happens with Polymer 2 (which is now turned on by default on ToT).
Cc: droger@chromium.org pbomm...@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 896596  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c79ead06c24400f12c150529a5ec55060577f87

commit 5c79ead06c24400f12c150529a5ec55060577f87
Author: dpapad <dpapad@chromium.org>
Date: Thu Oct 18 19:39:03 2018

Fix sync-confirmation dialog styling in Polymer 2.

Need to wrap <style is="custom-style"> with <custom-style> such that styling
works both in Polymer 1 and Polymer 2.

Bug: 739532, 896507 
Change-Id: I40e4a1fa6ac071cc31268c5e86fa13a023a59490
Reviewed-on: https://chromium-review.googlesource.com/c/1287258
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600868}
[modify] https://crrev.com/5c79ead06c24400f12c150529a5ec55060577f87/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html

Status: Fixed (was: Started)
 Issue 896595  has been merged into this issue.

Sign in to add a comment