New issue
Advanced search Search tips

Issue 896493 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 18
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored



Sign in to add a comment

SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored is flaky

Project Member Reported by Findit, Oct 17

Issue description


Flaky test: SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=409c9e4be52bdd10
Test output log: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44415
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I0d6ad27a4e03d0128970af6e22d2a40a62d0601b
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKlAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0NDE1L2Jyb3dzZXJfdGVzdHMvVTJGMlpVTmhjbVJDZFdKaWJHVldhV1YzYzBaMWJHeEdiM0p0UW5KdmQzTmxjbFJsYzNRdVUzUnlhV3RsUkdGMFlXSmhjMlZmVEc5allXeGZRV1JrVTNSeWFXdGxTV1pDZFdKaWJHVkpaMjV2Y21WawwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKlAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0NDE1L2Jyb3dzZXJfdGVzdHMvVTJGMlpVTmhjbVJDZFdKaWJHVldhV1YzYzBaMWJHeEdiM0p0UW5KdmQzTmxjbFJsYzNRdVUzUnlhV3RsUkdGMFlXSmhjMlZmVEc5allXeGZRV1JrVTNSeWFXdGxTV1pDZFdKaWJHVkpaMjV2Y21WawwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b

commit df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Oct 17 22:54:11 2018

Revert "[Autofill] Add strikes when credit card save ignored/denied/fails"

This reverts commit d82a26bd00c46d54e07521af6fb56a9348edae90.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 600490 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDgyYTI2YmQwMGM0NmQ1NGUwNzUyMWFmNmZiNTZhOTM0OGVkYWU5MAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/44415

Sample Failed Step: browser_tests

Sample Flaky Test: SaveCardBubbleViewsFullFormBrowserTest.StrikeDatabase_Local_AddStrikeIfBubbleIgnored

Original change's description:
> [Autofill] Add strikes when credit card save ignored/denied/fails
> 
> (When a card accrues 3 strikes, future offers to save for that card
> should show the omnibox save icon, but NOT pop up the bubble.
> On Android, no offer to save is shown at all.)
> 
> Bug: 884817
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: I0d6ad27a4e03d0128970af6e22d2a40a62d0601b
> Reviewed-on: https://chromium-review.googlesource.com/c/1269524
> Commit-Queue: Jared Saul <jsaul@google.com>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600490}

Change-Id: I7d0536b919212228db19f87c6cc09358928ffd35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 884817,  896493 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/c/1287252
Cr-Commit-Position: refs/heads/master@{#600583}
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/browser/strike_database.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/core/common/autofill_constants.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.h
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/components/autofill/ios/browser/credit_card_save_manager_test_observer_bridge.mm
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/df2e4163068a0a1876d95b4ae29c1f79a5e5ce7b/ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm

Status: Fixed (was: Untriaged)

Sign in to add a comment