New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896492 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Oct 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Explore sites page overflows on smaller screens and "display large"

Project Member Reported by chili@chromium.org, Oct 17

Issue description

the 4th column "disappears" incompletely, sometimes revealing partial tiles on the right side
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a59b7e53185d6e3e22788c8dd15d798d7d72db1b

commit a59b7e53185d6e3e22788c8dd15d798d7d72db1b
Author: Cathy Li <chili@chromium.org>
Date: Fri Oct 19 19:39:31 2018

[Explore sites]: Use TileGridLayout from suggestions to render ESP grid.

This fixes issues on smaller screens or "Large" displays where the 4th column is cut off

Bug:  896492 
Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b
Reviewed-on: https://chromium-review.googlesource.com/c/1287253
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601258}
[modify] https://crrev.com/a59b7e53185d6e3e22788c8dd15d798d7d72db1b/chrome/android/java/res/layout/explore_sites_category_card_view.xml
[modify] https://crrev.com/a59b7e53185d6e3e22788c8dd15d798d7d72db1b/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/a59b7e53185d6e3e22788c8dd15d798d7d72db1b/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/a59b7e53185d6e3e22788c8dd15d798d7d72db1b/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java

Labels: Merge-Request-71
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 20

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Issue 897393 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 22

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/713c43622b758bf6ea31e7ee89bfb836ad3c9fae

commit 713c43622b758bf6ea31e7ee89bfb836ad3c9fae
Author: Cathy Li <chili@chromium.org>
Date: Mon Oct 22 19:01:03 2018

[Explore sites]: Use TileGridLayout from suggestions to render ESP grid.

This fixes issues on smaller screens or "Large" displays where the 4th column is cut off

Bug:  896492 
Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b
Reviewed-on: https://chromium-review.googlesource.com/c/1287253
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601258}(cherry picked from commit a59b7e53185d6e3e22788c8dd15d798d7d72db1b)
Reviewed-on: https://chromium-review.googlesource.com/c/1294473
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#236}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/res/layout/explore_sites_category_card_view.xml
[modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/res/layout/explore_sites_tile_view.xml
[modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/713c43622b758bf6ea31e7ee89bfb836ad3c9fae

Commit: 713c43622b758bf6ea31e7ee89bfb836ad3c9fae
Author: chili@chromium.org
Commiter: chili@chromium.org
Date: 2018-10-22 19:01:03 +0000 UTC

[Explore sites]: Use TileGridLayout from suggestions to render ESP grid.

This fixes issues on smaller screens or "Large" displays where the 4th column is cut off

Bug:  896492 
Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b
Reviewed-on: https://chromium-review.googlesource.com/c/1287253
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601258}(cherry picked from commit a59b7e53185d6e3e22788c8dd15d798d7d72db1b)
Reviewed-on: https://chromium-review.googlesource.com/c/1294473
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#236}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment