Explore sites page overflows on smaller screens and "display large" |
|||||
Issue descriptionthe 4th column "disappears" incompletely, sometimes revealing partial tiles on the right side
,
Oct 19
,
Oct 20
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
Issue 897393 has been merged into this issue.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/713c43622b758bf6ea31e7ee89bfb836ad3c9fae commit 713c43622b758bf6ea31e7ee89bfb836ad3c9fae Author: Cathy Li <chili@chromium.org> Date: Mon Oct 22 19:01:03 2018 [Explore sites]: Use TileGridLayout from suggestions to render ESP grid. This fixes issues on smaller screens or "Large" displays where the 4th column is cut off Bug: 896492 Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b Reviewed-on: https://chromium-review.googlesource.com/c/1287253 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601258}(cherry picked from commit a59b7e53185d6e3e22788c8dd15d798d7d72db1b) Reviewed-on: https://chromium-review.googlesource.com/c/1294473 Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#236} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/res/layout/explore_sites_category_card_view.xml [modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/res/layout/explore_sites_tile_view.xml [modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/713c43622b758bf6ea31e7ee89bfb836ad3c9fae/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/713c43622b758bf6ea31e7ee89bfb836ad3c9fae Commit: 713c43622b758bf6ea31e7ee89bfb836ad3c9fae Author: chili@chromium.org Commiter: chili@chromium.org Date: 2018-10-22 19:01:03 +0000 UTC [Explore sites]: Use TileGridLayout from suggestions to render ESP grid. This fixes issues on smaller screens or "Large" displays where the 4th column is cut off Bug: 896492 Change-Id: I3d3600bdfec5665f843840f59bba5e0adb5b9a7b Reviewed-on: https://chromium-review.googlesource.com/c/1287253 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601258}(cherry picked from commit a59b7e53185d6e3e22788c8dd15d798d7d72db1b) Reviewed-on: https://chromium-review.googlesource.com/c/1294473 Reviewed-by: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#236} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 19