[Downloads Home] Add the download settings IPH |
||||||
Issue descriptionAdd back the download settings IPH which was missed from the ToobarCoordinator
,
Oct 20
,
Oct 21
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 21
,
Oct 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b commit 9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b Author: Shakti Sahu <shaktisahu@chromium.org> Date: Sun Oct 21 03:49:26 2018 Download Home : Added back the download settings IPH Bug: 896480 Change-Id: I9a0b2b041991a1dbcc63f3190df4dec650f4c25a Reviewed-on: https://chromium-review.googlesource.com/c/1286826 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601375}(cherry picked from commit afd0fb4b16a6d425403ce11bbbeb78e4fb2ef83a) Reviewed-on: https://chromium-review.googlesource.com/c/1293039 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#187} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b/chrome/android/java/src/org/chromium/chrome/browser/download/home/toolbar/ToolbarCoordinator.java [add] https://crrev.com/9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b/chrome/android/java/src/org/chromium/chrome/browser/download/home/toolbar/ToolbarUtils.java [modify] https://crrev.com/9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java [modify] https://crrev.com/9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b/chrome/android/java_sources.gni
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b Commit: 9320eabcc4e5e8736a03a7e49de8621c0f5f9d5b Author: shaktisahu@chromium.org Commiter: shaktisahu@chromium.org Date: 2018-10-21 03:49:26 +0000 UTC Download Home : Added back the download settings IPH Bug: 896480 Change-Id: I9a0b2b041991a1dbcc63f3190df4dec650f4c25a Reviewed-on: https://chromium-review.googlesource.com/c/1286826 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601375}(cherry picked from commit afd0fb4b16a6d425403ce11bbbeb78e4fb2ef83a) Reviewed-on: https://chromium-review.googlesource.com/c/1293039 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#187} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 20