New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: 2019-02-01
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 896479: Refactor and clean up clipboard/drag and drop codebase

Reported by huangdarwin@chromium.org, Oct 17 Project Member

Issue description

Tracking bug for generalized refactoring/cleanup. Will likely concentrate in clipboard/drag and drop.
 

Comment 2 by bugdroid1@chromium.org, Oct 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8930b704304608eda1652261e162c14bf627540e

commit 8930b704304608eda1652261e162c14bf627540e
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Tue Oct 30 03:01:19 2018

Refactor: Adding comments to explain terms.

Added comments to explain what KURL and GURL stand for.

Mostly just trying to make clear things that I was confused about when first parsing the code

Bug: 896479
Change-Id: Ic6857750884a2954ed32f5d4af3c32ff3356377b
Reviewed-on: https://chromium-review.googlesource.com/c/1300681
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603753}
[modify] https://crrev.com/8930b704304608eda1652261e162c14bf627540e/third_party/blink/renderer/core/input/event_handler.h
[modify] https://crrev.com/8930b704304608eda1652261e162c14bf627540e/third_party/blink/renderer/platform/weborigin/kurl.h
[modify] https://crrev.com/8930b704304608eda1652261e162c14bf627540e/url/README.md
[modify] https://crrev.com/8930b704304608eda1652261e162c14bf627540e/url/gurl.h

Comment 3 by bugdroid1@chromium.org, Oct 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f0d0c8530840f17718c7185ad15d479fa38f4d

commit 48f0d0c8530840f17718c7185ad15d479fa38f4d
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Wed Oct 31 19:40:05 2018

Renderer: Refactoring Frame DocumentAttached/DidAttachDocument (and spellfix)

- Renamed DocumentAttached() to DidAttachDocument() so that function names better express what the function is trying to accomplish
- Remove extraneous GetDocument() calls
- Spellfixing

"I think that DocumentAttached(..) is misleading, since it seems to imply that it's going to find out whether a document is attached and return a boolean representing that. Instead, it's in essence attaching to a document (or rather the document’s context, but with some clearing and such going on as well). Therefore, I'm thinking of perhaps renaming DocumentAttached(..) to AttachDocument(..) or AttachToDocument(..) in another CL." -Darwin in another CL

Bug: 896479
Change-Id: I4b9e2cd9a998f2b18acdbca9e2339c7ca5a124e8
Reviewed-on: https://chromium-review.googlesource.com/c/1300680
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604366}
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/extensions/common/user_script.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/frame_selection.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/frame_selection.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/ime/input_method_controller.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/ime/input_method_controller.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/selection_editor.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/selection_editor.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/spellcheck/idle_spell_check_controller.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/spellcheck/idle_spell_check_controller.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/spellcheck/spell_checker.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/spellcheck/spell_checker.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller.h
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/48f0d0c8530840f17718c7185ad15d479fa38f4d/third_party/blink/renderer/core/frame/local_frame.h

Comment 4 by bugdroid1@chromium.org, Dec 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ffab8656b43fd2a6b49c0bc62dc97bc26ebde5

commit 87ffab8656b43fd2a6b49c0bc62dc97bc26ebde5
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Sat Dec 08 01:52:47 2018

DataTransfer: Generalized refactoring (range-based for loops, function logic)

- range-based for loops
- spelling
- simplifying function logic

Bug: 896479
Change-Id: I32d703d5f2aacb163bf6818d3dc0abf993f06b95
Reviewed-on: https://chromium-review.googlesource.com/c/1341145
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614909}
[modify] https://crrev.com/87ffab8656b43fd2a6b49c0bc62dc97bc26ebde5/content/renderer/drop_data_builder.cc
[modify] https://crrev.com/87ffab8656b43fd2a6b49c0bc62dc97bc26ebde5/third_party/blink/renderer/core/clipboard/data_transfer.cc
[modify] https://crrev.com/87ffab8656b43fd2a6b49c0bc62dc97bc26ebde5/third_party/blink/renderer/core/clipboard/system_clipboard.cc

Comment 5 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4b54662bdfc70499604ba43bd52cdb71406e15f

commit b4b54662bdfc70499604ba43bd52cdb71406e15f
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Mon Dec 10 22:37:12 2018

X Selection: Refactoring (range-based for loops, NULL to nullptr)

- Only in ui/base/x/*
- Updated X Selection code to use range-based for loops.
- Updated uses of NULL to nullptr
- `git cl format` also updated some formatting.

Bug: 896479
Change-Id: I5fea75df87872341d726e2f7bbeb0d93c0a89b61
Reviewed-on: https://chromium-review.googlesource.com/c/1368944
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615287}
[modify] https://crrev.com/b4b54662bdfc70499604ba43bd52cdb71406e15f/ui/base/x/selection_owner.cc
[modify] https://crrev.com/b4b54662bdfc70499604ba43bd52cdb71406e15f/ui/base/x/selection_requestor.cc
[modify] https://crrev.com/b4b54662bdfc70499604ba43bd52cdb71406e15f/ui/base/x/selection_requestor_unittest.cc
[modify] https://crrev.com/b4b54662bdfc70499604ba43bd52cdb71406e15f/ui/base/x/selection_utils.cc
[modify] https://crrev.com/b4b54662bdfc70499604ba43bd52cdb71406e15f/ui/base/x/x11_util.cc

Comment 7 by bugdroid1@chromium.org, Dec 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e85e342874b5404e943bda8beaa22ed09b8f6d

commit 19e85e342874b5404e943bda8beaa22ed09b8f6d
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Thu Dec 13 18:58:17 2018

Refactor: Reformat background_scheduler to make functions more clearly part of namespace

They previously looked a bit like class member functions, so I was hoping this change could make this more clear.

Bug: 896479
Change-Id: I797008b96cdfe9c97f72d5818d1c2acd7c57d341
Reviewed-on: https://chromium-review.googlesource.com/c/1374694
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616379}
[modify] https://crrev.com/19e85e342874b5404e943bda8beaa22ed09b8f6d/third_party/blink/renderer/platform/scheduler/common/background_scheduler.cc

Comment 8 by bugdroid1@chromium.org, Dec 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7771154114bde9d8ee997bc528388b1dc28a912

commit c7771154114bde9d8ee997bc528388b1dc28a912
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Tue Dec 18 22:10:34 2018

Refactor: Spellfix to misspellings of "performance"

Bug: 896479
Change-Id: Ib1609f6f23ddf63b8a5c110c7f0280b117ed54c5
Reviewed-on: https://chromium-review.googlesource.com/c/1373252
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617648}
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/chrome/android/java/src/org/chromium/chrome/browser/suggestions/README.md
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/chrome/browser/resources/chromeos/login/oobe_screen.css
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/chrome/browser/resources/chromeos/zip_archiver/cpp/volume_archive.h
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/chrome/browser/resources/chromeos/zip_archiver/unpacker-test/cpp/volume_archive_libarchive_read_test.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/chrome/browser/task_manager/providers/child_process_task_unittest.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/media/base/video_bitrate_allocation.h
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/media/formats/mp4/box_reader.h
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/perf_tests/speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/renderer/core/frame/window_or_worker_global_scope.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/renderer/modules/service_worker/service_worker_module_tree_client.cc
[delete] https://crrev.com/27a599e5b699c6e889b6b0cb6a3162e55e104c0d/third_party/blink/web_tests/http/tests/devtools/console/console-format-perfomance-expected.txt
[add] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/web_tests/http/tests/devtools/console/console-format-performance-expected.txt
[rename] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/web_tests/http/tests/devtools/console/console-format-performance.js
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/web_tests/http/tests/devtools/console/console-top-level-await-expected.txt
[modify] https://crrev.com/c7771154114bde9d8ee997bc528388b1dc28a912/third_party/blink/web_tests/http/tests/devtools/console/console-top-level-await.js

Comment 9 by bugdroid1@chromium.org, Dec 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ed01658f908c631984c97a1bdd6670814be5e4

commit a1ed01658f908c631984c97a1bdd6670814be5e4
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Wed Dec 19 21:47:57 2018

Documentation: Add comments to describe and recommend BlobReader/FileReader

Bug: 896479
Change-Id: Idc364a4fc9340ad19d121973492a60b9e9e3f905
Reviewed-on: https://chromium-review.googlesource.com/c/1369046
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617965}
[modify] https://crrev.com/a1ed01658f908c631984c97a1bdd6670814be5e4/storage/browser/blob/README.md
[modify] https://crrev.com/a1ed01658f908c631984c97a1bdd6670814be5e4/storage/browser/blob/blob_reader.h
[modify] https://crrev.com/a1ed01658f908c631984c97a1bdd6670814be5e4/third_party/blink/renderer/core/fileapi/file_reader_loader_client.h

Comment 10 by bugdroid1@chromium.org, Dec 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39c98a75eb0ba353cc3908ae0024f28cae85815f

commit 39c98a75eb0ba353cc3908ae0024f28cae85815f
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Thu Dec 27 00:35:04 2018

Async Clipboard: Refactor tests to use arrow functions

Bug: 896479
Change-Id: I2a9cd18fa812ff9bd9f8b51923b4fe373f593582
Reviewed-on: https://chromium-review.googlesource.com/c/1391408
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618984}
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/async-interfaces.https.html
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/async-navigator-clipboard-basics.https.html
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/async-write-dttext-read-dttext-manual.https.html
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/async-write-dttext-read-text-manual.https.html
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/async-write-text-read-dttext-manual.https.html
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/async-write-text-read-text-manual.https.html
[modify] https://crrev.com/39c98a75eb0ba353cc3908ae0024f28cae85815f/third_party/blink/web_tests/external/wpt/clipboard-apis/clipboard-events-synthetic.html

Comment 11 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aad703f05f4435812ea496bc29d47c1e9de0966

commit 7aad703f05f4435812ea496bc29d47c1e9de0966
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Tue Jan 08 00:00:32 2019

Async Clipboard: clipboard-basics layout tests async/await syntax

- update async-navigator-clipboard-basics.https.html to use async/await syntax

Bug: 896479
Change-Id: I5aba587862ebe450ff2c0f61755e7e11dec6aecc
Reviewed-on: https://chromium-review.googlesource.com/c/1399510
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620540}
[modify] https://crrev.com/7aad703f05f4435812ea496bc29d47c1e9de0966/third_party/blink/web_tests/external/wpt/clipboard-apis/async-navigator-clipboard-basics.https.html

Comment 12 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8cd381885a79bfe374dddcfba367a9143f89bcc

commit a8cd381885a79bfe374dddcfba367a9143f89bcc
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Thu Jan 10 11:05:10 2019

Docs: Fixing some markdown docs issues

- Fixing broken links.
- Fixed spelling.

Bug: 896479
Change-Id: Id063538cbade42363eebf327afa0b6118123558f
Reviewed-on: https://chromium-review.googlesource.com/c/1401510
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621539}
[modify] https://crrev.com/a8cd381885a79bfe374dddcfba367a9143f89bcc/docs/README.md
[modify] https://crrev.com/a8cd381885a79bfe374dddcfba367a9143f89bcc/docs/documentation_guidelines.md
[modify] https://crrev.com/a8cd381885a79bfe374dddcfba367a9143f89bcc/docs/testing/web_tests.md

Comment 13 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92172a72de0cce30bd08e2bcdb7037bb55f5a66

commit c92172a72de0cce30bd08e2bcdb7037bb55f5a66
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Thu Jan 10 19:28:56 2019

Async Clipboard: Add reviewers for testing

Bug: 896479
Change-Id: Ibe43844a9baf4f6789092315dc922ea7f60c8e88
Reviewed-on: https://chromium-review.googlesource.com/c/1404483
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621704}
[modify] https://crrev.com/c92172a72de0cce30bd08e2bcdb7037bb55f5a66/third_party/blink/web_tests/external/wpt/clipboard-apis/OWNERS

Comment 14 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1

commit 725f0f499f116c2ffdb54aa73bb362a49e3ebcf1
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Sat Jan 12 02:44:19 2019

Async Clipboard: Automate/duplicate WPT tests

- Having WPT tests run on buildbots automatically should increase velocity
(no longer need to run them manually and reduce chance of regressions
- Note to update corresponding tests so that buildbots and web platform are both
up to date.

Bug: 896479
Change-Id: Ic2dcbe46fac51dcd1ef01af7f5ed0f360a3ee00f
Reviewed-on: https://chromium-review.googlesource.com/c/1404401
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622275}
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/OWNERS
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/README.md
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/async-navigator-clipboard-basics.https.html
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/async-write-dttext-read-dttext.https.html
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/async-write-dttext-read-text.https.html
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/async-write-text-read-dttext.https.html
[add] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/async-write-text-read-text.https.html
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/readtext-denied.https-expected.txt
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/readtext-denied.https.html
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/readtext-granted.https-expected.txt
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/readtext-granted.https.html
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/writetext-denied.https-expected.txt
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/writetext-denied.https.html
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/writetext-granted.https-expected.txt
[rename] https://crrev.com/725f0f499f116c2ffdb54aa73bb362a49e3ebcf1/third_party/blink/web_tests/clipboard/async-clipboard/writetext-granted.https.html

Comment 15 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/131f630e2cffdf9d7d4fc818c0f6eb6740c589c6

commit 131f630e2cffdf9d7d4fc818c0f6eb6740c589c6
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Tue Jan 15 00:30:31 2019

ImageEncoder: Make implicit cast explicit

- Implicit cast from size_t (uint_64_t) to wtf_size_t (uint_32_t) loses precision. Let's document this and make it clear.

../../third_party/blink/renderer/platform/image-encoders/image_encoder.h:26:48: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'WTF::wtf_size_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
    dst_->Append((const unsigned char*)buffer, size);
          ~~~~~~                               ^~~~

Bug: 896479
Change-Id: Iadedc5c3c4ed1de57cadcc2783a0eb42d64cbd76
Reviewed-on: https://chromium-review.googlesource.com/c/1409808
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622651}
[modify] https://crrev.com/131f630e2cffdf9d7d4fc818c0f6eb6740c589c6/third_party/blink/renderer/platform/image-encoders/image_encoder.h

Comment 16 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2f4a5e9df2a2cefba7afb3192a84c9a4757bff

commit 5f2f4a5e9df2a2cefba7afb3192a84c9a4757bff
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Thu Jan 17 23:09:30 2019

System Clipboard: Move checks from system_clipboard over to ui/base clipboard

- Validity checks for items being placed onto the clipboard should be made in
a consistent location.
- Most similar checks, depending only on the SkBitmap properties, already occur
in ui/base clipboard.
- Therefore, I propose to move these checks from system clipboard over to
ui/base clipboard. Text checks are generally already consistent with this,
only checking for more high level changes like the type of text, etc in system
clipboard.
- We can remove the check for SkBitmap::isNull(), because
SkBitmap::drawsNothing() { return this->empty() || this->isNull(); }, effectively
meaning the case was already covered
- This does mean we may pass a empty/invalid SkBitmap through mojo, wasting
the overhead of a mojo call whenever we try to
SystemClipboard::WriteImage(empty SkBitmap). However, I think this should be okay,
given that this should be a fairly lightweight and infrequent call. If not,
I'd propose moving these checks up from ui/base to system_clipboard instead.

Bug: 896479
Change-Id: I5129db6606bc85385aec9d56f34cf9eab0fac778
Reviewed-on: https://chromium-review.googlesource.com/c/1413970
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623892}
[modify] https://crrev.com/5f2f4a5e9df2a2cefba7afb3192a84c9a4757bff/third_party/blink/renderer/core/clipboard/system_clipboard.cc
[modify] https://crrev.com/5f2f4a5e9df2a2cefba7afb3192a84c9a4757bff/third_party/blink/renderer/core/clipboard/system_clipboard.h
[modify] https://crrev.com/5f2f4a5e9df2a2cefba7afb3192a84c9a4757bff/ui/base/clipboard/scoped_clipboard_writer.cc

Comment 17 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac3471509589fb28605e96de55c6f028471ba48

commit dac3471509589fb28605e96de55c6f028471ba48
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Fri Jan 18 23:08:28 2019

Async Clipboard: Updating test harness (js-test.js -> testharness.js)

- Tests much shorter
- Tests work for where permission is granted, but don't yet work where
permissions are denied.

Bug: 896479
Change-Id: I421c5be5060f8f772b2a0b64e159d3ccbfd120ab
Reviewed-on: https://chromium-review.googlesource.com/c/1410181
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624339}
[delete] https://crrev.com/e5fccdd4d5352704539b1a1618cf62949079e75e/third_party/blink/web_tests/clipboard/async-clipboard/readtext-denied.https-expected.txt
[modify] https://crrev.com/dac3471509589fb28605e96de55c6f028471ba48/third_party/blink/web_tests/clipboard/async-clipboard/readtext-denied.https.html
[delete] https://crrev.com/e5fccdd4d5352704539b1a1618cf62949079e75e/third_party/blink/web_tests/clipboard/async-clipboard/readtext-granted.https-expected.txt
[modify] https://crrev.com/dac3471509589fb28605e96de55c6f028471ba48/third_party/blink/web_tests/clipboard/async-clipboard/readtext-granted.https.html
[delete] https://crrev.com/e5fccdd4d5352704539b1a1618cf62949079e75e/third_party/blink/web_tests/clipboard/async-clipboard/writetext-denied.https-expected.txt
[modify] https://crrev.com/dac3471509589fb28605e96de55c6f028471ba48/third_party/blink/web_tests/clipboard/async-clipboard/writetext-denied.https.html
[delete] https://crrev.com/e5fccdd4d5352704539b1a1618cf62949079e75e/third_party/blink/web_tests/clipboard/async-clipboard/writetext-granted.https-expected.txt
[modify] https://crrev.com/dac3471509589fb28605e96de55c6f028471ba48/third_party/blink/web_tests/clipboard/async-clipboard/writetext-granted.https.html

Comment 18 by bugdroid1@chromium.org, Jan 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7

commit ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Sat Jan 19 01:33:46 2019

Async Clipboard: Automate writeImage/readImage test

- Automate tests for writeImage/readImage by duplicating
web_tests/external/wpt/clipboard-apis/async-write-image-read-image-manual.https.html
to a directory allowing Chrome-specific permissions-helper.js (and fetching via
http server).
- Create appropriate README/OWNERS file for new directory.
- Update web_tests/clipboard/async-clipboard/README.md with new info regarding
testrunner.
- Update external/wpt writeImage/readImage test with simplification found
through this CL.
- Follow-up work: add `if(testRunner)` to automated tests so that they can be run
manually.

Bug: 896479
Change-Id: I8b2b27f6fcc4abc9e11169c196eee1863d80fd82
Reviewed-on: https://chromium-review.googlesource.com/c/1413023
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624401}
[modify] https://crrev.com/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7/third_party/blink/web_tests/clipboard/async-clipboard/README.md
[modify] https://crrev.com/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7/third_party/blink/web_tests/external/wpt/clipboard-apis/async-write-image-read-image-manual.https.html
[add] https://crrev.com/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7/third_party/blink/web_tests/http/tests/clipboard/OWNERS
[add] https://crrev.com/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7/third_party/blink/web_tests/http/tests/clipboard/README.md
[add] https://crrev.com/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7/third_party/blink/web_tests/http/tests/clipboard/async-write-image-read-image.html
[add] https://crrev.com/ff0ddd7f6bfba9f1f1b19c2e3db0819fe49a3ac7/third_party/blink/web_tests/http/tests/clipboard/resources/greenbox.png

Comment 19 by bugdroid, Jan 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef571a84a1124261719698dd2b3f2531f6f5e2b3

commit ef571a84a1124261719698dd2b3f2531f6f5e2b3
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Mon Jan 28 19:50:40 2019

System Clipboard: Use Range-based For Loops

- Using range-based for loops whenever possible in blink/renderer/core/clipboard/
- No logic changes.

Bug: 896479
Change-Id: I45a38eb0387227a54627fe329178cceec537c2d1
Reviewed-on: https://chromium-review.googlesource.com/c/1427793
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626687}

Comment 20 by monor...@bugs.chromium.org, Feb 1

The NextAction date has arrived: 2019-02-01

Comment 21 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762d7248c097a67e161a5f3aee4ef4437555ecc5

commit 762d7248c097a67e161a5f3aee4ef4437555ecc5
Author: Darwin Huang <huangdarwin@chromium.org>
Date: Thu Feb 07 02:03:26 2019

Refactor: os_exchange_data_provider_win.cc use range-based for loops

- Use range-based for loops
- Update documentation links
- No logic changes

Bug: 896479
Change-Id: I9ba30494d274d96a045d6ec11668f5554b5ee92c
Reviewed-on: https://chromium-review.googlesource.com/c/1444707
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629834}
[modify] https://crrev.com/762d7248c097a67e161a5f3aee4ef4437555ecc5/ui/base/dragdrop/os_exchange_data_provider_win.cc

Sign in to add a comment