Fix UI Devtools crashes on Windows |
|||||
Issue descriptionWhen running UI Devtools on Windows, we frequently ran into crashes like: aura!std::_Iterator_base12::_Adopt+0xa6 aura!std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<base::internal::UncheckedObserverAdapter> > >::_Vector_const_iterator+0x52 aura!std::vector<base::internal::UncheckedObserverAdapter,std::allocator<base::internal::UncheckedObserverAdapter> >::end+0x54 aura!base::ObserverList<aura::WindowObserver,1,1,base::internal::UncheckedObserverAdapter>::HasObserver+0x5f aura!aura::Window::HasObserver+0x24 aura!aura::WindowObserver::OnObservingWindow+0x2a aura!aura::Window::AddObserver+0x2a chrome_7ffa70010000!ui_devtools::WindowElement::WindowElement+0x99 chrome_7ffa70010000!ui_devtools::DOMAgentAura::CreateChildrenForRoot+0x12e ui_devtools!ui_devtools::DOMAgent::BuildInitialTree+0xec ui_devtools!ui_devtools::DOMAgent::getDocument+0x4a ui_devtools!ui_devtools::protocol::DOM::DispatcherImpl::getDocument+0xb0 ui_devtools!ui_devtools::protocol::DOM::DispatcherImpl::dispatch+0x1bf ui_devtools!ui_devtools::protocol::UberDispatcher::dispatch+0x285 ui_devtools!ui_devtools::UiDevToolsClient::Dispatch+0xef ui_devtools!ui_devtools::UiDevToolsServer::OnWebSocketMessage+0x1e2 network_cpp!network::server::HttpServer::HandleReadResult+0x19c network_cpp!network::server::HttpServer::OnReadable+0x299 network_cpp!base::internal::FunctorTraits<void (network::server::HttpServer::*)(int, unsigned int, const mojo::HandleSignalsState &),void>::Invoke<void (network::server::HttpServer::*)(int, unsigned int, const mojo::HandleSignalsState &),network::server::HttpServer *,const int &,unsigned int,const mojo::HandleSignalsState &>+0x85 network_cpp!base::internal::InvokeHelper<0,void>::MakeItSo<void (network::server::HttpServer::*const &)(int, unsigned int, const mojo::HandleSignalsState &),network::server::HttpServer *,const int &,unsigned int,const mojo::HandleSignalsState &>+0x8f Looks like there were some memory errors. Need to fix this.
,
Oct 18
,
Oct 18
,
Oct 18
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6cca2e3316e1c0a0198cc8659365a08b3b6fa9d commit c6cca2e3316e1c0a0198cc8659365a08b3b6fa9d Author: Wei Li <weili@chromium.org> Date: Mon Oct 22 19:46:04 2018 UIDevTools: Track aura window deletion for cleanup UI DevTools track aura's WindowTreeHost initialization to track all the windows created as root windows. However, we didn't track their deletion for proper cleanup. So it is possible that when we use those root windows to create children and trees, some of them were already released which caused crashes. This CL adds tracking of windows being destroyed, so that we can properly remove the window from our list. BUG= 896470 Change-Id: I5411001c4c30fea6703d76ae6be8bed61259fce7 Reviewed-on: https://chromium-review.googlesource.com/c/1289706 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601692} [modify] https://crrev.com/c6cca2e3316e1c0a0198cc8659365a08b3b6fa9d/components/ui_devtools/views/dom_agent_aura.cc [modify] https://crrev.com/c6cca2e3316e1c0a0198cc8659365a08b3b6fa9d/components/ui_devtools/views/dom_agent_aura.h
,
Oct 22
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by weili@chromium.org
, Oct 17