New issue
Advanced search Search tips

Issue 896458 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Temporarily always allow fingerprint on nocturne

Project Member Reported by jdufault@chromium.org, Oct 17

Issue description

Fingerprint being allowed is controlled by policy. During dogfood we want to always allow it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92eb6fcb9a48ca9d980d89b3194ad196b92195b5

commit 92eb6fcb9a48ca9d980d89b3194ad196b92195b5
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Oct 17 23:26:55 2018

cros: Temporarily allow fingerprint on nocturne.

Bug:  896458 
Change-Id: I774285cd49260e227a57cd8d786ba2b31efd08ad
Reviewed-on: https://chromium-review.googlesource.com/c/1286666
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600594}
[modify] https://crrev.com/92eb6fcb9a48ca9d980d89b3194ad196b92195b5/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7168d6aaefe0afb6cb3fcaa01a6db7429d3186e1

commit 7168d6aaefe0afb6cb3fcaa01a6db7429d3186e1
Author: Jacob Dufault <jdufault@chromium.org>
Date: Thu Oct 18 17:03:22 2018

Revert "cros: Temporarily allow fingerprint on nocturne."

This reverts commit 92eb6fcb9a48ca9d980d89b3194ad196b92195b5.

Reason for revert: Policy change got approval which makes this CL unnecessary 

Original change's description:
> cros: Temporarily allow fingerprint on nocturne.
> 
> Bug:  896458 
> Change-Id: I774285cd49260e227a57cd8d786ba2b31efd08ad
> Reviewed-on: https://chromium-review.googlesource.com/c/1286666
> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600594}

TBR=jdufault@chromium.org,wzang@chromium.org

Change-Id: I39013e6fc3a62f96a792865b43a9270b9fd61069
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  896458 
Reviewed-on: https://chromium-review.googlesource.com/c/1289074
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600804}
[modify] https://crrev.com/7168d6aaefe0afb6cb3fcaa01a6db7429d3186e1/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.cc

Status: Fixed (was: Started)
Labels: -M-71 M-72

Sign in to add a comment