Pull should_try check for TCPC into aux fw_ops driver |
||||
Issue descriptionWe added the ps8751_should_try_upgrade() method in the ps8751.c driver in depthcharge to prevent a boot loop for devices that were missing a daughter card. The octopus board file made use of this function. Other boards have run into this boot-loop scenario and did not know about the new function. We should add a new driver method to VbootAuxFwOps that performs this check for all TCPCs and skips the upgrade if the TCPC isn't present.
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/aa7bf63978082e4e55c0e11836964d8996f22c53 commit aa7bf63978082e4e55c0e11836964d8996f22c53 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 08:33:58 2018 test/ec_sync_test: Add mock test for VB_AUX_FW_NO_DEVICE severity Add a mock test to handle VB_AUX_FW_NO_DEVICE severity BUG= chromium:896451 BRANCH=None TEST=/mnt/host/source/chromite/bin/cros_run_unit_tests --board=octopus --packages=chromeos-base/vboot_reference Change-Id: Ifdabdf3cee1130a8c853d57c278f0e557ebbb96f Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299994 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> [modify] https://crrev.com/aa7bf63978082e4e55c0e11836964d8996f22c53/tests/ec_sync_tests.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/bbf273d4618c30880843cf58f802a8acb3d4f758 commit bbf273d4618c30880843cf58f802a8acb3d4f758 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 19:23:07 2018 drivers/ec/ps8751: Perform lazy evaluation of device status Do not check the status of device during registration. Instead perform a lazy evaluation of device status when the registered device is accessed. BUG= chromium:896451 BUG=b:112306866 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Iaae538ad0f59020a41be24349b8caf8b9f7d92f0 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1289778 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> [modify] https://crrev.com/bbf273d4618c30880843cf58f802a8acb3d4f758/src/board/octopus/board.c [modify] https://crrev.com/bbf273d4618c30880843cf58f802a8acb3d4f758/src/drivers/ec/ps8751/ps8751.c [modify] https://crrev.com/bbf273d4618c30880843cf58f802a8acb3d4f758/src/drivers/ec/ps8751/ps8751.h [modify] https://crrev.com/bbf273d4618c30880843cf58f802a8acb3d4f758/src/board/grunt/board.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/94789c61827933fe91a1cf10464a1fd7d0a0761c commit 94789c61827933fe91a1cf10464a1fd7d0a0761c Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 19:23:06 2018 drivers/ec/vboot_aux_fw: Handle VB_AUX_FW_NO_DEVICE update severity There is no need to protect a registered device if the device is not present at run-time. Update vboot_aux_fw driver to handle the device not present scenario. CQ-DEPEND=CL:1299993 BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Ida8dad2f177a9c5e332924d7ef8ecdabed07b7fd Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299900 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> [modify] https://crrev.com/94789c61827933fe91a1cf10464a1fd7d0a0761c/src/drivers/ec/vboot_aux_fw.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/d43ba5173344d76ec0024d1e11ea8be4135a5cd5 commit d43ba5173344d76ec0024d1e11ea8be4135a5cd5 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 19:23:06 2018 drivers/ec/ps8751: Move ps8751_should_try_upgrade() around Move the ps8751_should_try_upgrade function around so as to avoid a forward declaration in the follow-up patch. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: I7b02d610826e4826945ff2f9e10417493f6f3d58 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1313230 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> [modify] https://crrev.com/d43ba5173344d76ec0024d1e11ea8be4135a5cd5/src/drivers/ec/ps8751/ps8751.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/cc28316aec3c81f10b53c278138d5ec097d3a120 commit cc28316aec3c81f10b53c278138d5ec097d3a120 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 19:23:06 2018 drivers/ec/ps8751: Return more granular info in capture_device_id Currently capture_device_id returns success or failure after querying EC for PD chip info. Update that function to return different states of the device. The different states include: missing device, device is not a parade chip, device is in corrupted state and device is in good state. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Id8d1c3abfcd8911ec2fcae569f1ac1766adb0c8a Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1320152 Reviewed-by: Jett Rink <jettrink@chromium.org> [modify] https://crrev.com/cc28316aec3c81f10b53c278138d5ec097d3a120/src/drivers/ec/ps8751/ps8751.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/1558aae4562b2bb00411a9d22c3d9e9f531cd8e0 commit 1558aae4562b2bb00411a9d22c3d9e9f531cd8e0 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 23:15:40 2018 drivers/ec/vboot_aux_fw: Handle VB_AUX_FW_NO_DEVICE update severity There is no need to protect a registered device if the device is not present at run-time. Update vboot_aux_fw driver to handle the device not present scenario. CQ-DEPEND=CL:1299993 BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Ida8dad2f177a9c5e332924d7ef8ecdabed07b7fd Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299900 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1351844 Reviewed-by: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/1558aae4562b2bb00411a9d22c3d9e9f531cd8e0/src/drivers/ec/vboot_aux_fw.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/9615a8ab8baf7d6d808dad8e070ecd4fcab3f274 commit 9615a8ab8baf7d6d808dad8e070ecd4fcab3f274 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 23:15:47 2018 drivers/ec/ps8751: Move ps8751_should_try_upgrade() around Move the ps8751_should_try_upgrade function around so as to avoid a forward declaration in the follow-up patch. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: I7b02d610826e4826945ff2f9e10417493f6f3d58 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1313230 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1351845 Reviewed-by: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/9615a8ab8baf7d6d808dad8e070ecd4fcab3f274/src/drivers/ec/ps8751/ps8751.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/7a5e8ac3af2a0a107c3b8d3a2ad79886c9373286 commit 7a5e8ac3af2a0a107c3b8d3a2ad79886c9373286 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 23:15:57 2018 drivers/ec/ps8751: Return more granular info in capture_device_id Currently capture_device_id returns success or failure after querying EC for PD chip info. Update that function to return different states of the device. The different states include: missing device, device is not a parade chip, device is in corrupted state and device is in good state. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Id8d1c3abfcd8911ec2fcae569f1ac1766adb0c8a Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1320152 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1351846 Reviewed-by: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/7a5e8ac3af2a0a107c3b8d3a2ad79886c9373286/src/drivers/ec/ps8751/ps8751.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/420e943a00915035c8908695e97e253ae0f4636b commit 420e943a00915035c8908695e97e253ae0f4636b Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 23:16:06 2018 drivers/ec/ps8751: Perform lazy evaluation of device status Do not check the status of device during registration. Instead perform a lazy evaluation of device status when the registered device is accessed. BUG= chromium:896451 BUG=b:112306866 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Iaae538ad0f59020a41be24349b8caf8b9f7d92f0 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1289778 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1351847 Reviewed-by: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/420e943a00915035c8908695e97e253ae0f4636b/src/board/octopus/board.c [modify] https://crrev.com/420e943a00915035c8908695e97e253ae0f4636b/src/drivers/ec/ps8751/ps8751.c [modify] https://crrev.com/420e943a00915035c8908695e97e253ae0f4636b/src/drivers/ec/ps8751/ps8751.h [modify] https://crrev.com/420e943a00915035c8908695e97e253ae0f4636b/src/board/grunt/board.c
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/63be7c35d788405c0eb851416f5bef9e7185183c commit 63be7c35d788405c0eb851416f5bef9e7185183c Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Tue Nov 27 23:18:37 2018 vboot_api: Add new VB_AUX_FW_NO_DEVICE update severity There is a possibility that a registered device is not present at run-time and this scenario needs to be handled a little different. Add a new update severity to handle this situation. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: I8a2044ce6a10fe611ee1f47262a7b54598a53ce3 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299993 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1352629 Reviewed-by: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/63be7c35d788405c0eb851416f5bef9e7185183c/firmware/include/vboot_api.h
,
Nov 28
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/2269b3bccb7a7d73eb2c7c63b45a32849a4e75d0 commit 2269b3bccb7a7d73eb2c7c63b45a32849a4e75d0 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Fri Nov 30 15:58:20 2018 drivers/ec/vboot_aux_fw: Handle VB_AUX_FW_NO_DEVICE update severity There is no need to protect a registered device if the device is not present at run-time. Update vboot_aux_fw driver to handle the device not present scenario. CQ-DEPEND=CL:1299993 BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Ida8dad2f177a9c5e332924d7ef8ecdabed07b7fd Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299900 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1355463 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> [modify] https://crrev.com/2269b3bccb7a7d73eb2c7c63b45a32849a4e75d0/src/drivers/ec/vboot_aux_fw.c
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/1c53780265ff26f4d3f8336cdda1cce0a9832099 commit 1c53780265ff26f4d3f8336cdda1cce0a9832099 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Fri Nov 30 15:58:43 2018 drivers/ec/ps8751: Move ps8751_should_try_upgrade() around Move the ps8751_should_try_upgrade function around so as to avoid a forward declaration in the follow-up patch. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: I7b02d610826e4826945ff2f9e10417493f6f3d58 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1313230 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1355464 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> [modify] https://crrev.com/1c53780265ff26f4d3f8336cdda1cce0a9832099/src/drivers/ec/ps8751/ps8751.c
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/65d11d9dedb7b897f1fa427b385152a3bee4b744 commit 65d11d9dedb7b897f1fa427b385152a3bee4b744 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Fri Nov 30 16:00:21 2018 vboot_api: Add new VB_AUX_FW_NO_DEVICE update severity There is a possibility that a registered device is not present at run-time and this scenario needs to be handled a little different. Add a new update severity to handle this situation. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: I8a2044ce6a10fe611ee1f47262a7b54598a53ce3 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299993 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1355747 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> [modify] https://crrev.com/65d11d9dedb7b897f1fa427b385152a3bee4b744/firmware/include/vboot_api.h
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/ee88e5efedd49e80606ef3007ee6b4e3fc3c9b1e commit ee88e5efedd49e80606ef3007ee6b4e3fc3c9b1e Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Fri Nov 30 16:00:29 2018 test/ec_sync_test: Add mock test for VB_AUX_FW_NO_DEVICE severity Add a mock test to handle VB_AUX_FW_NO_DEVICE severity BUG= chromium:896451 BRANCH=None TEST=/mnt/host/source/chromite/bin/cros_run_unit_tests --board=octopus --packages=chromeos-base/vboot_reference Change-Id: Ifdabdf3cee1130a8c853d57c278f0e557ebbb96f Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1299994 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1355748 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> [modify] https://crrev.com/ee88e5efedd49e80606ef3007ee6b4e3fc3c9b1e/tests/ec_sync_tests.c
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/b59c552b72c0e1f89d07a821fa42b24037483015 commit b59c552b72c0e1f89d07a821fa42b24037483015 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Fri Nov 30 18:33:13 2018 drivers/ec/ps8751: Return more granular info in capture_device_id Currently capture_device_id returns success or failure after querying EC for PD chip info. Update that function to return different states of the device. The different states include: missing device, device is not a parade chip, device is in corrupted state and device is in good state. BUG= chromium:896451 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Id8d1c3abfcd8911ec2fcae569f1ac1766adb0c8a Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1320152 Reviewed-by: Jett Rink <jettrink@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1356840 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> [modify] https://crrev.com/b59c552b72c0e1f89d07a821fa42b24037483015/src/drivers/ec/ps8751/ps8751.c
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/9d4d9f8ccb72c34df820d71798563859556a5509 commit 9d4d9f8ccb72c34df820d71798563859556a5509 Author: Karthikeyan Ramasubramanian <kramasub@chromium.org> Date: Fri Nov 30 18:33:14 2018 drivers/ec/ps8751: Perform lazy evaluation of device status Do not check the status of device during registration. Instead perform a lazy evaluation of device status when the registered device is accessed. BUG= chromium:896451 BUG=b:112306866 BRANCH=None TEST=bootup to ChromeOS by connecting and disconnecting the USB daughterboard Change-Id: Iaae538ad0f59020a41be24349b8caf8b9f7d92f0 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1289778 Reviewed-by: Furquan Shaikh <furquan@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Jett Rink <jettrink@chromium.org> Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/1356841 Commit-Queue: Furquan Shaikh <furquan@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Trybot-Ready: Furquan Shaikh <furquan@chromium.org> [modify] https://crrev.com/9d4d9f8ccb72c34df820d71798563859556a5509/src/board/octopus/board.c [modify] https://crrev.com/9d4d9f8ccb72c34df820d71798563859556a5509/src/drivers/ec/ps8751/ps8751.c [modify] https://crrev.com/9d4d9f8ccb72c34df820d71798563859556a5509/src/drivers/ec/ps8751/ps8751.h [modify] https://crrev.com/9d4d9f8ccb72c34df820d71798563859556a5509/src/board/grunt/board.c |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 27