New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896446 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 896467
issue 897407



Sign in to add a comment

split linux-code-coverage-generation into builder and tester

Project Member Reported by robertocn@google.com, Oct 17

Issue description

Tracking bug for splitting the builder into two.
 
Blockedon: 896467
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b3048c2d922c7cdf121b1fcf0feeec8bd1ad11ff

commit b3048c2d922c7cdf121b1fcf0feeec8bd1ad11ff
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Oct 19 23:09:18 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b51151a55248039145473dda9bdd83995695e036

commit b51151a55248039145473dda9bdd83995695e036
Author: Roberto Carrillo <robertocn@google.com>
Date: Sat Oct 20 02:50:31 2018

[code coverage] Split linux-code-coverage-generation in builder/tester.

This change replaces the combined builder for two separate in bot_db.

It follows the change in:
https://chromium-review.googlesource.com/c/chromium/src/+/1289075

Bug:  896446 
Change-Id: I03ca7abca78db55b79ff6bbf1e937c44a8f7152e
R=jbudorick,liaoyuke,stgao
Reviewed-on: https://chromium-review.googlesource.com/c/1289077
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/b51151a55248039145473dda9bdd83995695e036/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18e6fc1da6685a6f619f2de575dbf0d67834856f

commit 18e6fc1da6685a6f619f2de575dbf0d67834856f
Author: Roberto Carrillo <robertocn@google.com>
Date: Sat Oct 20 03:06:45 2018

[code coverage] Split linux-code-coverage-generation as builder/tester.

Since our primary objective is to reduce the cycle time for repo-wide
code coverage reports, we'd do better to have compilation and test
running on separate builders.

R=stgao,liaoyuke,jbudorick

Bug:  896446 
Change-Id: Ic8b7f6319b208405a310694134da6011b485d8f1
Reviewed-on: https://chromium-review.googlesource.com/c/1289075
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601395}
[modify] https://crrev.com/18e6fc1da6685a6f619f2de575dbf0d67834856f/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/18e6fc1da6685a6f619f2de575dbf0d67834856f/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/18e6fc1da6685a6f619f2de575dbf0d67834856f/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/18e6fc1da6685a6f619f2de575dbf0d67834856f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/18e6fc1da6685a6f619f2de575dbf0d67834856f/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/18e6fc1da6685a6f619f2de575dbf0d67834856f/tools/mb/mb_config.pyl

Blockedon: 897407
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/87f9b97025e8dae2c40e259046dab774e289ecb5

commit 87f9b97025e8dae2c40e259046dab774e289ecb5
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Mon Oct 22 16:25:35 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f6e39a673c0b0204c522ed096031d0a99ed76ebb

commit f6e39a673c0b0204c522ed096031d0a99ed76ebb
Author: smut <smut@google.com>
Date: Tue Oct 23 21:33:01 2018

[GCE Backend] Increase allowable number of instance templates

Bug:  896446 
Change-Id: I721b6937df08d4058afe12ce7b9ff58fcb5a4ebd
Reviewed-on: https://chromium-review.googlesource.com/c/1296921
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/f6e39a673c0b0204c522ed096031d0a99ed76ebb/appengine/gce-backend/config.py
[modify] https://crrev.com/f6e39a673c0b0204c522ed096031d0a99ed76ebb/appengine/gce-backend/config_test.py

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f364c102befc78f67d920ac9283609b8d061c525

commit f364c102befc78f67d920ac9283609b8d061c525
Author: smut <smut@google.com>
Date: Tue Oct 23 21:55:53 2018

[GCE Backend] Remove limit on number of instance templates

Project-specific GCE quota caps this anyway.

Bug:  896446 
Change-Id: I8f4416f47a5b4fe4ae6c765c5b59722a79200d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1297489
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: smut <smut@google.com>

[modify] https://crrev.com/f364c102befc78f67d920ac9283609b8d061c525/appengine/gce-backend/config.py
[modify] https://crrev.com/f364c102befc78f67d920ac9283609b8d061c525/appengine/gce-backend/config_test.py

Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Started)
Lowering priority. At the moment, having the compile/test/report on the same bot makes sense, as the first and the last (compile and report) are resource intensive.  Also, the report requires downloading the instrumented binaries, so splitting increases bandwidth consumption.
Status: WontFix (was: Available)
I don't think we plan to do this anymore.

Sign in to add a comment