New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 896431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 896484
issue 866455


Participants' hotlists:
Audio-Service


Sign in to add a comment

Device change counts in new Audio Service mismatch legacy audio controller code path

Project Member Reported by m...@chromium.org, Oct 17

Issue description

As discussed in bug 866455, the legacy code path does not count output streams that are muted and unmuted, while the new code path increments the "device change" counter each time muting/unmuting occurs.

This bug tracks fixing the new code path to not count mutes as device changes. We will need to merge this into M71 branch, to confirm the UMA counts are correct prior to the upcoming Audio Service launch.

 
Blocking: 896484
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c83fe9271240d3b6501b80ed90b6c4067e46ea

commit c3c83fe9271240d3b6501b80ed90b6c4067e46ea
Author: Yuri Wiitala <miu@chromium.org>
Date: Thu Oct 18 16:25:46 2018

Fix Audio Service "device change UMAs" w.r.t. muting.

Filters mute toggling from being counted in the "device change UMAs," to
provide an apples-to-apples comparison with the counts in in the legacy
media::AudioOutputController code paths. It filters on the "reason" for
stream re-creation to ensure measurements are taken iff they would be
taken in the legacy code paths.

Side note: This is not exactly what we *should* be measuring (i.e., it
is filtering out too much in some cases, and double-counting others).
However, it should be sufficient to prove that stream creation counts/
timing in the new Audio Service is on-par with the legacy code paths.
This is discussed further in fix-it bug 8964843.

Bug:  896431 , 896484, 866455
Change-Id: I677aaf5b485ffa8e605668a87b9bdc06cd3c1ae3
Reviewed-on: https://chromium-review.googlesource.com/c/1287256
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600790}
[modify] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/services/audio/output_controller.cc
[modify] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/services/audio/output_controller.h
[modify] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/services/audio/output_controller_unittest.cc
[modify] https://crrev.com/c3c83fe9271240d3b6501b80ed90b6c4067e46ea/services/audio/output_stream.cc

Labels: M-72
Status: Fixed (was: Started)

Sign in to add a comment